From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [Cake] [PATCH net-next v2] Add Common Applications Kept
 Enhanced (cake) qdisc
Date: Tue, 24 Apr 2018 08:14:06 -0700
Message-ID: <20180424081406.5127f1bc@xeon-e3>
References: <1512338775-3270-1-git-send-email-dave.taht@gmail.com>
        <20180424114407.5939-1-toke@toke.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= <toke@toke.dk>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f194.google.com ([209.85.192.194]:41047 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750770AbeDXPOI (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 24 Apr 2018 11:14:08 -0400
Received: by mail-pf0-f194.google.com with SMTP id v63so2936250pfk.8
        for <netdev@vger.kernel.org>; Tue, 24 Apr 2018 08:14:08 -0700 (PDT)
In-Reply-To: <20180424114407.5939-1-toke@toke.dk>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, 24 Apr 2018 13:44:06 +0200
Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> wrote:

> +static const u8 precedence[] =3D {0, 0, 0, 0, 0, 0, 0, 0,
> +				1, 1, 1, 1, 1, 1, 1, 1,
> +				2, 2, 2, 2, 2, 2, 2, 2,
> +				3, 3, 3, 3, 3, 3, 3, 3,
> +				4, 4, 4, 4, 4, 4, 4, 4,
> +				5, 5, 5, 5, 5, 5, 5, 5,
> +				6, 6, 6, 6, 6, 6, 6, 6,
> +				7, 7, 7, 7, 7, 7, 7, 7,
> +				};

Minor nit.  The kernel style for initializing array should be used
here.

static const u8 precedence[] =3D {
	0, 0, 0, 0, 0, 0, 0, 0,
	1, 1, 1, 1, 1, 1, 1, 1,
...
};