From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757090AbeDXKHa (ORCPT ); Tue, 24 Apr 2018 06:07:30 -0400 Received: from mail-wr0-f179.google.com ([209.85.128.179]:41554 "EHLO mail-wr0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756559AbeDXKH1 (ORCPT ); Tue, 24 Apr 2018 06:07:27 -0400 X-Google-Smtp-Source: AIpwx48TYOABCfIbGaJ7wArFWA3TZAag2cp6CBVrFhalVj/ppgVqeSsLFEwJUN8ElKH9qYjCg44rgQ== Date: Tue, 24 Apr 2018 11:07:23 +0100 From: Lee Jones To: Geert Uytterhoeven Cc: Simon Horman , Wolfram Sang , Linux Kernel Mailing List , Linux-Renesas , Thierry Reding , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , Linux PWM List , DRI Development , Linux Fbdev development list Subject: Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction Message-ID: <20180424100723.hyt3vxa2wp7sruqz@dell> References: <20180410123241.25745-1-wsa+renesas@sang-engineering.com> <20180411073215.fzvh4ejj2kd7wam3@verge.net.au> <20180416091257.swbt7i6zjfbwysg2@dell> <20180424084124.6tpxf3ekadzefwd4@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Apr 2018, Geert Uytterhoeven wrote: > On Tue, Apr 24, 2018 at 10:41 AM, Simon Horman wrote: > > On Mon, Apr 16, 2018 at 10:12:57AM +0100, Lee Jones wrote: > >> On Wed, 11 Apr 2018, Simon Horman wrote: > >> > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote: > >> > > The documentation was wrong, gpiod_get_direction() returns 0/1 instead > >> > > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47 > >> > > ("gpio: correct docs about return value of gpiod_get_direction"). Now, > >> > > fix this user (until a better, system-wide solution is in place). > >> > > > >> > > Signed-off-by: Wolfram Sang > >> > > Acked-by: Daniel Thompson > >> > > >> > Reviewed-by: Simon Horman > >> > >> Thanks for the Reviewed-by Simon. I have applied it to the original mail. > >> > >> Do you know why you mail wasn't sent attached to the original thread? > >> For some reason I received this mail on it's own i.e. not in reply > >> to the original. > > > > No, not off hand. Perhaps I responded to the email in some unusual way > > but by now I don't recall. In any case I'll try to be more careful > > in future. > > I see Lee is using gmail for sending, so I assume also for receiving. Well I'm using their servers, but my set-up is IMAP/Mutt. > While I did receive Simon's reply in-thread, lately I had issues with gmail > not always doing so, and sometimes failing to do deduplication when receiving > email through multiple paths (mailing lists and/or directly). -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction Date: Tue, 24 Apr 2018 11:07:23 +0100 Message-ID: <20180424100723.hyt3vxa2wp7sruqz@dell> References: <20180410123241.25745-1-wsa+renesas@sang-engineering.com> <20180411073215.fzvh4ejj2kd7wam3@verge.net.au> <20180416091257.swbt7i6zjfbwysg2@dell> <20180424084124.6tpxf3ekadzefwd4@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Geert Uytterhoeven Cc: Linux PWM List , Daniel Thompson , Bartlomiej Zolnierkiewicz , Jingoo Han , Linux Kernel Mailing List , DRI Development , Linux-Renesas , Wolfram Sang , Simon Horman , Thierry Reding , Linux Fbdev development list List-Id: linux-pwm@vger.kernel.org T24gVHVlLCAyNCBBcHIgMjAxOCwgR2VlcnQgVXl0dGVyaG9ldmVuIHdyb3RlOgoKPiBPbiBUdWUs IEFwciAyNCwgMjAxOCBhdCAxMDo0MSBBTSwgU2ltb24gSG9ybWFuIDxob3Jtc0B2ZXJnZS5uZXQu YXU+IHdyb3RlOgo+ID4gT24gTW9uLCBBcHIgMTYsIDIwMTggYXQgMTA6MTI6NTdBTSArMDEwMCwg TGVlIEpvbmVzIHdyb3RlOgo+ID4+IE9uIFdlZCwgMTEgQXByIDIwMTgsIFNpbW9uIEhvcm1hbiB3 cm90ZToKPiA+PiA+IE9uIFR1ZSwgQXByIDEwLCAyMDE4IGF0IDAyOjMyOjQwUE0gKzAyMDAsIFdv bGZyYW0gU2FuZyB3cm90ZToKPiA+PiA+ID4gVGhlIGRvY3VtZW50YXRpb24gd2FzIHdyb25nLCBn cGlvZF9nZXRfZGlyZWN0aW9uKCkgcmV0dXJucyAwLzEgaW5zdGVhZAo+ID4+ID4gPiBvZiB0aGUg R1BJT0ZfKiBmbGFncy4gVGhlIGRvY3Mgd2VyZSBmaXhlZCB3aXRoIGNvbW1pdCA5NGZjNzMwOTRh YmU0Nwo+ID4+ID4gPiAoImdwaW86IGNvcnJlY3QgZG9jcyBhYm91dCByZXR1cm4gdmFsdWUgb2Yg Z3Bpb2RfZ2V0X2RpcmVjdGlvbiIpLiBOb3csCj4gPj4gPiA+IGZpeCB0aGlzIHVzZXIgKHVudGls IGEgYmV0dGVyLCBzeXN0ZW0td2lkZSBzb2x1dGlvbiBpcyBpbiBwbGFjZSkuCj4gPj4gPiA+Cj4g Pj4gPiA+IFNpZ25lZC1vZmYtYnk6IFdvbGZyYW0gU2FuZyA8d3NhK3JlbmVzYXNAc2FuZy1lbmdp bmVlcmluZy5jb20+Cj4gPj4gPiA+IEFja2VkLWJ5OiBEYW5pZWwgVGhvbXBzb24gPGRhbmllbC50 aG9tcHNvbkBsaW5hcm8ub3JnPgo+ID4+ID4KPiA+PiA+IFJldmlld2VkLWJ5OiBTaW1vbiBIb3Jt YW4gPGhvcm1zK3JlbmVzYXNAdmVyZ2UubmV0LmF1Pgo+ID4+Cj4gPj4gVGhhbmtzIGZvciB0aGUg UmV2aWV3ZWQtYnkgU2ltb24uICBJIGhhdmUgYXBwbGllZCBpdCB0byB0aGUgb3JpZ2luYWwgbWFp bC4KPiA+Pgo+ID4+IERvIHlvdSBrbm93IHdoeSB5b3UgbWFpbCB3YXNuJ3Qgc2VudCBhdHRhY2hl ZCB0byB0aGUgb3JpZ2luYWwgdGhyZWFkPwo+ID4+IEZvciBzb21lIHJlYXNvbiBJIHJlY2VpdmVk IHRoaXMgbWFpbCBvbiBpdCdzIG93biBpLmUuIG5vdCBpbiByZXBseQo+ID4+IHRvIHRoZSBvcmln aW5hbC4KPiA+Cj4gPiBObywgbm90IG9mZiBoYW5kLiBQZXJoYXBzIEkgcmVzcG9uZGVkIHRvIHRo ZSBlbWFpbCBpbiBzb21lIHVudXN1YWwgd2F5Cj4gPiBidXQgYnkgbm93IEkgZG9uJ3QgcmVjYWxs LiBJbiBhbnkgY2FzZSBJJ2xsIHRyeSB0byBiZSBtb3JlIGNhcmVmdWwKPiA+IGluIGZ1dHVyZS4K PiAKPiBJIHNlZSBMZWUgaXMgdXNpbmcgZ21haWwgZm9yIHNlbmRpbmcsIHNvIEkgYXNzdW1lIGFs c28gZm9yIHJlY2VpdmluZy4KCldlbGwgSSdtIHVzaW5nIHRoZWlyIHNlcnZlcnMsIGJ1dCBteSBz ZXQtdXAgaXMgSU1BUC9NdXR0LgoKPiBXaGlsZSBJIGRpZCByZWNlaXZlIFNpbW9uJ3MgcmVwbHkg aW4tdGhyZWFkLCBsYXRlbHkgSSBoYWQgaXNzdWVzIHdpdGggZ21haWwKPiBub3QgYWx3YXlzIGRv aW5nIHNvLCBhbmQgc29tZXRpbWVzIGZhaWxpbmcgdG8gZG8gZGVkdXBsaWNhdGlvbiB3aGVuIHJl Y2VpdmluZwo+IGVtYWlsIHRocm91Z2ggbXVsdGlwbGUgcGF0aHMgKG1haWxpbmcgbGlzdHMgYW5k L29yIGRpcmVjdGx5KS4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KTGluYXJvIFNlcnZpY2Vz IFRlY2huaWNhbCBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBB Uk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Tue, 24 Apr 2018 10:07:23 +0000 Subject: Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction Message-Id: <20180424100723.hyt3vxa2wp7sruqz@dell> List-Id: References: <20180410123241.25745-1-wsa+renesas@sang-engineering.com> <20180411073215.fzvh4ejj2kd7wam3@verge.net.au> <20180416091257.swbt7i6zjfbwysg2@dell> <20180424084124.6tpxf3ekadzefwd4@verge.net.au> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Geert Uytterhoeven Cc: Linux PWM List , Daniel Thompson , Bartlomiej Zolnierkiewicz , Jingoo Han , Linux Kernel Mailing List , DRI Development , Linux-Renesas , Wolfram Sang , Simon Horman , Thierry Reding , Linux Fbdev development list On Tue, 24 Apr 2018, Geert Uytterhoeven wrote: > On Tue, Apr 24, 2018 at 10:41 AM, Simon Horman wrote: > > On Mon, Apr 16, 2018 at 10:12:57AM +0100, Lee Jones wrote: > >> On Wed, 11 Apr 2018, Simon Horman wrote: > >> > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote: > >> > > The documentation was wrong, gpiod_get_direction() returns 0/1 instead > >> > > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47 > >> > > ("gpio: correct docs about return value of gpiod_get_direction"). Now, > >> > > fix this user (until a better, system-wide solution is in place). > >> > > > >> > > Signed-off-by: Wolfram Sang > >> > > Acked-by: Daniel Thompson > >> > > >> > Reviewed-by: Simon Horman > >> > >> Thanks for the Reviewed-by Simon. I have applied it to the original mail. > >> > >> Do you know why you mail wasn't sent attached to the original thread? > >> For some reason I received this mail on it's own i.e. not in reply > >> to the original. > > > > No, not off hand. Perhaps I responded to the email in some unusual way > > but by now I don't recall. In any case I'll try to be more careful > > in future. > > I see Lee is using gmail for sending, so I assume also for receiving. Well I'm using their servers, but my set-up is IMAP/Mutt. > While I did receive Simon's reply in-thread, lately I had issues with gmail > not always doing so, and sometimes failing to do deduplication when receiving > email through multiple paths (mailing lists and/or directly). -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog