From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: [PATCH v3 4/5] eal: set affinity for control threads Date: Tue, 24 Apr 2018 16:46:50 +0200 Message-ID: <20180424144651.13145-5-olivier.matz@6wind.com> References: <20180403130439.11151-1-olivier.matz@6wind.com> <20180424144651.13145-1-olivier.matz@6wind.com> Cc: Anatoly Burakov To: dev@dpdk.org Return-path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 6F70A4C6F for ; Tue, 24 Apr 2018 16:47:13 +0200 (CEST) In-Reply-To: <20180424144651.13145-1-olivier.matz@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The management threads must not bother the dataplane or service cores. Set the affinity of these threads accordingly. Signed-off-by: Olivier Matz Reviewed-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_thread.c | 22 +++++++++++++++++++++- lib/librte_eal/common/include/rte_lcore.h | 4 +++- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c index 94d2a6e42..4e75cb81f 100644 --- a/lib/librte_eal/common/eal_common_thread.c +++ b/lib/librte_eal/common/eal_common_thread.c @@ -16,6 +16,7 @@ #include #include +#include "eal_private.h" #include "eal_thread.h" RTE_DECLARE_PER_LCORE(unsigned , _socket_id); @@ -169,7 +170,9 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name, .start_routine = start_routine, .arg = arg, }; - int ret; + unsigned int lcore_id; + rte_cpuset_t cpuset; + int cpu_found, ret; pthread_barrier_init(¶ms.configured, NULL, 2); @@ -183,6 +186,23 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name, goto fail; } + cpu_found = 0; + CPU_ZERO(&cpuset); + for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { + if (eal_cpu_detected(lcore_id) && + rte_lcore_has_role(lcore_id, ROLE_OFF)) { + CPU_SET(lcore_id, &cpuset); + cpu_found = 1; + } + } + /* if no detected cpu is off, use master core */ + if (!cpu_found) + CPU_SET(rte_get_master_lcore(), &cpuset); + + ret = pthread_setaffinity_np(*thread, sizeof(cpuset), &cpuset); + if (ret < 0) + goto fail; + pthread_barrier_wait(¶ms.configured); return 0; diff --git a/lib/librte_eal/common/include/rte_lcore.h b/lib/librte_eal/common/include/rte_lcore.h index eb39c2a8b..334a0629e 100644 --- a/lib/librte_eal/common/include/rte_lcore.h +++ b/lib/librte_eal/common/include/rte_lcore.h @@ -279,7 +279,9 @@ int rte_thread_setname(pthread_t id, const char *name); /** * Create a control thread. * - * Wrapper to pthread_create() and pthread_setname_np(). + * Wrapper to pthread_create(), pthread_setname_np() and + * pthread_setaffinity_np(). The dataplane and service lcores are + * excluded from the affinity of the new thread. * * @param thread * Filled with the thread id of the new created thread. -- 2.11.0