From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751047AbeDXQmK (ORCPT ); Tue, 24 Apr 2018 12:42:10 -0400 Received: from mail-ot0-f196.google.com ([74.125.82.196]:37554 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757AbeDXQmI (ORCPT ); Tue, 24 Apr 2018 12:42:08 -0400 X-Google-Smtp-Source: AIpwx49KzRTuNID/UhrHMBHRUHTmJMkS69cxzh3K3oQ9Uc/ZMcpZyYd8V/3kEkq6w8kehXAAyzRduQ== Date: Tue, 24 Apr 2018 11:42:07 -0500 From: Rob Herring To: Chen-Yu Tsai Cc: Maxime Ripard , David Airlie , Thierry Reding , Mark Rutland , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Jonathan Liu Subject: Re: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel Message-ID: <20180424164207.ay4ai6lbspgv6anw@rob-hp-laptop> References: <20180419093225.614-1-wens@csie.org> <20180419093225.614-5-wens@csie.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180419093225.614-5-wens@csie.org> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 19, 2018 at 05:32:23PM +0800, Chen-Yu Tsai wrote: > This panel is marketed as Banana Pi 7" LCD display. On the back is > a sticker denoting the model name S070WV20-CT16. > > This is a 7" 800x480 panel connected through a 24-bit RGB interface. > However the panel only does 262k colors. > > Signed-off-by: Chen-Yu Tsai > --- > .../display/panel/bananapi,s070wv20-ct16.txt | 7 ++++++ > drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++ > 2 files changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt > new file mode 100644 > index 000000000000..2ec35ce36e9a > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt > @@ -0,0 +1,7 @@ > +Banana Pi 7" (S070WV20-CT16) TFT LCD Panel > + > +Required properties: > +- compatible: should be "bananapi,s070wv20-ct16" > + > +This binding is compatible with the simple-panel binding, which is specified > +in simple-panel.txt in this directory. Does this panel have a power supply (or more than 1) or backlight? I can't know that by just refering to simple-panel.txt. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel Date: Tue, 24 Apr 2018 11:42:07 -0500 Message-ID: <20180424164207.ay4ai6lbspgv6anw@rob-hp-laptop> References: <20180419093225.614-1-wens@csie.org> <20180419093225.614-5-wens@csie.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180419093225.614-5-wens@csie.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chen-Yu Tsai Cc: Mark Rutland , devicetree@vger.kernel.org, Jonathan Liu , Maxime Ripard , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , Thierry Reding , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org T24gVGh1LCBBcHIgMTksIDIwMTggYXQgMDU6MzI6MjNQTSArMDgwMCwgQ2hlbi1ZdSBUc2FpIHdy b3RlOgo+IFRoaXMgcGFuZWwgaXMgbWFya2V0ZWQgYXMgQmFuYW5hIFBpIDciIExDRCBkaXNwbGF5 LiBPbiB0aGUgYmFjayBpcwo+IGEgc3RpY2tlciBkZW5vdGluZyB0aGUgbW9kZWwgbmFtZSBTMDcw V1YyMC1DVDE2Lgo+IAo+IFRoaXMgaXMgYSA3IiA4MDB4NDgwIHBhbmVsIGNvbm5lY3RlZCB0aHJv dWdoIGEgMjQtYml0IFJHQiBpbnRlcmZhY2UuCj4gSG93ZXZlciB0aGUgcGFuZWwgb25seSBkb2Vz IDI2MmsgY29sb3JzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IENoZW4tWXUgVHNhaSA8d2Vuc0Bjc2ll Lm9yZz4KPiAtLS0KPiAgLi4uL2Rpc3BsYXkvcGFuZWwvYmFuYW5hcGksczA3MHd2MjAtY3QxNi50 eHQgIHwgIDcgKysrKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1zaW1wbGUuYyAg ICAgICAgICB8IDI1ICsrKysrKysrKysrKysrKysrKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCAzMiBp bnNlcnRpb25zKCspCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvZGlzcGxheS9wYW5lbC9iYW5hbmFwaSxzMDcwd3YyMC1jdDE2LnR4dAo+IAo+ IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9w YW5lbC9iYW5hbmFwaSxzMDcwd3YyMC1jdDE2LnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL2JhbmFuYXBpLHMwNzB3djIwLWN0MTYudHh0Cj4gbmV3 IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAuLjJlYzM1Y2UzNmU5YQo+IC0t LSAvZGV2L251bGwKPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlz cGxheS9wYW5lbC9iYW5hbmFwaSxzMDcwd3YyMC1jdDE2LnR4dAo+IEBAIC0wLDAgKzEsNyBAQAo+ ICtCYW5hbmEgUGkgNyIgKFMwNzBXVjIwLUNUMTYpIFRGVCBMQ0QgUGFuZWwKPiArCj4gK1JlcXVp cmVkIHByb3BlcnRpZXM6Cj4gKy0gY29tcGF0aWJsZTogc2hvdWxkIGJlICJiYW5hbmFwaSxzMDcw d3YyMC1jdDE2Igo+ICsKPiArVGhpcyBiaW5kaW5nIGlzIGNvbXBhdGlibGUgd2l0aCB0aGUgc2lt cGxlLXBhbmVsIGJpbmRpbmcsIHdoaWNoIGlzIHNwZWNpZmllZAo+ICtpbiBzaW1wbGUtcGFuZWwu dHh0IGluIHRoaXMgZGlyZWN0b3J5LgoKRG9lcyB0aGlzIHBhbmVsIGhhdmUgYSBwb3dlciBzdXBw bHkgKG9yIG1vcmUgdGhhbiAxKSBvciBiYWNrbGlnaHQ/IEkgCmNhbid0IGtub3cgdGhhdCBieSBq dXN0IHJlZmVyaW5nIHRvIHNpbXBsZS1wYW5lbC50eHQuCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Tue, 24 Apr 2018 11:42:07 -0500 Subject: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel In-Reply-To: <20180419093225.614-5-wens@csie.org> References: <20180419093225.614-1-wens@csie.org> <20180419093225.614-5-wens@csie.org> Message-ID: <20180424164207.ay4ai6lbspgv6anw@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Apr 19, 2018 at 05:32:23PM +0800, Chen-Yu Tsai wrote: > This panel is marketed as Banana Pi 7" LCD display. On the back is > a sticker denoting the model name S070WV20-CT16. > > This is a 7" 800x480 panel connected through a 24-bit RGB interface. > However the panel only does 262k colors. > > Signed-off-by: Chen-Yu Tsai > --- > .../display/panel/bananapi,s070wv20-ct16.txt | 7 ++++++ > drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++ > 2 files changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt > new file mode 100644 > index 000000000000..2ec35ce36e9a > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt > @@ -0,0 +1,7 @@ > +Banana Pi 7" (S070WV20-CT16) TFT LCD Panel > + > +Required properties: > +- compatible: should be "bananapi,s070wv20-ct16" > + > +This binding is compatible with the simple-panel binding, which is specified > +in simple-panel.txt in this directory. Does this panel have a power supply (or more than 1) or backlight? I can't know that by just refering to simple-panel.txt.