From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751525AbeDXTh5 convert rfc822-to-8bit (ORCPT ); Tue, 24 Apr 2018 15:37:57 -0400 Received: from mail.bootlin.com ([62.4.15.54]:37053 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750791AbeDXTh4 (ORCPT ); Tue, 24 Apr 2018 15:37:56 -0400 Date: Tue, 24 Apr 2018 21:37:54 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: devicetree , linux-arm-kernel , linux-kernel , Neil Armstrong Subject: Re: [PATCH 2/7] ARM: dts: sun8i: h3: Split out common board design for ALL-H3-CC Message-ID: <20180424193754.jsuucbq57onhxhqe@flea> References: <20180424113424.13196-1-wens@csie.org> <20180424113424.13196-3-wens@csie.org> <20180424121353.zxujyehsw3er2xq6@flea> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: User-Agent: NeoMutt/20180323 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 24, 2018 at 08:17:11PM +0800, Chen-Yu Tsai wrote: > On Tue, Apr 24, 2018 at 8:13 PM, Maxime Ripard > wrote: > > On Tue, Apr 24, 2018 at 07:34:19PM +0800, Chen-Yu Tsai wrote: > >> The Libre Computer Project ALL-H3-CC has three models, all using the > >> same board design, but with different pin compatible SoCs and amount of > >> DRAM. > >> > >> Currently only the H3 1GB DRAM variant is supported. To support the two > >> other variants, first split the original device tree into a common board > >> design part and an SoC specific part. > >> > >> The SoC part only defines which SoC is used and model name, and includes > >> the SoC specific dtsi file and the common design dtsi file. > >> > >> Also fix up the SPDX identifier line to use the correct comment style, > >> and place it on the first line. > >> > >> Signed-off-by: Chen-Yu Tsai > >> --- > >> .../boot/dts/sun8i-h3-libretech-all-h3-cc.dts | 213 +----------------- > >> ....dts => sunxi-hx-libretech-all-h3-cc.dtsi} | 11 +- > > > > I think I prefer the name of Neil's DTSI better, and since pretty much > > the same patches (a couple of hours) before, we'll merge them (while > > merging the rest of your patches, obviously). > > > > Does that work for you? > > I would like for the regulator voltage fix to be merged before the split. > This will make it trivial to back port, instead of having to reverse the > split, and maybe failing. Yes, I was just talking about replacing your two redundant patches, but keeping the order you have. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@bootlin.com (Maxime Ripard) Date: Tue, 24 Apr 2018 21:37:54 +0200 Subject: [PATCH 2/7] ARM: dts: sun8i: h3: Split out common board design for ALL-H3-CC In-Reply-To: References: <20180424113424.13196-1-wens@csie.org> <20180424113424.13196-3-wens@csie.org> <20180424121353.zxujyehsw3er2xq6@flea> Message-ID: <20180424193754.jsuucbq57onhxhqe@flea> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Apr 24, 2018 at 08:17:11PM +0800, Chen-Yu Tsai wrote: > On Tue, Apr 24, 2018 at 8:13 PM, Maxime Ripard > wrote: > > On Tue, Apr 24, 2018 at 07:34:19PM +0800, Chen-Yu Tsai wrote: > >> The Libre Computer Project ALL-H3-CC has three models, all using the > >> same board design, but with different pin compatible SoCs and amount of > >> DRAM. > >> > >> Currently only the H3 1GB DRAM variant is supported. To support the two > >> other variants, first split the original device tree into a common board > >> design part and an SoC specific part. > >> > >> The SoC part only defines which SoC is used and model name, and includes > >> the SoC specific dtsi file and the common design dtsi file. > >> > >> Also fix up the SPDX identifier line to use the correct comment style, > >> and place it on the first line. > >> > >> Signed-off-by: Chen-Yu Tsai > >> --- > >> .../boot/dts/sun8i-h3-libretech-all-h3-cc.dts | 213 +----------------- > >> ....dts => sunxi-hx-libretech-all-h3-cc.dtsi} | 11 +- > > > > I think I prefer the name of Neil's DTSI better, and since pretty much > > the same patches (a couple of hours) before, we'll merge them (while > > merging the rest of your patches, obviously). > > > > Does that work for you? > > I would like for the regulator voltage fix to be merged before the split. > This will make it trivial to back port, instead of having to reverse the > split, and maybe failing. Yes, I was just talking about replacing your two redundant patches, but keeping the order you have. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com