All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] ipc: Adding new return type vm_fault_t
@ 2018-04-25  4:34 Souptick Joarder
  2018-05-10 14:04 ` Souptick Joarder
  0 siblings, 1 reply; 4+ messages in thread
From: Souptick Joarder @ 2018-04-25  4:34 UTC (permalink / raw)
  To: akpm, viro, manfred, dave, ebiederm, linux; +Cc: linux-kernel

Use new return type vm_fault_t for fault handler. For
now, this is just documenting that the function returns
a VM_FAULT value rather than an errno. Once all instances
are converted, vm_fault_t will become a distinct type.

Commit 1c8f422059ae ("mm: change return type to vm_fault_t")

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
---
v2: Updated the change log

 ipc/shm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipc/shm.c b/ipc/shm.c
index 4643865..2ba0cfc 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -378,7 +378,7 @@ void exit_shm(struct task_struct *task)
 	up_write(&shm_ids(ns).rwsem);
 }
 
-static int shm_fault(struct vm_fault *vmf)
+static vm_fault_t shm_fault(struct vm_fault *vmf)
 {
 	struct file *file = vmf->vma->vm_file;
 	struct shm_file_data *sfd = shm_file_data(file);
-- 
1.9.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] ipc: Adding new return type vm_fault_t
  2018-04-25  4:34 [PATCH v2] ipc: Adding new return type vm_fault_t Souptick Joarder
@ 2018-05-10 14:04 ` Souptick Joarder
  2018-05-16  4:44   ` Souptick Joarder
  0 siblings, 1 reply; 4+ messages in thread
From: Souptick Joarder @ 2018-05-10 14:04 UTC (permalink / raw)
  To: Andrew Morton, Al Viro, manfred, dave, ebiederm, linux
  Cc: linux-kernel, Matthew Wilcox

On Wed, Apr 25, 2018 at 10:04 AM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
>
> Commit 1c8f422059ae ("mm: change return type to vm_fault_t")
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
> ---
> v2: Updated the change log
>
>  ipc/shm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ipc/shm.c b/ipc/shm.c
> index 4643865..2ba0cfc 100644
> --- a/ipc/shm.c
> +++ b/ipc/shm.c
> @@ -378,7 +378,7 @@ void exit_shm(struct task_struct *task)
>         up_write(&shm_ids(ns).rwsem);
>  }
>
> -static int shm_fault(struct vm_fault *vmf)
> +static vm_fault_t shm_fault(struct vm_fault *vmf)
>  {
>         struct file *file = vmf->vma->vm_file;
>         struct shm_file_data *sfd = shm_file_data(file);
> --
> 1.9.1
>

Any comment for this patch ?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] ipc: Adding new return type vm_fault_t
  2018-05-10 14:04 ` Souptick Joarder
@ 2018-05-16  4:44   ` Souptick Joarder
  2018-05-18  5:11     ` Davidlohr Bueso
  0 siblings, 1 reply; 4+ messages in thread
From: Souptick Joarder @ 2018-05-16  4:44 UTC (permalink / raw)
  To: Andrew Morton, Al Viro, manfred, dave, ebiederm, linux
  Cc: linux-kernel, Matthew Wilcox

On Thu, May 10, 2018 at 7:34 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> On Wed, Apr 25, 2018 at 10:04 AM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
>> Use new return type vm_fault_t for fault handler. For
>> now, this is just documenting that the function returns
>> a VM_FAULT value rather than an errno. Once all instances
>> are converted, vm_fault_t will become a distinct type.
>>
>> Commit 1c8f422059ae ("mm: change return type to vm_fault_t")
>>
>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
>> ---
>> v2: Updated the change log
>>
>>  ipc/shm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ipc/shm.c b/ipc/shm.c
>> index 4643865..2ba0cfc 100644
>> --- a/ipc/shm.c
>> +++ b/ipc/shm.c
>> @@ -378,7 +378,7 @@ void exit_shm(struct task_struct *task)
>>         up_write(&shm_ids(ns).rwsem);
>>  }
>>
>> -static int shm_fault(struct vm_fault *vmf)
>> +static vm_fault_t shm_fault(struct vm_fault *vmf)
>>  {
>>         struct file *file = vmf->vma->vm_file;
>>         struct shm_file_data *sfd = shm_file_data(file);
>> --
>> 1.9.1
>>
>
> Any comment for this patch ?

If no further comment, we would like to get this
patch in queue for 4.18.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] ipc: Adding new return type vm_fault_t
  2018-05-16  4:44   ` Souptick Joarder
@ 2018-05-18  5:11     ` Davidlohr Bueso
  0 siblings, 0 replies; 4+ messages in thread
From: Davidlohr Bueso @ 2018-05-18  5:11 UTC (permalink / raw)
  To: Souptick Joarder
  Cc: Andrew Morton, Al Viro, manfred, ebiederm, linux, linux-kernel,
	Matthew Wilcox

On Wed, 16 May 2018, Souptick Joarder wrote:

>On Thu, May 10, 2018 at 7:34 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
>> On Wed, Apr 25, 2018 at 10:04 AM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
>>> Use new return type vm_fault_t for fault handler. For
>>> now, this is just documenting that the function returns
>>> a VM_FAULT value rather than an errno. Once all instances
>>> are converted, vm_fault_t will become a distinct type.
>>>
>>> Commit 1c8f422059ae ("mm: change return type to vm_fault_t")
>>>
>>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>>> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>

Acked-by: Davidlohr Bueso <dbueso@suse.de>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-05-18  5:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-25  4:34 [PATCH v2] ipc: Adding new return type vm_fault_t Souptick Joarder
2018-05-10 14:04 ` Souptick Joarder
2018-05-16  4:44   ` Souptick Joarder
2018-05-18  5:11     ` Davidlohr Bueso

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.