All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH v1 0/5] Add fastboot UDP support
Date: Wed, 25 Apr 2018 09:57:21 +0200	[thread overview]
Message-ID: <20180425095721.22c95152@jawa> (raw)
In-Reply-To: <20180425095210.294d25af@jawa>

Hi Alex,

> > - the USB and UDP code want consolidating, with this series there
> > would then be two separate implementations of the same protocol  
> 
> Yes - this is an issue. 
> 
> For USB the fastboot protocol (at least some its logic) is implemented
> in drivers/usb/gadget/f_fastboot.c
> 
> I think that some medium agnostic code (like protocol itself) can be
> unified.
> 
> I also think that it would be a good idea to have ./drivers/fastboot
> directory introduced to move common code there - and leave only USB
> related code in f_fastboot.c

Especially that we do have fb_nand.c and fb_mmc.c in ./common.

In that way we could move them to ./drivers/fastboot.

> 
> Please as a reference, look on how ./drivers/dfu is organised.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180425/83fe83f8/attachment.sig>

  reply	other threads:[~2018-04-25  7:57 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24  9:37 [U-Boot] [RFC PATCH v1 0/5] Add fastboot UDP support Alex Kiernan
2018-04-24  9:37 ` [U-Boot] [RFC PATCH v1 1/5] dfu: Refactor fastboot_okay/fail to take response Alex Kiernan
2018-04-25  7:27   ` Lukasz Majewski
2018-04-25  8:10     ` Alex Kiernan
2018-04-24  9:37 ` [U-Boot] [RFC PATCH v1 2/5] dfu: Extract fastboot_okay/fail to fb_common.c Alex Kiernan
2018-04-25  7:32   ` Lukasz Majewski
2018-04-25  8:15     ` Alex Kiernan
2018-04-24  9:37 ` [U-Boot] [RFC PATCH v1 3/5] net: dfu: Merge AOSP UDP fastboot Alex Kiernan
2018-04-24  9:37 ` [U-Boot] [RFC PATCH v1 4/5] dfu: Resolve Kconfig dependency loops Alex Kiernan
2018-04-25  7:53   ` Lukasz Majewski
2018-04-25  8:55     ` Alex Deymo
2018-04-24  9:37 ` [U-Boot] [RFC PATCH v1 5/5] net: dfu: Support building without MMC Alex Kiernan
2018-04-24 10:24 ` [U-Boot] [RFC PATCH v1 0/5] Add fastboot UDP support Alex Deymo
2018-04-24 11:58   ` Alex Kiernan
2018-04-24 17:10     ` Jocelyn Bohr
2018-04-25  7:53       ` Alex Kiernan
2018-04-25 12:50         ` Alex Kiernan
2018-04-25 15:19           ` Lukasz Majewski
2018-04-26  3:27       ` Kever Yang
2018-04-27  8:04         ` Lukasz Majewski
2018-04-27 12:20           ` Alex Kiernan
2018-04-30  8:37             ` Alex Kiernan
2018-05-01  6:16               ` Jocelyn Bohr
2018-04-25  7:40     ` Lukasz Majewski
2018-04-25  7:52 ` Lukasz Majewski
2018-04-25  7:57   ` Lukasz Majewski [this message]
2018-04-25  8:43   ` Alex Kiernan
2018-04-25  8:46     ` Alex Deymo
2018-04-27 19:10 ` Sam Protsenko
2018-04-27 19:23   ` Alex Kiernan
2018-04-30  8:56   ` Alex Deymo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180425095721.22c95152@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.