All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH v8 0/8] Add make check tests for Migration
@ 2018-04-25 11:19 Juan Quintela
  2018-04-25 11:19 ` [Qemu-devel] [PATCH v8 1/8] qemu-sockets: Export SocketAddress_to_str Juan Quintela
                   ` (7 more replies)
  0 siblings, 8 replies; 16+ messages in thread
From: Juan Quintela @ 2018-04-25 11:19 UTC (permalink / raw)
  To: qemu-devel; +Cc: dgilbert, lvivier, peterx, berrange


Hi

v8:
- just rebase to make things continue to wonk


New in the other v7:
- SocketAddress is now a list (a.k.a make happy danp)
- Rebase on top of upstream
  network listener is *interesting*
- *HACK* to make SocketAddress list in common
  see patch: create-socket-paramenter

Please review, Juan.

CC: berrange@redhat.com

[v7]
This is v6, it differest from the patches that I sent with previous
multifd post:
- Rename x-tcp-port to x-socket-address
  This is more *complicated* that it looks as:

  * it is a pointer, so I need to use QAPI_CLONE() to make info
    migrate work

  * this is an union of structs.  In QAPI. So, a dict of strings.  The
    only way that I was able to make things work is parsing the qdict
    to a SocketAddress and then output a SocketAddress as an str.  It
    needs to be an easier way, for sure.

  * Cleanups here andthere.

Please, review, Juan.

[v5]
- Several patches moved to pull request
- merge info_migrate and migration_tests
  only missing bit is tcp_port, needed for tcp tests
- Rename tcp-port to x-tcp-port
  We will get better naming from David at some point, and we will use that bit
- ppc: use inline code as suggested by lvivier

Please, review.

It is based on my previous pull request

Based-on: 20180129120932.12874-1-quintela@redhat.com

[v4]
- rebase on top on v4 info_migrate patches
- Tune sleeps to make patches fast
- Create a deprecated test for deprecated commands (i.e. make peterxu happy)
- create migrate_start_postcopy function
- fix naming/sizes between power and x86
- cleanup comments to match code

[v3]

- No more tests for deprecated parameters. Now I only use
  migrate_set_parameter.  If there is a deprecated command for that,
  we tests it there.
- free "result" string, always good to return memory (Peter found it)
- use the new tcp_port parameter from info migrate.  So we are
  handling well the tcp case.
- lots of code movement around to make everything consistent.
- Several patches already integrated upstream.

[v2]
- to make review easier, I started renaming postcopy-test.c to migration-test.c
- Did cleanups/refactoring there
- Don't use global-qtest anymore
- check that the parameters that we sent got really set
- RFH: comrpress threads tests is not working for some weird reason.  Using the same code on command line works.
  still investigating why.

ToDoo:

- tcp: after discussions with dave, we ended in conclusion that we
  need to use the 0 port and let the system gives us a free one

  But .... that means that we need to be able to get that port back somehow.
  "info migrate" woring on destination side?

- compression threads.  There is some weird interaction with the test
  hardness and every migration thread get waiting in a different
  semaphore.  Investigating if it is a race/bug/whateverr

- deprecated commands: There was a suggestion to make
  migrate_set_parameter look at the parameter name and test old/new
  depending on something.  Not sure what to do here.

- testing commands: Is there a way to launch qemu and just sent
  qmp/hmp commands without having to really run anything else?

[v1]
- add test for precopy for unix/tcp
  exec and fd to came, don't know how to test rdma without hardware
- add tests using deprecated interfaces
- add test for xbzrle
  Note to myself, there is no way to set the cache size with migraton_set_parameters
- Add test for compress threads
  disabled on the series, right now it appears that compression is not working at all
- Move postcopy to use new results
  Idea is to move it on top of migration-test.c, but first I want some reviews on basic idea

Juan Quintela (8):
  qemu-sockets: Export SocketAddress_to_str
  tests: Add migration precopy test
  tests: Add migration xbzrle test
  migration: Create socket-address parameter
  tests: Migration ppc now inlines its program
  tests: Add basic migration precopy tcp test
  migration: Add multifd test
  [RFH] tests: Add migration compress threads tests

 chardev/char-socket.c  |  29 ----
 hmp.c                  |  14 ++
 include/qemu/sockets.h |   3 +
 migration/migration.c  |  25 ++++
 migration/migration.h  |   1 +
 migration/socket.c     |  11 ++
 qapi/migration.json    |  13 +-
 qapi/sockets.json      |  13 ++
 tests/migration-test.c | 332 ++++++++++++++++++++++++++++++++++++-----
 util/qemu-sockets.c    |  29 ++++
 10 files changed, 398 insertions(+), 72 deletions(-)

-- 
2.17.0

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2018-05-08 15:38 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-25 11:19 [Qemu-devel] [PATCH v8 0/8] Add make check tests for Migration Juan Quintela
2018-04-25 11:19 ` [Qemu-devel] [PATCH v8 1/8] qemu-sockets: Export SocketAddress_to_str Juan Quintela
2018-05-02 16:13   ` Dr. David Alan Gilbert
2018-05-02 16:17   ` Daniel P. Berrangé
2018-04-25 11:19 ` [Qemu-devel] [PATCH v8 2/8] tests: Add migration precopy test Juan Quintela
2018-04-25 11:19 ` [Qemu-devel] [PATCH v8 3/8] tests: Add migration xbzrle test Juan Quintela
2018-05-03 17:31   ` Dr. David Alan Gilbert
2018-05-08 15:16     ` Juan Quintela
2018-05-08 15:38       ` Dr. David Alan Gilbert
2018-04-25 11:19 ` [Qemu-devel] [PATCH v8 4/8] migration: Create socket-address parameter Juan Quintela
2018-04-25 11:19 ` [Qemu-devel] [PATCH v8 5/8] tests: Migration ppc now inlines its program Juan Quintela
2018-05-02 11:51   ` Laurent Vivier
2018-05-02 13:41   ` Thomas Huth
2018-04-25 11:19 ` [Qemu-devel] [PATCH v8 6/8] tests: Add basic migration precopy tcp test Juan Quintela
2018-04-25 11:19 ` [Qemu-devel] [PATCH v8 7/8] migration: Add multifd test Juan Quintela
2018-04-25 11:19 ` [Qemu-devel] [PATCH v8 8/8] [RFH] tests: Add migration compress threads tests Juan Quintela

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.