All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Takashi Iwai <tiwai@suse.de>,
	Marcel Holtmann <marcel@holtmann.org>,
	"M. Kristall" <mkpdev@gmail.com>,
	linux-bluetooth@vger.kernel.org
Subject: Re: [4.15 stable regression] "Bluetooth: btusb: Fix quirk for Atheros 1525/QCA6174" breaks bluetooth on some devices
Date: Wed, 25 Apr 2018 14:47:57 +0200	[thread overview]
Message-ID: <20180425124757.GA29829@kroah.com> (raw)
In-Reply-To: <9a752bfc-74bf-25e7-8820-91d1e3163b75@redhat.com>

On Wed, Apr 25, 2018 at 02:40:37PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 18-04-18 15:18, Hans de Goede wrote:
> > Hi Takashi, Marcel,
> > 
> > It seems that this commit:
> > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?h=linux-4.15.y&id=7ec32f585fefd7c154453aa29ccf8fa2a11cc865
> > 
> > Is breaking bluetooth on some devices, see:
> > 
> > https://bugzilla.redhat.com/show_bug.cgi?id=1568911
> > 
> > The problem is the following error now being thrown:
> > 
> > [   28.466248] Bluetooth: hci0: don't support firmware rome 0x1020200
> > 
> > Looking at the code I wonder if maybe we need to mask the ver_rom
> > with & 0xfff when comparing it to the qca_devices_table[i].rom_version
> > filed ?
> > 
> > Or maybe the commit is actually wrong, or maybe devices with the
> > 0cf3:3004 USB id need either the BTUSB_QCA_ROM or BTUSB_ATH3012
> > quirk depending on the device and we need to probe this somehow?
> 
> I've been receiving more complaints from users about this on
> various devices, so I think that the 7ec32f585fefd7c154453aa29ccf8fa2a11cc865
> commit should be reverted from 4.15.x while we figure this out.
> 
> Does anyone have any idea how we cam distinguish between the 2
> different versions which seem to be hiding between the same USB-id ?

4.15.y is end-of-life, so there is no more releases being made for it,
sorry.

But, this commit is in 4.4.y, 4.9.y, 4.14.y, and 4.16.  Can you revert
it in Linus's tree and I can revert it everywhere else as well?

thanks,

greg k-h

  reply	other threads:[~2018-04-25 12:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 13:18 [4.15 stable regression] "Bluetooth: btusb: Fix quirk for Atheros 1525/QCA6174" breaks bluetooth on some devices Hans de Goede
2018-04-19  6:08 ` Takashi Iwai
2018-04-25 12:40 ` Hans de Goede
2018-04-25 12:47   ` Greg Kroah-Hartman [this message]
2018-04-25 12:49     ` Hans de Goede
2018-04-25 13:01       ` Greg Kroah-Hartman
2018-04-25 13:10       ` Takashi Iwai
2018-04-26 12:18         ` Hans de Goede
2018-04-26 16:33           ` Takashi Iwai
2018-04-26 18:27             ` Takashi Iwai
2018-04-27  8:57               ` Hans de Goede
2018-04-27  9:23                 ` Hans de Goede
2018-04-27 12:20                   ` Takashi Iwai
2018-04-27 12:11                 ` Hans de Goede
2018-04-27 12:19                   ` Takashi Iwai
2018-05-16 13:19                   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180425124757.GA29829@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mkpdev@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.