From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:41796 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754074AbeDYO0e (ORCPT ); Wed, 25 Apr 2018 10:26:34 -0400 Date: Wed, 25 Apr 2018 16:26:27 +0200 From: Greg KH To: Youquan Song Cc: stable@vger.kernel.org, tim.c.chen@linux.intel.com, ashok.raj@intel.com, dave.hansen@intel.com, yi.y.sun@linux.intel.com, youquan.song@linux.intel.com, Paolo Bonzini , David Woodhouse , KarimAllah Ahmed , Linus Torvalds , Peter Zijlstra , Radim =?utf-8?B?S3LEjW3DocWZ?= , Thomas Gleixner , kvm@vger.kernel.org Subject: Re: [PATCH 22/24] KVM/x86: Remove indirect MSR op calls from SPEC_CTRL Message-ID: <20180425142627.GG25610@kroah.com> References: <1524021512-24022-1-git-send-email-youquan.song@intel.com> <1524021512-24022-23-git-send-email-youquan.song@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1524021512-24022-23-git-send-email-youquan.song@intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Apr 18, 2018 at 11:18:30AM +0800, Youquan Song wrote: > From: Paolo Bonzini > > commit ecb586bd29c99fb4de599dec388658e74388daad upstream. > > Having a paravirt indirect call in the IBRS restore path is not a > good idea, since we are trying to protect from speculative execution > of bogus indirect branch targets. It is also slower, so use > native_wrmsrl() on the vmentry path too. > > Signed-off-by: Paolo Bonzini > Reviewed-by: Jim Mattson > Cc: David Woodhouse > Cc: KarimAllah Ahmed > Cc: Linus Torvalds > Cc: Peter Zijlstra > Cc: Radim Krčmář > Cc: Thomas Gleixner > Cc: kvm@vger.kernel.org > Cc: stable@vger.kernel.org > Fixes: d28b387fb74da95d69d2615732f50cceb38e9a4d > Link: http://lkml.kernel.org/r/20180222154318.20361-2-pbonzini@redhat.com > Signed-off-by: Ingo Molnar > Signed-off-by: Yi Sun [v4.4 backport] > > Conflicts: > arch/x86/kvm/svm.c Ugh :(