From mboxrd@z Thu Jan 1 00:00:00 1970 From: YueHaibing Subject: [PATCH net-next] bridge: use hlist_entry_safe Date: Thu, 26 Apr 2018 11:07:05 +0800 Message-ID: <20180426030705.6632-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , , YueHaibing To: , Return-path: Received: from szxga06-in.huawei.com ([45.249.212.32]:33281 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750868AbeDZDIK (ORCPT ); Wed, 25 Apr 2018 23:08:10 -0400 Sender: netdev-owner@vger.kernel.org List-ID: Use hlist_entry_safe() instead of open-coding it. Signed-off-by: YueHaibing --- net/bridge/br_forward.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c index b4eed11..7a7fd67 100644 --- a/net/bridge/br_forward.c +++ b/net/bridge/br_forward.c @@ -274,8 +274,7 @@ void br_multicast_flood(struct net_bridge_mdb_entry *mdst, struct net_bridge_port *port, *lport, *rport; lport = p ? p->port : NULL; - rport = rp ? hlist_entry(rp, struct net_bridge_port, rlist) : - NULL; + rport = hlist_entry_safe(rp, struct net_bridge_port, rlist); if ((unsigned long)lport > (unsigned long)rport) { port = lport; -- 2.7.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: YueHaibing Date: Thu, 26 Apr 2018 11:07:05 +0800 Message-ID: <20180426030705.6632-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Bridge] [PATCH net-next] bridge: use hlist_entry_safe List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: stephen@networkplumber.org, davem@davemloft.net Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, YueHaibing Use hlist_entry_safe() instead of open-coding it. Signed-off-by: YueHaibing --- net/bridge/br_forward.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c index b4eed11..7a7fd67 100644 --- a/net/bridge/br_forward.c +++ b/net/bridge/br_forward.c @@ -274,8 +274,7 @@ void br_multicast_flood(struct net_bridge_mdb_entry *mdst, struct net_bridge_port *port, *lport, *rport; lport = p ? p->port : NULL; - rport = rp ? hlist_entry(rp, struct net_bridge_port, rlist) : - NULL; + rport = hlist_entry_safe(rp, struct net_bridge_port, rlist); if ((unsigned long)lport > (unsigned long)rport) { port = lport; -- 2.7.0