From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [RFC PATCH v3 3/3] acpi: apei: Warn when GHES marks correctable errors as "fatal" Date: Thu, 26 Apr 2018 13:20:57 +0200 Message-ID: <20180426112057.GB15009@pd.tnic> References: <20180416215903.7318-1-mr.nuke.me@gmail.com> <20180425203957.18224-1-mr.nuke.me@gmail.com> <20180425203957.18224-4-mr.nuke.me@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20180425203957.18224-4-mr.nuke.me@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Alexandru Gagniuc Cc: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Tony Luck , Mauro Carvalho Chehab , Robert Moore , Erik Schmauss , Tyler Baicar , Will Deacon , James Morse , Shiju Jose , "Jonathan (Zhixiong) Zhang" , Dongjiu Geng , linux-kernel@vger.kernel.org, devel@acpica.org List-Id: linux-acpi@vger.kernel.org On Wed, Apr 25, 2018 at 03:39:51PM -0500, Alexandru Gagniuc wrote: > There seems to be a culture amongst BIOS teams to want to crash the > OS when an error can't be handled in firmware. Marking GHES errors as > "fatal" is a very common way to do this. > > However, a number of errors reported by GHES may be fatal in the sense > a device or link is lost, but are not fatal to the system. When there > is a disagreement with firmware about the handleability of an error, > print a warning message. > > Signed-off-by: Alexandru Gagniuc > --- > drivers/acpi/apei/ghes.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index 8ccb9cc10fc8..34d0da692dd0 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -539,6 +539,12 @@ static void ghes_do_proc(struct ghes *ghes, > sec_sev, err, > gdata->error_data_length); > } > + > + } > + > + if ((sev >= GHES_SEV_PANIC) && (ghes_actual_severity(ghes) < sev)) { > + pr_warn("FIRMWARE BUG: Firmware sent fatal error that we were able to correct"); > + pr_warn("BROKEN FIRMWARE: Complain to your hardware vendor"); Pasting the same comment from last time since you missed it: "No, I don't want any of that crap issuing stuff in dmesg and then people opening bugs and running around and trying to replace hardware. We either can handle the error and log a normal record somewhere or we cannot and explode. The complaining about the FW doesn't bring shit." -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v3,3/3] acpi: apei: Warn when GHES marks correctable errors as "fatal" From: Borislav Petkov Message-Id: <20180426112057.GB15009@pd.tnic> Date: Thu, 26 Apr 2018 13:20:57 +0200 To: Alexandru Gagniuc Cc: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Tony Luck , Mauro Carvalho Chehab , Robert Moore , Erik Schmauss , Tyler Baicar , Will Deacon , James Morse , Shiju Jose , "Jonathan (Zhixiong) Zhang" , Dongjiu Geng , linux-kernel@vger.kernel.org, devel@acpica.org List-ID: T24gV2VkLCBBcHIgMjUsIDIwMTggYXQgMDM6Mzk6NTFQTSAtMDUwMCwgQWxleGFuZHJ1IEdhZ25p dWMgd3JvdGU6Cj4gVGhlcmUgc2VlbXMgdG8gYmUgYSBjdWx0dXJlIGFtb25nc3QgQklPUyB0ZWFt cyB0byB3YW50IHRvIGNyYXNoIHRoZQo+IE9TIHdoZW4gYW4gZXJyb3IgY2FuJ3QgYmUgaGFuZGxl ZCBpbiBmaXJtd2FyZS4gTWFya2luZyBHSEVTIGVycm9ycyBhcwo+ICJmYXRhbCIgaXMgYSB2ZXJ5 IGNvbW1vbiB3YXkgdG8gZG8gdGhpcy4KPiAKPiBIb3dldmVyLCBhIG51bWJlciBvZiBlcnJvcnMg cmVwb3J0ZWQgYnkgR0hFUyBtYXkgYmUgZmF0YWwgaW4gdGhlIHNlbnNlCj4gYSBkZXZpY2Ugb3Ig bGluayBpcyBsb3N0LCBidXQgYXJlIG5vdCBmYXRhbCB0byB0aGUgc3lzdGVtLiBXaGVuIHRoZXJl Cj4gaXMgYSBkaXNhZ3JlZW1lbnQgd2l0aCBmaXJtd2FyZSBhYm91dCB0aGUgaGFuZGxlYWJpbGl0 eSBvZiBhbiBlcnJvciwKPiBwcmludCBhIHdhcm5pbmcgbWVzc2FnZS4KPiAKPiBTaWduZWQtb2Zm LWJ5OiBBbGV4YW5kcnUgR2Fnbml1YyA8bXIubnVrZS5tZUBnbWFpbC5jb20+Cj4gLS0tCj4gIGRy aXZlcnMvYWNwaS9hcGVpL2doZXMuYyB8IDYgKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA2IGlu c2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9hY3BpL2FwZWkvZ2hlcy5jIGIv ZHJpdmVycy9hY3BpL2FwZWkvZ2hlcy5jCj4gaW5kZXggOGNjYjljYzEwZmM4Li4zNGQwZGE2OTJk ZDAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9hY3BpL2FwZWkvZ2hlcy5jCj4gKysrIGIvZHJpdmVy cy9hY3BpL2FwZWkvZ2hlcy5jCj4gQEAgLTUzOSw2ICs1MzksMTIgQEAgc3RhdGljIHZvaWQgZ2hl c19kb19wcm9jKHN0cnVjdCBnaGVzICpnaGVzLAo+ICAJCQkJCSAgICAgICBzZWNfc2V2LCBlcnIs Cj4gIAkJCQkJICAgICAgIGdkYXRhLT5lcnJvcl9kYXRhX2xlbmd0aCk7Cj4gIAkJfQo+ICsKPiAr CX0KPiArCj4gKwlpZiAoKHNldiA+PSBHSEVTX1NFVl9QQU5JQykgJiYgKGdoZXNfYWN0dWFsX3Nl dmVyaXR5KGdoZXMpIDwgc2V2KSkgewo+ICsJCXByX3dhcm4oIkZJUk1XQVJFIEJVRzogRmlybXdh cmUgc2VudCBmYXRhbCBlcnJvciB0aGF0IHdlIHdlcmUgYWJsZSB0byBjb3JyZWN0Iik7Cj4gKwkJ cHJfd2FybigiQlJPS0VOIEZJUk1XQVJFOiBDb21wbGFpbiB0byB5b3VyIGhhcmR3YXJlIHZlbmRv ciIpOwoKUGFzdGluZyB0aGUgc2FtZSBjb21tZW50IGZyb20gbGFzdCB0aW1lIHNpbmNlIHlvdSBt aXNzZWQgaXQ6CgoiTm8sIEkgZG9uJ3Qgd2FudCBhbnkgb2YgdGhhdCBjcmFwIGlzc3Vpbmcgc3R1 ZmYgaW4gZG1lc2cgYW5kIHRoZW4gcGVvcGxlCm9wZW5pbmcgYnVncyBhbmQgcnVubmluZyBhcm91 bmQgYW5kIHRyeWluZyB0byByZXBsYWNlIGhhcmR3YXJlLgoKV2UgZWl0aGVyIGNhbiBoYW5kbGUg dGhlIGVycm9yIGFuZCBsb2cgYSBub3JtYWwgcmVjb3JkIHNvbWV3aGVyZSBvciB3ZQpjYW5ub3Qg YW5kIGV4cGxvZGUuIFRoZSBjb21wbGFpbmluZyBhYm91dCB0aGUgRlcgZG9lc24ndCBicmluZyBz aGl0LiIK