All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Nisar.Sayed@microchip.com
Cc: f.fainelli@gmail.com, davem@davemloft.net,
	UNGLinuxDriver@microchip.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] microchipT1phy: Add driver for Microchip LAN87XX T1 PHYs
Date: Thu, 26 Apr 2018 14:27:43 +0200	[thread overview]
Message-ID: <20180426122743.GB13467@lunn.ch> (raw)
In-Reply-To: <CE371C1263339941885964188A0225FA3B0CB2@CHN-SV-EXMX03.mchp-main.com>

> Fine, will change the filename.

> The reason for moving to separate file is that we have a series of
> T1 standard PHYs, which support cable diagnostics, signal quality
> indicator(SQI) and sleep and wakeup (TC10) support etc. we planned
> to keep all T1 standard PHYs separate to support additional features
> supported by these PHYs.

Is there anything shared with the other microchip PHYs? If there is
potential for code sharing, you should do it.

> > > + */
> > > +#ifndef _MICROCHIPT1PHY_H_
> > > +#define _MICROCHIPT1PHY_H_
> > > +
> > > +/* Interrupt Source Register */
> > > +#define LAN87XX_INTERRUPT_SOURCE                (0x18)
> > > +
> > > +/* Interrupt Mask Register */
> > > +#define LAN87XX_INTERRUPT_MASK                  (0x19)
> > > +#define LAN87XX_MASK_LINK_UP                    (0x0004)
> > > +#define LAN87XX_MASK_LINK_DOWN                  (0x0002)
> > 
> > What's the point of that header file if all definitions are consumed by the
> > same driver?
> > 
> 
> We have planned a series of patches where we planned to use this further.

Are you adding multiple files which share the header? If not, just add
the defines to the C code.

    Andrew

  reply	other threads:[~2018-04-26 12:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25 18:49 [PATCH net-next] microchipT1phy: Add driver for Microchip LAN87XX T1 PHYs Nisar Sayed
2018-04-25 14:21 ` Florian Fainelli
2018-04-26  7:02   ` Nisar.Sayed
2018-04-26 12:27     ` Andrew Lunn [this message]
2018-04-26 17:24       ` Nisar.Sayed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180426122743.GB13467@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Nisar.Sayed@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.