From: Gerd Hoffmann <kraxel@redhat.com>
To: Tina Zhang <tina.zhang@intel.com>
Cc: alex.williamson@redhat.com, zhenyuw@linux.intel.com,
hang.yuan@intel.com, intel-gvt-dev@lists.freedesktop.org,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 2/2] ui: introduce vfio_display_reset
Date: Thu, 26 Apr 2018 15:02:24 +0200 [thread overview]
Message-ID: <20180426130224.pvcs34fy66wqltbk@sirius.home.kraxel.org> (raw)
In-Reply-To: <1524730880-7154-3-git-send-email-tina.zhang@intel.com>
> /* ---------------------------------------------------------------------- */
> +void vfio_display_reset(VFIOPCIDevice *vdev)
> +{
> + if (!vdev || !vdev->dpy || !vdev->dpy->con) {
> + return;
> + }
> +
> + dpy_gl_scanout_disable(vdev->dpy->con);
> + vfio_display_dmabuf_exit(vdev->dpy);
> + dpy_gfx_update_full(vdev->dpy->con);
> +}
> + /* vfio_display_reset is needed by dma-buf based vfio display */
> + if (vdev->display != ON_OFF_AUTO_OFF && dpy &&
> + dpy->dmabuf.primary) {
Well, the check should be inside the vfio_display_reset() function, so
the display specific code is contained to display.c.
cheers,
Gerd
prev parent reply other threads:[~2018-04-26 13:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 8:21 [Qemu-devel] [PATCH v3 0/2] Add vfio dma-buf based display reset handling Tina Zhang
2018-04-26 8:21 ` [Qemu-devel] [PATCH v3 1/2] console: introduce dpy_gfx_update_full Tina Zhang
2018-04-26 8:21 ` [Qemu-devel] [PATCH v3 2/2] ui: introduce vfio_display_reset Tina Zhang
2018-04-26 13:02 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426130224.pvcs34fy66wqltbk@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=hang.yuan@intel.com \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=qemu-devel@nongnu.org \
--cc=tina.zhang@intel.com \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.