Re: [RFC PATCH 1/2] ACPI / PNP: Don't add "enumeration_by_parent" devices

From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: John Garry <john.garry@huawei.com>
Cc: andriy.shevchenko@linux.intel.com, rjw@rjwysocki.net,
	linux-acpi@vger.kernel.org, lenb@kernel.org,
	lorenzo.pieralisi@arm.com, linux-kernel@vger.kernel.org,
	arnd@arndb.de, graeme.gregory@linaro.org, helgaas@kernel.org,
	linuxarm@huawei.com, z.liuxinliang@hisilicon.com,
	"Liguozhu (Kenneth)" <liguozhu@hisilicon.com>
Subject: Re: [RFC PATCH 1/2] ACPI / PNP: Don't add "enumeration_by_parent" devices
Date: Thu, 26 Apr 2018 17:08:08 +0300	[thread overview]
Message-ID: <20180426140808.GK2173@lahna.fi.intel.com> (raw)
In-Reply-To: <09e3aa95-86ae-ca30-7bb5-a9704d296b43@huawei.com>

On Thu, Apr 26, 2018 at 02:49:49PM +0100, John Garry wrote:
> diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
> index 2d4611e..b04425b 100644
> --- a/drivers/bus/hisi_lpc.c
> +++ b/drivers/bus/hisi_lpc.c
> @@ -18,6 +18,8 @@
>  #include <linux/of_platform.h>
>  #include <linux/pci.h>
>  #include <linux/slab.h>
> +#include <linux/serial_8250.h>
> +#include "../tty/serial/8250/8250.h"
> 
>  #define DRV_NAME "hisi-lpc"
> 
> @@ -345,6 +347,7 @@ static void hisi_lpc_comm_outs(void *hostdata, unsigned
> long pio,
>  #define MFD_CHILD_NAME_LEN (ACPI_ID_LEN + sizeof(MFD_CHILD_NAME_PREFIX) -
> 1)
> 
>  struct hisi_lpc_mfd_cell {
> +	struct plat_serial8250_port serial8250_port;
>  	struct mfd_cell_acpi_match acpi_match;
>  	char name[MFD_CHILD_NAME_LEN];
>  	char pnpid[ACPI_ID_LEN];
> @@ -513,10 +516,31 @@ static int hisi_lpc_acpi_probe(struct device *hostdev)
>  		dev_warn(&child->dev, "set resource fail (%d)\n", ret);
>  			return ret;
>  		}
> +	if (!strcmp(acpi_device_hid(child), "HISI1031")) {

Hmm, there is a way in struct mfd_cell to match child devices using _HID
so is there something preventing you from using that?