All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Simon Horman <horms+renesas@verge.net.au>
Cc: linux-renesas-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Magnus Damm <magnus.damm@gmail.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH 07/10] ARM: dts: kzm9d: Drop unnecessary address properties from gpio_keys node
Date: Thu, 26 Apr 2018 16:52:13 +0200	[thread overview]
Message-ID: <20180426145213.GD3315@bigcity.dyn.berto.se> (raw)
In-Reply-To: <20180426102951.8683-8-horms+renesas@verge.net.au>

Hi Simon,

Thanks for your work.

On 2018-04-26 12:29:48 +0200, Simon Horman wrote:
> The gpio_keys node does not have an address and thus does not need
> address-cells or address size-properties.
> 
> This is flagged by dtc as follows:
>  # make dtbs W=1
>  arch/arm/boot/dts/r8a7794-silk.dtb: Warning (avoid_unnecessary_addr_size): /soc/video@e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

This warning don't seem to match with the change nor the rest of the 
commit message :-)

With that addressed and for the whole series:

Reviewed-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>

> 
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm/boot/dts/emev2-kzm9d.dts | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/emev2-kzm9d.dts b/arch/arm/boot/dts/emev2-kzm9d.dts
> index c238407133bf..0af44b7eadb9 100644
> --- a/arch/arm/boot/dts/emev2-kzm9d.dts
> +++ b/arch/arm/boot/dts/emev2-kzm9d.dts
> @@ -34,9 +34,6 @@
>  
>  	gpio_keys {
>  		compatible = "gpio-keys";
> -		#address-cells = <1>;
> -		#size-cells = <0>;
> -
>  		one {
>  			debounce-interval = <50>;
>  			wakeup-source;
> -- 
> 2.11.0
> 

-- 
Regards,
Niklas S�derlund

WARNING: multiple messages have this Message-ID (diff)
From: niklas.soderlund@ragnatech.se (Niklas Söderlund)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/10] ARM: dts: kzm9d: Drop unnecessary address properties from gpio_keys node
Date: Thu, 26 Apr 2018 16:52:13 +0200	[thread overview]
Message-ID: <20180426145213.GD3315@bigcity.dyn.berto.se> (raw)
In-Reply-To: <20180426102951.8683-8-horms+renesas@verge.net.au>

Hi Simon,

Thanks for your work.

On 2018-04-26 12:29:48 +0200, Simon Horman wrote:
> The gpio_keys node does not have an address and thus does not need
> address-cells or address size-properties.
> 
> This is flagged by dtc as follows:
>  # make dtbs W=1
>  arch/arm/boot/dts/r8a7794-silk.dtb: Warning (avoid_unnecessary_addr_size): /soc/video at e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

This warning don't seem to match with the change nor the rest of the 
commit message :-)

With that addressed and for the whole series:

Reviewed-by: Niklas S?derlund <niklas.soderlund+renesas@ragnatech.se>

> 
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm/boot/dts/emev2-kzm9d.dts | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/emev2-kzm9d.dts b/arch/arm/boot/dts/emev2-kzm9d.dts
> index c238407133bf..0af44b7eadb9 100644
> --- a/arch/arm/boot/dts/emev2-kzm9d.dts
> +++ b/arch/arm/boot/dts/emev2-kzm9d.dts
> @@ -34,9 +34,6 @@
>  
>  	gpio_keys {
>  		compatible = "gpio-keys";
> -		#address-cells = <1>;
> -		#size-cells = <0>;
> -
>  		one {
>  			debounce-interval = <50>;
>  			wakeup-source;
> -- 
> 2.11.0
> 

-- 
Regards,
Niklas S?derlund

  reply	other threads:[~2018-04-26 14:52 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26 10:29 [PATCH 00/10] ARM, arm64: dts: renesas: update register properties Simon Horman
2018-04-26 10:29 ` Simon Horman
2018-04-26 10:29 ` [PATCH 01/10] ARM: dts: lager: Drop unnecessary address properties from port node Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-04-26 10:29 ` [PATCH 02/10] ARM: dts: porter: Drop unnecessary address properties from vin " Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-04-26 10:29 ` [PATCH 03/10] ARM: dts: gose: Drop unnecessary address properties from port nodes Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-04-26 10:29 ` [PATCH 04/10] ARM: dts: koelsch: " Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-04-26 10:29 ` [PATCH 05/10] ARM: dts: alt: Drop unnecessary address properties from vin port node Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-04-26 10:29 ` [PATCH 06/10] ARM: dts: silk: " Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-04-26 10:29 ` [PATCH 07/10] ARM: dts: kzm9d: Drop unnecessary address properties from gpio_keys node Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-04-26 14:52   ` Niklas Söderlund [this message]
2018-04-26 14:52     ` Niklas Söderlund
2018-04-30  7:07     ` Simon Horman
2018-04-30  7:07       ` Simon Horman
2018-05-02  6:56       ` Simon Horman
2018-05-02  6:56         ` Simon Horman
2018-04-26 10:29 ` [PATCH 08/10] arm64: dts: renesas: r8a7795: Add address properties to rcar_sound port nodes Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-04-26 10:29 ` [PATCH 09/10] arm64: dts: renesas: r8a7796: " Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-04-26 10:29 ` [PATCH 10/10] arm64: dts: renesas: r8a77965: " Simon Horman
2018-04-26 10:29   ` Simon Horman
2018-05-02 13:10 ` [PATCH 00/10] ARM, arm64: dts: renesas: update register properties Geert Uytterhoeven
2018-05-02 13:10   ` Geert Uytterhoeven
2018-05-09 18:48   ` Simon Horman
2018-05-09 18:48     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180426145213.GD3315@bigcity.dyn.berto.se \
    --to=niklas.soderlund@ragnatech.se \
    --cc=horms+renesas@verge.net.au \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.