From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: Re: [PATCH] tty/serial: atmel: use port->name as name in request_irq() Date: Thu, 26 Apr 2018 17:12:22 +0200 Message-ID: <20180426151222.6vw67lwqmu6ffgnw@linutronix.de> References: <20180426150625.q5tqcb7fzchvkb5d@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180426150625.q5tqcb7fzchvkb5d@linutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: linux-serial@vger.kernel.org Cc: Alexandre Belloni , Peter Hurley , Richard Genoud , Greg Kroah-Hartman , Jiri Slaby , tglx@linutronix.de, linux-arm-kernel@lists.infradead.org List-Id: linux-serial@vger.kernel.org On 2018-04-26 17:06:25 [+0200], To linux-serial@vger.kernel.org wrote: > It seems not to happen in v4.1.51 but it happens in v4.9 and v4.17-rc2 > so if it broke accidentally it was not recently. This is what I used to check: diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -170,7 +170,7 @@ void free_tty_struct(struct tty_struct *tty) put_device(tty->dev); kfree(tty->write_buf); tty->magic = 0xDEADDEAD; - kfree(tty); + strcpy(tty->name, "GONE"); } static inline struct tty_struct *file_tty(struct file *file) If this is unknown and a bisect is requested, please let me know. Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 From: bigeasy@linutronix.de (Sebastian Andrzej Siewior) Date: Thu, 26 Apr 2018 17:12:22 +0200 Subject: [PATCH] tty/serial: atmel: use port->name as name in request_irq() In-Reply-To: <20180426150625.q5tqcb7fzchvkb5d@linutronix.de> References: <20180426150625.q5tqcb7fzchvkb5d@linutronix.de> Message-ID: <20180426151222.6vw67lwqmu6ffgnw@linutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2018-04-26 17:06:25 [+0200], To linux-serial at vger.kernel.org wrote: > It seems not to happen in v4.1.51 but it happens in v4.9 and v4.17-rc2 > so if it broke accidentally it was not recently. This is what I used to check: diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -170,7 +170,7 @@ void free_tty_struct(struct tty_struct *tty) put_device(tty->dev); kfree(tty->write_buf); tty->magic = 0xDEADDEAD; - kfree(tty); + strcpy(tty->name, "GONE"); } static inline struct tty_struct *file_tty(struct file *file) If this is unknown and a bisect is requested, please let me know. Sebastian