From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED From: mdf@kernel.org Message-Id: <20180426174000.12008-1-mdf@kernel.org> Date: Thu, 26 Apr 2018 10:40:00 -0700 To: linux-kernel@vger.kernel.org Cc: dmaengine@vger.kernel.org, dan.j.williams@intel.com, vinod.koul@intel.com, lars@metafoo.de, Moritz Fischer List-ID: UmVxdWVzdCBJUlEgd2l0aCBJUlFGX1NIQVJFRCBmbGFnLiBUaGlzIHdvcmtzIHNpbmNlIHRoZSBp bnRlcnJ1cHQKaGFuZGxlciBhbHJlYWR5IGNoZWNrcyBpZiB0aGVyZSBpcyBhbiBhY3R1YWwgSVJR IHBlbmRpbmcgYW5kIHJldHVybnMKSVJRX05PTkUgb3RoZXJ3aXNlLgoKQWNrZWQtYnk6IExhcnMt UGV0ZXIgQ2xhdXNlbiA8bGFyc0BtZXRhZm9vLmRlPgpTaWduZWQtb2ZmLWJ5OiBNb3JpdHogRmlz Y2hlciA8bWRmQGtlcm5lbC5vcmc+Ci0tLQpDaGFuZ2VzIGZyb20gdjE6Ci0gQWRkZWQgTGFycycg QWNrZWQtYnkKLSBEcm9wcGVkIHBhdGNoIFsxLzJdIGFuZCBjaGFuZ2VkIGFjY29yZGluZ2x5Ci0t LQogZHJpdmVycy9kbWEvZG1hLWF4aS1kbWFjLmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBp bnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2RtYS9kbWEt YXhpLWRtYWMuYyBiL2RyaXZlcnMvZG1hL2RtYS1heGktZG1hYy5jCmluZGV4IDI0MTlmZTUyNGRh YS4uMTViMjQ1M2QyNjQ3IDEwMDY0NAotLS0gYS9kcml2ZXJzL2RtYS9kbWEtYXhpLWRtYWMuYwor KysgYi9kcml2ZXJzL2RtYS9kbWEtYXhpLWRtYWMuYwpAQCAtNjg3LDcgKzY4Nyw3IEBAIHN0YXRp YyBpbnQgYXhpX2RtYWNfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKIAlpZiAo cmV0KQogCQlnb3RvIGVycl91bnJlZ2lzdGVyX2RldmljZTsKIAotCXJldCA9IHJlcXVlc3RfaXJx KGRtYWMtPmlycSwgYXhpX2RtYWNfaW50ZXJydXB0X2hhbmRsZXIsIDAsCisJcmV0ID0gcmVxdWVz dF9pcnEoZG1hYy0+aXJxLCBheGlfZG1hY19pbnRlcnJ1cHRfaGFuZGxlciwgSVJRRl9TSEFSRUQs CiAJCWRldl9uYW1lKCZwZGV2LT5kZXYpLCBkbWFjKTsKIAlpZiAocmV0KQogCQlnb3RvIGVycl91 bnJlZ2lzdGVyX29mOwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756918AbeDZRqd (ORCPT ); Thu, 26 Apr 2018 13:46:33 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:38879 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756801AbeDZRqa (ORCPT ); Thu, 26 Apr 2018 13:46:30 -0400 X-Google-Smtp-Source: AIpwx48AOenzanFMUJ6Bes2XHyGG+SU0rfgyH537IIWHDAJ4FMjSuEZVMsCRbBE49MkpY0iRXdGLTA== From: Moritz Fischer To: linux-kernel@vger.kernel.org Cc: dmaengine@vger.kernel.org, dan.j.williams@intel.com, vinod.koul@intel.com, lars@metafoo.de, Moritz Fischer Subject: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED Date: Thu, 26 Apr 2018 10:40:00 -0700 Message-Id: <20180426174000.12008-1-mdf@kernel.org> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Request IRQ with IRQF_SHARED flag. This works since the interrupt handler already checks if there is an actual IRQ pending and returns IRQ_NONE otherwise. Acked-by: Lars-Peter Clausen Signed-off-by: Moritz Fischer --- Changes from v1: - Added Lars' Acked-by - Dropped patch [1/2] and changed accordingly --- drivers/dma/dma-axi-dmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c index 2419fe524daa..15b2453d2647 100644 --- a/drivers/dma/dma-axi-dmac.c +++ b/drivers/dma/dma-axi-dmac.c @@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev) if (ret) goto err_unregister_device; - ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0, + ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, IRQF_SHARED, dev_name(&pdev->dev), dmac); if (ret) goto err_unregister_of; -- 2.17.0