From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.kernel.org ([198.145.29.99]:55400 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751269AbeDZShQ (ORCPT <rfc822;stable@vger.kernel.org>);
        Thu, 26 Apr 2018 14:37:16 -0400
Date: Thu, 26 Apr 2018 20:37:07 +0200
From: Greg KH <greg@kroah.com>
To: Dmitry Shmidt <dimitrysh@google.com>
Cc: stable@vger.kernel.org
Subject: Re: console: Drop added "static" for newport_con
Message-ID: <20180426183707.GA24867@kroah.com>
References: <CAH7ZN-yVx4Xx0PfGyR-bE9smUFBWy7EF1G+RX0fsd43o9ak-wg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAH7ZN-yVx4Xx0PfGyR-bE9smUFBWy7EF1G+RX0fsd43o9ak-wg@mail.gmail.com>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Thu, Apr 26, 2018 at 10:46:50AM -0700, Dmitry Shmidt wrote:
> Please add this patch to stable 4.14
> 
> commit f54450ad1942287cc76b38021c0441fc4901d2de
> Author: Kees Cook <keescook@chromium.org>
> Date:   Tue Feb 27 13:11:21 2018 -0800
> 
>     console: Drop added "static" for newport_con
> 
>     Commit 4fe505119778 ("console: Expand dummy functions for CFI") accidentally
>     added "static" to newport_con instance of struct consw, while trying to
>     normalize the declarations. This, however, needed to stay non-static as it
>     has an extern.
> 
>     Reported-by: kbuild test robot <fengguang.wu@intel.com>
>     Fixes: 4fe505119778 ("console: Expand dummy functions for CFI")
>     Signed-off-by: Kees Cook <keescook@chromium.org>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


Why does 4.14.y need it?

It really fixes commit c396a5bf457f ("console: Expand dummy functions
for CFI") which only showed up in 4.17-rc1.

Why would 4.14.y need it?

confused,

greg k-h