From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.kernel.org ([198.145.29.99]:34298 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751269AbeDZT1D (ORCPT <rfc822;stable@vger.kernel.org>);
        Thu, 26 Apr 2018 15:27:03 -0400
Date: Thu, 26 Apr 2018 21:26:54 +0200
From: Greg KH <greg@kroah.com>
To: Dmitry Shmidt <dimitrysh@google.com>
Cc: stable@vger.kernel.org
Subject: Re: console: Drop added "static" for newport_con
Message-ID: <20180426192654.GA31241@kroah.com>
References: <CAH7ZN-yVx4Xx0PfGyR-bE9smUFBWy7EF1G+RX0fsd43o9ak-wg@mail.gmail.com>
 <20180426183707.GA24867@kroah.com>
 <CAH7ZN-zxdfWO=x_2CyuydgoZyuMc8jxob33OPjbedLEOXNFQ1g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAH7ZN-zxdfWO=x_2CyuydgoZyuMc8jxob33OPjbedLEOXNFQ1g@mail.gmail.com>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Thu, Apr 26, 2018 at 12:19:17PM -0700, Dmitry Shmidt wrote:
> On Thu, Apr 26, 2018 at 11:37 AM, Greg KH <greg@kroah.com> wrote:
> > On Thu, Apr 26, 2018 at 10:46:50AM -0700, Dmitry Shmidt wrote:
> >> Please add this patch to stable 4.14
> >>
> >> commit f54450ad1942287cc76b38021c0441fc4901d2de
> >> Author: Kees Cook <keescook@chromium.org>
> >> Date:   Tue Feb 27 13:11:21 2018 -0800
> >>
> >>     console: Drop added "static" for newport_con
> >>
> >>     Commit 4fe505119778 ("console: Expand dummy functions for CFI") accidentally
> >>     added "static" to newport_con instance of struct consw, while trying to
> >>     normalize the declarations. This, however, needed to stay non-static as it
> >>     has an extern.
> >>
> >>     Reported-by: kbuild test robot <fengguang.wu@intel.com>
> >>     Fixes: 4fe505119778 ("console: Expand dummy functions for CFI")
> >>     Signed-off-by: Kees Cook <keescook@chromium.org>
> >>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> >
> > Why does 4.14.y need it?
> 
> https://kernelci.org/build/android/branch/android-4.14/kernel/ASB-2018-04-05_4.14-637-gbb60f28e486c/

Why would I care about an android-specific branch for the kernel.org
releases?  :)

> Errors Summary
> 
> 2drivers/video/console/newport_con.c:683:27: error: static declaration
> of 'newport_con' follows non-static declaration

Ok, but:

> > It really fixes commit c396a5bf457f ("console: Expand dummy functions
> > for CFI") which only showed up in 4.17-rc1.

As this commit is not in the 4.14.y tree, why should it be applied
there?

Still confused,

greg k-h