From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] nfp: don't depend on eth_tbl being available
Date: Fri, 27 Apr 2018 11:15:56 -0400 (EDT)
Message-ID: <20180427.111556.1931814913979522341.davem@davemloft.net>
References: <20180425182108.31363-1-jakub.kicinski@netronome.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com
To: jakub.kicinski@netronome.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:53292 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933590AbeD0PP6 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 27 Apr 2018 11:15:58 -0400
In-Reply-To: <20180425182108.31363-1-jakub.kicinski@netronome.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Wed, 25 Apr 2018 11:21:08 -0700

> For very very old generation of the management FW Ethernet port
> information table may theoretically not be available.  This in
> turn will cause the nfp_port structures to not be allocated.
> 
> Make sure we don't crash the kernel when there is no eth_tbl:
> 
> RIP: 0010:nfp_net_pci_probe+0xf2/0xb40 [nfp]
> ...
> Call Trace:
>   nfp_pci_probe+0x6de/0xab0 [nfp]
>   local_pci_probe+0x47/0xa0
>   work_for_cpu_fn+0x1a/0x30
>   process_one_work+0x1de/0x3e0
> 
> Found while working with broken/development version of management FW.
> 
> Fixes: a5950182c00e ("nfp: map mac_stats and vf_cfg BARs")
> Fixes: 93da7d9660ee ("nfp: provide nfp_port to of nfp_net_get_mac_addr()")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>

Applied, thanks Jakub.

Do you want this queued up for -stable?  It seems borderline, at best, to me.