From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED From: Vinod Koul Message-Id: <20180427051115.GX6014@localhost> Date: Fri, 27 Apr 2018 10:41:15 +0530 To: Moritz Fischer Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, dan.j.williams@intel.com, lars@metafoo.de List-ID: T24gVGh1LCBBcHIgMjYsIDIwMTggYXQgMTA6NDA6MDBBTSAtMDcwMCwgTW9yaXR6IEZpc2NoZXIg d3JvdGU6Cj4gUmVxdWVzdCBJUlEgd2l0aCBJUlFGX1NIQVJFRCBmbGFnLiBUaGlzIHdvcmtzIHNp bmNlIHRoZSBpbnRlcnJ1cHQKPiBoYW5kbGVyIGFscmVhZHkgY2hlY2tzIGlmIHRoZXJlIGlzIGFu IGFjdHVhbCBJUlEgcGVuZGluZyBhbmQgcmV0dXJucwo+IElSUV9OT05FIG90aGVyd2lzZS4KCmht bW0gd2hhdCBhcmUgd2UgdHJ5aW5nIHRvIGZpeCBoZXJlPyBJcyB5b3VyIGRldmljZSBvbiBhIHNo YXJlZCBsaW5lIG9yIG5vdD8KCj4gCj4gQWNrZWQtYnk6IExhcnMtUGV0ZXIgQ2xhdXNlbiA8bGFy c0BtZXRhZm9vLmRlPgo+IFNpZ25lZC1vZmYtYnk6IE1vcml0eiBGaXNjaGVyIDxtZGZAa2VybmVs Lm9yZz4KPiAtLS0KPiBDaGFuZ2VzIGZyb20gdjE6Cj4gLSBBZGRlZCBMYXJzJyBBY2tlZC1ieQo+ IC0gRHJvcHBlZCBwYXRjaCBbMS8yXSBhbmQgY2hhbmdlZCBhY2NvcmRpbmdseQo+IC0tLQo+ICBk cml2ZXJzL2RtYS9kbWEtYXhpLWRtYWMuYyB8IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5z ZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZG1hL2Rt YS1heGktZG1hYy5jIGIvZHJpdmVycy9kbWEvZG1hLWF4aS1kbWFjLmMKPiBpbmRleCAyNDE5ZmU1 MjRkYWEuLjE1YjI0NTNkMjY0NyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2RtYS9kbWEtYXhpLWRt YWMuYwo+ICsrKyBiL2RyaXZlcnMvZG1hL2RtYS1heGktZG1hYy5jCj4gQEAgLTY4Nyw3ICs2ODcs NyBAQCBzdGF0aWMgaW50IGF4aV9kbWFjX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCj4gIAlpZiAocmV0KQo+ICAJCWdvdG8gZXJyX3VucmVnaXN0ZXJfZGV2aWNlOwo+ICAKPiAt CXJldCA9IHJlcXVlc3RfaXJxKGRtYWMtPmlycSwgYXhpX2RtYWNfaW50ZXJydXB0X2hhbmRsZXIs IDAsCj4gKwlyZXQgPSByZXF1ZXN0X2lycShkbWFjLT5pcnEsIGF4aV9kbWFjX2ludGVycnVwdF9o YW5kbGVyLCBJUlFGX1NIQVJFRCwKPiAgCQlkZXZfbmFtZSgmcGRldi0+ZGV2KSwgZG1hYyk7Cj4g IAlpZiAocmV0KQo+ICAJCWdvdG8gZXJyX3VucmVnaXN0ZXJfb2Y7Cj4gLS0gCj4gMi4xNy4wCj4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751610AbeD0FGg (ORCPT ); Fri, 27 Apr 2018 01:06:36 -0400 Received: from mga12.intel.com ([192.55.52.136]:47403 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750863AbeD0FGe (ORCPT ); Fri, 27 Apr 2018 01:06:34 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,333,1520924400"; d="scan'208";a="36819403" Date: Fri, 27 Apr 2018 10:41:15 +0530 From: Vinod Koul To: Moritz Fischer Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, dan.j.williams@intel.com, lars@metafoo.de Subject: Re: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED Message-ID: <20180427051115.GX6014@localhost> References: <20180426174000.12008-1-mdf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180426174000.12008-1-mdf@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote: > Request IRQ with IRQF_SHARED flag. This works since the interrupt > handler already checks if there is an actual IRQ pending and returns > IRQ_NONE otherwise. hmmm what are we trying to fix here? Is your device on a shared line or not? > > Acked-by: Lars-Peter Clausen > Signed-off-by: Moritz Fischer > --- > Changes from v1: > - Added Lars' Acked-by > - Dropped patch [1/2] and changed accordingly > --- > drivers/dma/dma-axi-dmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c > index 2419fe524daa..15b2453d2647 100644 > --- a/drivers/dma/dma-axi-dmac.c > +++ b/drivers/dma/dma-axi-dmac.c > @@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev) > if (ret) > goto err_unregister_device; > > - ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0, > + ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, IRQF_SHARED, > dev_name(&pdev->dev), dmac); > if (ret) > goto err_unregister_of; > -- > 2.17.0 > -- ~Vinod