All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: hemant.agrawal@nxp.com, bluca@debian.org,
	Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH v2 3/3] build: ensure compatibility with future meson versions
Date: Fri, 27 Apr 2018 14:49:28 +0100	[thread overview]
Message-ID: <20180427134928.4716-4-bruce.richardson@intel.com> (raw)
In-Reply-To: <20180427134928.4716-1-bruce.richardson@intel.com>

Meson 0.46 fixed a bug where "extract_all_objects" would not recursively
extract objects not compiled from source for a target. To keep backward
compatibility, a "recursive" keyword-arg was added to make this optional.
The value is "false" by default for now, but will change to "true" in
future, so we hard-code it to "false" in our code to ensure future
compatiblity.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/meson.build b/lib/meson.build
index 73d6f25c7..ae445153b 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -96,7 +96,7 @@ foreach l:libraries
 
 			# then use pre-build objects to build shared lib
 			sources = []
-			objs += static_lib.extract_all_objects()
+			objs += static_lib.extract_all_objects(recursive: false)
 			version_map = '@0@/@1@/rte_@2@_version.map'.format(
 					meson.current_source_dir(), dir_name, name)
 			shared_lib = shared_library(libname,
-- 
2.14.3

  parent reply	other threads:[~2018-04-27 13:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 21:05 [PATCH 0/2] small fixes for meson build Bruce Richardson
2018-04-18 21:05 ` [PATCH 1/2] build: fix kernel compile on cross-build Bruce Richardson
2018-04-19 15:46   ` Hemant Agrawal
2018-04-19 16:12     ` Bruce Richardson
2018-04-19 17:06       ` Hemant Agrawal
2018-04-18 21:05 ` [PATCH 2/2] build: fix check for libbsd in meson Bruce Richardson
2018-04-27 13:49 ` [PATCH v2 0/3] small improvements to meson build Bruce Richardson
2018-04-27 13:49   ` [PATCH v2 1/3] build: fix kernel compile on cross-build Bruce Richardson
2018-04-27 13:49   ` [PATCH v2 2/3] build: fix check for libbsd in meson Bruce Richardson
2018-04-27 13:51     ` Bruce Richardson
2018-04-27 17:51       ` Vladimir Medvedkin
2018-04-27 13:49   ` Bruce Richardson [this message]
2018-04-27 14:37   ` [PATCH v2 0/3] small improvements to meson build Luca Boccassi
2018-05-08 20:22     ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180427134928.4716-4-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.