From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AB8JxZpBxsueCMRU6pv/PL7p8f9erye0OXHK7i2o3CSMEdOTfg4kXSj/ajRux8YY7H1QwXaBUumO ARC-Seal: i=1; a=rsa-sha256; t=1524837635; cv=none; d=google.com; s=arc-20160816; b=egkgAgj7wfOBxMZsRc9VQ4pqNci3Oc52qjEgJrrwO7YizNnlfA15mvLNy7tuewbNlf Hh68+J4lUa6XPsuAkvBLIboY0eUAFZsgAHLJLEvGF/EJeRXGzVqkQWPl4tAC0xpVLjKJ UYTkSh+5kjyJxNFuKT/uuyIog5vmpQ7iBlalkxV4bEE2dl+jkdIW/99KwuGHbURIaFVQ JUOT5GMWMX8S7ZCSlTeMdFeTVr5ZDK6jeDG0BBWjs9yxTy5OrFdcT00hTnPLbQ4Gcq// 5OtFLa6+Zyob80wzn4y7PTqxoIFhJMumFEpqWMKakeaeLj6YJ8MD34Zvtx6GDt2pwc4T oIYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:arc-authentication-results; bh=P/vS5V2iMnC7y8dme3Po9rwod8+4V6lxUTu597BppKE=; b=wF3h1N/rwMhfGZx60ST0eEQwK3YbNncIsAyUH4bjyk+KdI+nQ+I4rCZh0LIngy4Pck g82iU1jdrIl89QlNO+VfhtaGdAL0WiA4RBbgFxd7Mg79gRxO+7vTcLCIlOl0Nesb7zOy I+XJLdaDhfOIInDt18S3pElu6NgJRCFUwSRh12cCqh55V5nJU1RSKXXAn28gThskCK/I pNxREWZD8tbKlDfsZMKly5H1vFZ6NqECi5Leup5/X0FrT07Va9UvC418biPitNVxl/fq RW7rCc2aiJCnsTUS4+Tvnu3I+43RT1vX4AijrA4Uupedees3Vj+4g86u1Sm8tukUKd+E plyw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of srs0=4/0d=hq=linuxfoundation.org=gregkh@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=SRS0=4/0d=HQ=linuxfoundation.org=gregkh@kernel.org Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of srs0=4/0d=hq=linuxfoundation.org=gregkh@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=SRS0=4/0d=HQ=linuxfoundation.org=gregkh@kernel.org DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0570B21890 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=fail smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Gustavo A. R. Silva" , Colin Ian King , Pavel Shilovsky , Eryu Guan , Ronnie Sahlberg , Steve French Subject: [PATCH 4.4 01/50] cifs: do not allow creating sockets except with SMB1 posix exensions Date: Fri, 27 Apr 2018 15:58:03 +0200 Message-Id: <20180427135655.691568591@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180427135655.623669681@linuxfoundation.org> References: <20180427135655.623669681@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1598908003745859053?= X-GMAIL-MSGID: =?utf-8?q?1598908148633693706?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Steve French commit 1d0cffa674cfa7d185a302c8c6850fc50b893bed upstream. RHBZ: 1453123 Since at least the 3.10 kernel and likely a lot earlier we have not been able to create unix domain sockets in a cifs share when mounted using the SFU mount option (except when mounted with the cifs unix extensions to Samba e.g.) Trying to create a socket, for example using the af_unix command from xfstests will cause : BUG: unable to handle kernel NULL pointer dereference at 00000000 00000040 Since no one uses or depends on being able to create unix domains sockets on a cifs share the easiest fix to stop this vulnerability is to simply not allow creation of any other special files than char or block devices when sfu is used. Added update to Ronnie's patch to handle a tcon link leak, and to address a buf leak noticed by Gustavo and Colin. Acked-by: Gustavo A. R. Silva CC: Colin Ian King Reviewed-by: Pavel Shilovsky Reported-by: Eryu Guan Signed-off-by: Ronnie Sahlberg Signed-off-by: Steve French Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- fs/cifs/dir.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) --- a/fs/cifs/dir.c +++ b/fs/cifs/dir.c @@ -673,6 +673,9 @@ int cifs_mknod(struct inode *inode, stru goto mknod_out; } + if (!S_ISCHR(mode) && !S_ISBLK(mode)) + goto mknod_out; + if (!(cifs_sb->mnt_cifs_flags & CIFS_MOUNT_UNX_EMUL)) goto mknod_out; @@ -681,10 +684,8 @@ int cifs_mknod(struct inode *inode, stru buf = kmalloc(sizeof(FILE_ALL_INFO), GFP_KERNEL); if (buf == NULL) { - kfree(full_path); rc = -ENOMEM; - free_xid(xid); - return rc; + goto mknod_out; } if (backup_cred(cifs_sb)) @@ -731,7 +732,7 @@ int cifs_mknod(struct inode *inode, stru pdev->minor = cpu_to_le64(MINOR(device_number)); rc = tcon->ses->server->ops->sync_write(xid, &fid, &io_parms, &bytes_written, iov, 1); - } /* else if (S_ISFIFO) */ + } tcon->ses->server->ops->close(xid, tcon, &fid); d_drop(direntry);