From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Yangbo Lu <yangbo.lu@nxp.com>
Cc: devel@driverdev.osuosl.org,
Richard Cochran <richardcochran@gmail.com>,
linux-kernel@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [v2, 1/3] staging: fsl-dpaa2/eth: Add support for hardware timestamping
Date: Fri, 27 Apr 2018 16:58:48 +0200 [thread overview]
Message-ID: <20180427145848.GA12750@kroah.com> (raw)
In-Reply-To: <20180426102349.45222-1-yangbo.lu@nxp.com>
On Thu, Apr 26, 2018 at 06:23:47PM +0800, Yangbo Lu wrote:
> From: Ioana Radulescu <ruxandra.radulescu@nxp.com>
>
> Hardware timestamping is supported both on Rx and Tx paths.
> On Rx, timestamping is enabled for all frames. On Tx, we
> only instruct the hardware to timestamp the frames marked
> accordingly by the stack.
>
> Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> ---
> Changes for v2:
> - Addressed sparse issues.
> - Used tx_tstamp/rx_tstamp instead of ts_tx_en/ts_rx_en.
> - Used DPAA2_PTP_CLK_PERIOD_NS instead.
Why are you adding new features to this driver instead of working on
getting it out of the staging directory? What is remaining left to do
to get it moved out?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2018-04-27 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 10:23 [v2, 1/3] staging: fsl-dpaa2/eth: Add support for hardware timestamping Yangbo Lu
2018-04-26 10:23 ` [v2, 2/3] staging: fsl-dpaa2/eth: add the get_ts_info interface for ethtool Yangbo Lu
2018-04-26 10:23 ` [v2, 3/3] staging: fsl-dpaa2/rtc: support phc_index of ethtool_ts_info Yangbo Lu
2018-04-27 14:58 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427145848.GA12750@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.