From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933265AbeD1B1o (ORCPT ); Fri, 27 Apr 2018 21:27:44 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:49622 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932939AbeD1B1m (ORCPT ); Fri, 27 Apr 2018 21:27:42 -0400 Date: Fri, 27 Apr 2018 18:27:11 -0700 From: Martin KaFai Lau To: Dan Carpenter CC: Alexei Starovoitov , Daniel Borkmann , , , Subject: Re: [PATCH 2/2] bpf: btf: remove a couple conditions Message-ID: <20180428012646.r6idamuylruykb7h@kafai-mbp> References: <20180427140459.GB19583@mwanda> <20180427172023.6japncdd3nbqauzn@kafai-mbp> <20180427175544.vydqf4iufopcyv6d@kafai-mbp> <20180427193959.3nebosalgl3ch4mv@mwanda> <21126ae9-5178-5d09-679c-6bca57ad48e8@iogearbox.net> <20180427203135.mjkqoofbanozxzkd@mwanda> <20180427212648.zskc5bk2hunkwvsg@kafai-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20180427212648.zskc5bk2hunkwvsg@kafai-mbp.dhcp.thefacebook.com> User-Agent: NeoMutt/20171208 X-Originating-IP: [192.168.52.123] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-27_07:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 27, 2018 at 02:26:50PM -0700, Martin KaFai Lau wrote: > On Fri, Apr 27, 2018 at 11:31:36PM +0300, Dan Carpenter wrote: > > On Fri, Apr 27, 2018 at 10:21:17PM +0200, Daniel Borkmann wrote: > > > On 04/27/2018 09:39 PM, Dan Carpenter wrote: > > > > On Fri, Apr 27, 2018 at 10:55:46AM -0700, Martin KaFai Lau wrote: > > > >> On Fri, Apr 27, 2018 at 10:20:25AM -0700, Martin KaFai Lau wrote: > > > >>> On Fri, Apr 27, 2018 at 05:04:59PM +0300, Dan Carpenter wrote: > > > >>>> We know "err" is zero so we can remove these and pull the code in one > > > >>>> indent level. > > > >>>> > > > >>>> Signed-off-by: Dan Carpenter > > > >>> Thanks for the simplification! > > > >>> > > > >>> Acked-by: Martin KaFai Lau > > > >> btw, it should be for bpf-next. Please tag the subject with bpf-next when > > > >> you respin. Thanks! > > > > > > Dan, thanks a lot for your fixes! Please respin with addressing Martin's > > > feedback when you get a chance. > > > > > > > My understanding is that he'd prefer we just ignore the static checker > > warning since it's a false positive. > Right, I think patch 1 is not needed. I would prefer to use a comment > in those cases. > > > Should I instead initialize the > > size to zero or something just to silence it? After another thought, I think init size to zero is fine which is less intrusive. Thanks! Martin > > > > regards, > > dan carpenter > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin KaFai Lau Date: Sat, 28 Apr 2018 01:27:11 +0000 Subject: Re: [PATCH 2/2] bpf: btf: remove a couple conditions Message-Id: <20180428012646.r6idamuylruykb7h@kafai-mbp> List-Id: References: <20180427140459.GB19583@mwanda> <20180427172023.6japncdd3nbqauzn@kafai-mbp> <20180427175544.vydqf4iufopcyv6d@kafai-mbp> <20180427193959.3nebosalgl3ch4mv@mwanda> <21126ae9-5178-5d09-679c-6bca57ad48e8@iogearbox.net> <20180427203135.mjkqoofbanozxzkd@mwanda> <20180427212648.zskc5bk2hunkwvsg@kafai-mbp.dhcp.thefacebook.com> In-Reply-To: <20180427212648.zskc5bk2hunkwvsg@kafai-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Fri, Apr 27, 2018 at 02:26:50PM -0700, Martin KaFai Lau wrote: > On Fri, Apr 27, 2018 at 11:31:36PM +0300, Dan Carpenter wrote: > > On Fri, Apr 27, 2018 at 10:21:17PM +0200, Daniel Borkmann wrote: > > > On 04/27/2018 09:39 PM, Dan Carpenter wrote: > > > > On Fri, Apr 27, 2018 at 10:55:46AM -0700, Martin KaFai Lau wrote: > > > >> On Fri, Apr 27, 2018 at 10:20:25AM -0700, Martin KaFai Lau wrote: > > > >>> On Fri, Apr 27, 2018 at 05:04:59PM +0300, Dan Carpenter wrote: > > > >>>> We know "err" is zero so we can remove these and pull the code in one > > > >>>> indent level. > > > >>>> > > > >>>> Signed-off-by: Dan Carpenter > > > >>> Thanks for the simplification! > > > >>> > > > >>> Acked-by: Martin KaFai Lau > > > >> btw, it should be for bpf-next. Please tag the subject with bpf-next when > > > >> you respin. Thanks! > > > > > > Dan, thanks a lot for your fixes! Please respin with addressing Martin's > > > feedback when you get a chance. > > > > > > > My understanding is that he'd prefer we just ignore the static checker > > warning since it's a false positive. > Right, I think patch 1 is not needed. I would prefer to use a comment > in those cases. > > > Should I instead initialize the > > size to zero or something just to silence it? After another thought, I think init size to zero is fine which is less intrusive. Thanks! Martin > > > > regards, > > dan carpenter > >