From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [PATCH 1/2] net/mlx5: fix ethtool link setting call
	order
Date: Mon, 30 Apr 2018 09:08:58 +0200
Message-ID: <20180430070858.3yi3civcrhtyc73k@laranjeiro-vm.dev.6wind.com>
References: <20180429180308.85361-1-shahafs@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org
To: Shahaf Shuler <shahafs@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com
 [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id B6034DED
 for <dev@dpdk.org>; Mon, 30 Apr 2018 09:07:58 +0200 (CEST)
Received: by mail-wr0-f196.google.com with SMTP id u18-v6so7003379wrg.3
 for <dev@dpdk.org>; Mon, 30 Apr 2018 00:07:58 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20180429180308.85361-1-shahafs@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sun, Apr 29, 2018 at 09:03:07PM +0300, Shahaf Shuler wrote:
> According to ethtool_link_setting API recommendation ETHTOOL_GLINKSETTINGS
> should be called before ETHTOOL_GSET as the later one deprecated.
> 
> Fixes: f47ba80080ab ("net/mlx5: remove kernel version check")
> Cc: nelio.laranjeiro@6wind.com
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>

Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

> ---
>  drivers/net/mlx5/mlx5_ethdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
> index 746b94f734..588d4ba627 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -697,9 +697,9 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete)
>  	time_t start_time = time(NULL);
>  
>  	do {
> -		ret = mlx5_link_update_unlocked_gset(dev, &dev_link);
> +		ret = mlx5_link_update_unlocked_gs(dev, &dev_link);
>  		if (ret)
> -			ret = mlx5_link_update_unlocked_gs(dev, &dev_link);
> +			ret = mlx5_link_update_unlocked_gset(dev, &dev_link);
>  		if (ret == 0)
>  			break;
>  		/* Handle wait to complete situation. */
> -- 
> 2.12.0
> 

-- 
Nélio Laranjeiro
6WIND