From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752754AbeD3JEU (ORCPT ); Mon, 30 Apr 2018 05:04:20 -0400 Received: from mail.bootlin.com ([62.4.15.54]:43987 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024AbeD3JET (ORCPT ); Mon, 30 Apr 2018 05:04:19 -0400 Date: Mon, 30 Apr 2018 11:04:18 +0200 From: Boris Brezillon To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, Thierry Reding , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] drm/panel: Enable DSI transactions on the RPi panel. Message-ID: <20180430110418.5ba6baab@bbrezillon> In-Reply-To: <20171031193258.17373-2-eric@anholt.net> References: <20171031193258.17373-1-eric@anholt.net> <20171031193258.17373-2-eric@anholt.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 Oct 2017 12:32:58 -0700 Eric Anholt wrote: > It turns out that I had just mistaken what type of write the register > writes were supposed to be, using DCS instead of generic long writes. > > Switching to transactions instead of using the atmel as a bridge also > seems to resolve the sparkling pixels problem I've had. > > Signed-off-by: Eric Anholt > Fixes: 2f733d6194bd ("drm/panel: Add support for the Raspberry Pi 7" Touchscreen.") Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 14 +------------- > 1 file changed, 1 insertion(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c > index d964d454e4ae..2c9c9722734f 100644 > --- a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c > +++ b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c > @@ -238,12 +238,6 @@ static void rpi_touchscreen_i2c_write(struct rpi_touchscreen *ts, > > static int rpi_touchscreen_write(struct rpi_touchscreen *ts, u16 reg, u32 val) > { > -#if 0 > - /* The firmware uses LP DSI transactions like this to bring up > - * the hardware, which should be faster than using I2C to then > - * pass to the Toshiba. However, I was unable to get it to > - * work. > - */ > u8 msg[] = { > reg, > reg >> 8, > @@ -253,13 +247,7 @@ static int rpi_touchscreen_write(struct rpi_touchscreen *ts, u16 reg, u32 val) > val >> 24, > }; > > - mipi_dsi_dcs_write_buffer(ts->dsi, msg, sizeof(msg)); > -#else > - rpi_touchscreen_i2c_write(ts, REG_WR_ADDRH, reg >> 8); > - rpi_touchscreen_i2c_write(ts, REG_WR_ADDRL, reg); > - rpi_touchscreen_i2c_write(ts, REG_WRITEH, val >> 8); > - rpi_touchscreen_i2c_write(ts, REG_WRITEL, val); > -#endif > + mipi_dsi_generic_write(ts->dsi, msg, sizeof(msg)); > > return 0; > } -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 2/2] drm/panel: Enable DSI transactions on the RPi panel. Date: Mon, 30 Apr 2018 11:04:18 +0200 Message-ID: <20180430110418.5ba6baab@bbrezillon> References: <20171031193258.17373-1-eric@anholt.net> <20171031193258.17373-2-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 8292C6E143 for ; Mon, 30 Apr 2018 09:04:19 +0000 (UTC) In-Reply-To: <20171031193258.17373-2-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: Thierry Reding , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAzMSBPY3QgMjAxNyAxMjozMjo1OCAtMDcwMApFcmljIEFuaG9sdCA8ZXJpY0Bhbmhv bHQubmV0PiB3cm90ZToKCj4gSXQgdHVybnMgb3V0IHRoYXQgSSBoYWQganVzdCBtaXN0YWtlbiB3 aGF0IHR5cGUgb2Ygd3JpdGUgdGhlIHJlZ2lzdGVyCj4gd3JpdGVzIHdlcmUgc3VwcG9zZWQgdG8g YmUsIHVzaW5nIERDUyBpbnN0ZWFkIG9mIGdlbmVyaWMgbG9uZyB3cml0ZXMuCj4gCj4gU3dpdGNo aW5nIHRvIHRyYW5zYWN0aW9ucyBpbnN0ZWFkIG9mIHVzaW5nIHRoZSBhdG1lbCBhcyBhIGJyaWRn ZSBhbHNvCj4gc2VlbXMgdG8gcmVzb2x2ZSB0aGUgc3BhcmtsaW5nIHBpeGVscyBwcm9ibGVtIEkn dmUgaGFkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEVyaWMgQW5ob2x0IDxlcmljQGFuaG9sdC5uZXQ+ Cj4gRml4ZXM6IDJmNzMzZDYxOTRiZCAoImRybS9wYW5lbDogQWRkIHN1cHBvcnQgZm9yIHRoZSBS YXNwYmVycnkgUGkgNyIgVG91Y2hzY3JlZW4uIikKClJldmlld2VkLWJ5OiBCb3JpcyBCcmV6aWxs b24gPGJvcmlzLmJyZXppbGxvbkBib290bGluLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9wYW5lbC9wYW5lbC1yYXNwYmVycnlwaS10b3VjaHNjcmVlbi5jIHwgMTQgKy0tLS0tLS0tLS0t LS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxMyBkZWxldGlvbnMoLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLXJhc3BiZXJyeXBpLXRv dWNoc2NyZWVuLmMgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtcmFzcGJlcnJ5cGktdG91 Y2hzY3JlZW4uYwo+IGluZGV4IGQ5NjRkNDU0ZTRhZS4uMmM5Yzk3MjI3MzRmIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1yYXNwYmVycnlwaS10b3VjaHNjcmVlbi5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLXJhc3BiZXJyeXBpLXRvdWNoc2Ny ZWVuLmMKPiBAQCAtMjM4LDEyICsyMzgsNiBAQCBzdGF0aWMgdm9pZCBycGlfdG91Y2hzY3JlZW5f aTJjX3dyaXRlKHN0cnVjdCBycGlfdG91Y2hzY3JlZW4gKnRzLAo+ICAKPiAgc3RhdGljIGludCBy cGlfdG91Y2hzY3JlZW5fd3JpdGUoc3RydWN0IHJwaV90b3VjaHNjcmVlbiAqdHMsIHUxNiByZWcs IHUzMiB2YWwpCj4gIHsKPiAtI2lmIDAKPiAtCS8qIFRoZSBmaXJtd2FyZSB1c2VzIExQIERTSSB0 cmFuc2FjdGlvbnMgbGlrZSB0aGlzIHRvIGJyaW5nIHVwCj4gLQkgKiB0aGUgaGFyZHdhcmUsIHdo aWNoIHNob3VsZCBiZSBmYXN0ZXIgdGhhbiB1c2luZyBJMkMgdG8gdGhlbgo+IC0JICogcGFzcyB0 byB0aGUgVG9zaGliYS4gIEhvd2V2ZXIsIEkgd2FzIHVuYWJsZSB0byBnZXQgaXQgdG8KPiAtCSAq IHdvcmsuCj4gLQkgKi8KPiAgCXU4IG1zZ1tdID0gewo+ICAJCXJlZywKPiAgCQlyZWcgPj4gOCwK PiBAQCAtMjUzLDEzICsyNDcsNyBAQCBzdGF0aWMgaW50IHJwaV90b3VjaHNjcmVlbl93cml0ZShz dHJ1Y3QgcnBpX3RvdWNoc2NyZWVuICp0cywgdTE2IHJlZywgdTMyIHZhbCkKPiAgCQl2YWwgPj4g MjQsCj4gIAl9Owo+ICAKPiAtCW1pcGlfZHNpX2Rjc193cml0ZV9idWZmZXIodHMtPmRzaSwgbXNn LCBzaXplb2YobXNnKSk7Cj4gLSNlbHNlCj4gLQlycGlfdG91Y2hzY3JlZW5faTJjX3dyaXRlKHRz LCBSRUdfV1JfQUREUkgsIHJlZyA+PiA4KTsKPiAtCXJwaV90b3VjaHNjcmVlbl9pMmNfd3JpdGUo dHMsIFJFR19XUl9BRERSTCwgcmVnKTsKPiAtCXJwaV90b3VjaHNjcmVlbl9pMmNfd3JpdGUodHMs IFJFR19XUklURUgsIHZhbCA+PiA4KTsKPiAtCXJwaV90b3VjaHNjcmVlbl9pMmNfd3JpdGUodHMs IFJFR19XUklURUwsIHZhbCk7Cj4gLSNlbmRpZgo+ICsJbWlwaV9kc2lfZ2VuZXJpY193cml0ZSh0 cy0+ZHNpLCBtc2csIHNpemVvZihtc2cpKTsKPiAgCj4gIAlyZXR1cm4gMDsKPiAgfQoKCgotLSAK Qm9yaXMgQnJlemlsbG9uLCBCb290bGluIChmb3JtZXJseSBGcmVlIEVsZWN0cm9ucykKRW1iZWRk ZWQgTGludXggYW5kIEtlcm5lbCBlbmdpbmVlcmluZwpodHRwczovL2Jvb3RsaW4uY29tCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=