From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AB8JxZpz5UCCYSeccGx2ZOPGliHhjguaDpjKTGrBIlvxz0A8FZdEfeRxIr4pHFjI0ob/CBVlysTW ARC-Seal: i=1; a=rsa-sha256; t=1525094588; cv=none; d=google.com; s=arc-20160816; b=rq3MfWkRsORfcC+sx3lFeUwI8J+OdzTJqOJmwu22K2hu7e+r4dKqsD2yVlXpH19fBN SkoGMlUmhHFNrCAVDPJ4fEFudjNOGvP4hlre4NcD9AdcCcrT3IWaIUkq88MtBS3QfSMi cw4wYapOftPMAPGylolhpln0N1OjtNrlKH5iJU0Vb+r4KsSYCdPaAqFNG6gdbnLM9Dli qsD3G+FRnSDlpBIRglF4iWsCLa2jJ26etCbrBmLY/Bu5rmKVm/4K8DVoVw7gMLuWsO+J tp+Wd3SncNZ+WOiSdnVNjQBcoQBrrfVmjKQKkdY8ME2x2tO9KOZmi6UWPv32L3ufpFic Tlyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:arc-authentication-results; bh=MFUGT1mFqr8OhIREzZRqyHkWZbwUThJXWTDdJmmsAzw=; b=l5nqultRVnrg5GK97xXlyIhON8+drkzquz6c0FHly1Wz6HUlyMJSPknKsRyO9kOhku BrwlEg/ciotA4KU0iW8BaKzwoMvBdJZ8HFqshK/M67fToK7Q3+cKrdTJfjKAaIkgaa5J GgpaTD7gONwDTtlouCbvKXR9J4yR+cb6MGZNdr5jX5mBAnQDgzmUaA++gSo1Cx4/TGy7 NYPY2jhofE/cAgri2tevT5viXeTiuWgqlNtH9wFIq9lJXxlyjVdfWeZMKEzuwCj8oCw6 jFyFQAamXqOlFgxH6e0YyJnR5ZnIx0B87LqNMy36uX7QmtrgLs35FdvOVy/7BhnUKNLT HSYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of gustavo@embeddedor.com designates 192.185.65.13 as permitted sender) smtp.mailfrom=gustavo@embeddedor.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of gustavo@embeddedor.com designates 192.185.65.13 as permitted sender) smtp.mailfrom=gustavo@embeddedor.com X-Authority-Reason: nr=8 Date: Mon, 30 Apr 2018 08:23:06 -0500 From: "Gustavo A. R. Silva" To: Adam Thomson , Heikki Krogerus , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] typec: tcpm: Fix incorrect 'and' operator Message-ID: <20180430132305.GA20092@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - linuxfoundation.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.172.56.86 X-Source-L: No X-Exim-ID: 1fD8ln-002KmA-I5 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [187.172.56.86]:50344 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 3 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1599177583315006788?= X-GMAIL-MSGID: =?utf-8?q?1599177583315006788?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Currently, logical and is being used instead of *bitwise* and. Fix this by using a proper bitwise and operator. Addresses-Coverity-ID: 1468455 ("Logical vs. bitwise operator") Fixes: 64f7c494a3c0 ("typec: tcpm: Add support for sink PPS related messages") Signed-off-by: Gustavo A. R. Silva Acked-by: Adam Thomson --- drivers/usb/typec/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c index 1ee259b..7ee417a 100644 --- a/drivers/usb/typec/tcpm.c +++ b/drivers/usb/typec/tcpm.c @@ -1772,7 +1772,7 @@ static void tcpm_pd_ext_msg_request(struct tcpm_port *port, enum pd_ext_msg_type type = pd_header_type_le(msg->header); unsigned int data_size = pd_ext_header_data_size_le(msg->ext_msg.header); - if (!(msg->ext_msg.header && PD_EXT_HDR_CHUNKED)) { + if (!(msg->ext_msg.header & PD_EXT_HDR_CHUNKED)) { tcpm_log(port, "Unchunked extended messages unsupported"); return; } -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Date: Mon, 30 Apr 2018 13:23:06 +0000 Subject: [PATCH] typec: tcpm: Fix incorrect 'and' operator Message-Id: <20180430132305.GA20092@embeddedor.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Adam Thomson , Heikki Krogerus , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, "Gustavo A. R. Silva" Currently, logical and is being used instead of *bitwise* and. Fix this by using a proper bitwise and operator. Addresses-Coverity-ID: 1468455 ("Logical vs. bitwise operator") Fixes: 64f7c494a3c0 ("typec: tcpm: Add support for sink PPS related messages") Signed-off-by: Gustavo A. R. Silva --- drivers/usb/typec/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c index 1ee259b..7ee417a 100644 --- a/drivers/usb/typec/tcpm.c +++ b/drivers/usb/typec/tcpm.c @@ -1772,7 +1772,7 @@ static void tcpm_pd_ext_msg_request(struct tcpm_port *port, enum pd_ext_msg_type type = pd_header_type_le(msg->header); unsigned int data_size = pd_ext_header_data_size_le(msg->ext_msg.header); - if (!(msg->ext_msg.header && PD_EXT_HDR_CHUNKED)) { + if (!(msg->ext_msg.header & PD_EXT_HDR_CHUNKED)) { tcpm_log(port, "Unchunked extended messages unsupported"); return; } -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: typec: tcpm: Fix incorrect 'and' operator From: "Gustavo A. R. Silva" Message-Id: <20180430132305.GA20092@embeddedor.com> Date: Mon, 30 Apr 2018 08:23:06 -0500 To: Adam Thomson , Heikki Krogerus , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, "Gustavo A. R. Silva" List-ID: Q3VycmVudGx5LCBsb2dpY2FsIGFuZCBpcyBiZWluZyB1c2VkIGluc3RlYWQgb2YgKmJpdHdpc2Uq IGFuZC4KCkZpeCB0aGlzIGJ5IHVzaW5nIGEgcHJvcGVyIGJpdHdpc2UgYW5kIG9wZXJhdG9yLgoK QWRkcmVzc2VzLUNvdmVyaXR5LUlEOiAxNDY4NDU1ICgiTG9naWNhbCB2cy4gYml0d2lzZSBvcGVy YXRvciIpCkZpeGVzOiA2NGY3YzQ5NGEzYzAgKCJ0eXBlYzogdGNwbTogQWRkIHN1cHBvcnQgZm9y IHNpbmsgUFBTIHJlbGF0ZWQKbWVzc2FnZXMiKQpTaWduZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIu IFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPgotLS0KIGRyaXZlcnMvdXNiL3R5cGVjL3Rj cG0uYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigt KQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL3R5cGVjL3RjcG0uYyBiL2RyaXZlcnMvdXNiL3R5 cGVjL3RjcG0uYwppbmRleCAxZWUyNTliLi43ZWU0MTdhIDEwMDY0NAotLS0gYS9kcml2ZXJzL3Vz Yi90eXBlYy90Y3BtLmMKKysrIGIvZHJpdmVycy91c2IvdHlwZWMvdGNwbS5jCkBAIC0xNzcyLDcg KzE3NzIsNyBAQCBzdGF0aWMgdm9pZCB0Y3BtX3BkX2V4dF9tc2dfcmVxdWVzdChzdHJ1Y3QgdGNw bV9wb3J0ICpwb3J0LAogCWVudW0gcGRfZXh0X21zZ190eXBlIHR5cGUgPSBwZF9oZWFkZXJfdHlw ZV9sZShtc2ctPmhlYWRlcik7CiAJdW5zaWduZWQgaW50IGRhdGFfc2l6ZSA9IHBkX2V4dF9oZWFk ZXJfZGF0YV9zaXplX2xlKG1zZy0+ZXh0X21zZy5oZWFkZXIpOwogCi0JaWYgKCEobXNnLT5leHRf bXNnLmhlYWRlciAmJiBQRF9FWFRfSERSX0NIVU5LRUQpKSB7CisJaWYgKCEobXNnLT5leHRfbXNn LmhlYWRlciAmIFBEX0VYVF9IRFJfQ0hVTktFRCkpIHsKIAkJdGNwbV9sb2cocG9ydCwgIlVuY2h1 bmtlZCBleHRlbmRlZCBtZXNzYWdlcyB1bnN1cHBvcnRlZCIpOwogCQlyZXR1cm47CiAJfQo=