From: Steven Rostedt <rostedt@goodmis.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Pavel Tatashin <pasha.tatashin@oracle.com>,
steven.sistare@oracle.com, daniel.m.jordan@oracle.com,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
mhocko@suse.com, linux-mm@kvack.org, mgorman@techsingularity.net,
mingo@kernel.org, peterz@infradead.org, fengguang.wu@intel.com,
dennisszhou@gmail.com
Subject: Re: [PATCH v2] mm: access to uninitialized struct page
Date: Mon, 30 Apr 2018 19:58:58 -0400 [thread overview]
Message-ID: <20180430195858.5242373c@gandalf.local.home> (raw)
In-Reply-To: <20180430162658.598dd5dcdd0c67e36953281c@linux-foundation.org>
On Mon, 30 Apr 2018 16:26:58 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Thu, 26 Apr 2018 16:26:19 -0400 Pavel Tatashin <pasha.tatashin@oracle.com> wrote:
>
> > The following two bugs were reported by Fengguang Wu:
> >
> > kernel reboot-without-warning in early-boot stage, last printk:
> > early console in setup code
> >
> > http://lkml.kernel.org/r/20180418135300.inazvpxjxowogyge@wfg-t540p.sh.intel.com
> >
> > ...
> >
> > --- a/init/main.c
> > +++ b/init/main.c
> > @@ -585,8 +585,8 @@ asmlinkage __visible void __init start_kernel(void)
> > setup_log_buf(0);
> > vfs_caches_init_early();
> > sort_main_extable();
> > - trap_init();
> > mm_init();
> > + trap_init();
> >
> > ftrace_init();
>
> Gulp. Let's hope that nothing in mm_init() requires that trap_init()
> has been run. What happens if something goes wrong during mm_init()
> and the architecture attempts to raise a software exception, hits a bus
> error, div-by-zero, etc, etc? Might there be hard-to-discover
> dependencies in such a case?
I mentioned the same thing.
-- Steve
next prev parent reply other threads:[~2018-04-30 23:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 20:26 [PATCH v2] mm: access to uninitialized struct page Pavel Tatashin
2018-04-30 23:26 ` Andrew Morton
2018-04-30 23:58 ` Steven Rostedt [this message]
2018-05-01 0:01 ` Andrew Morton
2018-05-08 14:44 ` Pavel Tatashin
2018-05-04 8:27 ` [v2] " Andrei Vagin
2018-05-04 12:47 ` Pavel Tatashin
2018-05-04 14:50 ` Steven Rostedt
2018-05-04 16:01 ` Andrei Vagin
2018-05-04 16:03 ` Pavel Tatashin
2018-05-04 17:49 ` Andy Shevchenko
2018-05-05 1:04 ` Fengguang Wu
2018-05-05 1:04 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180430195858.5242373c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=daniel.m.jordan@oracle.com \
--cc=dennisszhou@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=pasha.tatashin@oracle.com \
--cc=peterz@infradead.org \
--cc=steven.sistare@oracle.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.