From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754974AbeD3Uvt (ORCPT ); Mon, 30 Apr 2018 16:51:49 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:42821 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751241AbeD3Uvr (ORCPT ); Mon, 30 Apr 2018 16:51:47 -0400 X-Google-Smtp-Source: AB8JxZotGFK+jCxy/66chh987yji+TPPdC3fdtAEL6V/H4Ho596dT0RnS0UntprbA1vx6dqcwq/fqw== Date: Mon, 30 Apr 2018 13:51:45 -0700 From: Matthias Kaehlcke To: Chris Wilson Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Guenter Roeck , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Disable some extra clang warnings Message-ID: <20180430205145.GC133494@google.com> References: <20180319191451.83910-1-mka@chromium.org> <20180430193119.GB133494@google.com> <152511850981.10429.1077865835761338509@mail.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <152511850981.10429.1077865835761338509@mail.alporthouse.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 30, 2018 at 09:01:49PM +0100, Chris Wilson wrote: > Quoting Matthias Kaehlcke (2018-04-30 20:31:19) > > On Mon, Mar 19, 2018 at 12:14:51PM -0700, Matthias Kaehlcke wrote: > > > Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set > > > warnings to full") enabled extra warnings for i915 to spot possible > > > bugs in new code, and then disabled a subset of these warnings to keep > > > the current code building without warnings (with gcc). Enabling the > > > extra warnings also enabled some additional clang-only warnings, as a > > > result building i915 with clang currently is extremely noisy. For now > > > also disable the clang warnings sign-compare, sometimes-uninitialized, > > > unneeded-internal-declaration and initializer-overrides. If desired > > > they can be re-enabled after the code has been fixed. > > > > > > Fixes: 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set > > > warnings to full") > > Do we need to backport this for a non-default build with a non-default > compiler? If it affected a LTS build I'd say yes, but since that isn't the case I think it's not necessary. > > > Signed-off-by: Matthias Kaehlcke > > > --- > > > Changes in v2: > > > - rebased on drm-tip > > > - added comment indicating that disabled warnings are clang warnings > > > > > > drivers/gpu/drm/i915/Makefile | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > > > index 4eee91a3a236..9717c037b582 100644 > > > --- a/drivers/gpu/drm/i915/Makefile > > > +++ b/drivers/gpu/drm/i915/Makefile > > > @@ -18,6 +18,11 @@ subdir-ccflags-y += $(call cc-disable-warning, type-limits) > > > subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers) > > > subdir-ccflags-y += $(call cc-disable-warning, implicit-fallthrough) > > > subdir-ccflags-y += $(call cc-disable-warning, unused-but-set-variable) > > > +# clang warnings > > > +subdir-ccflags-y += $(call cc-disable-warning, sign-compare) > > Too much mixup in the code to be fixed overnight indeed. > > > > +subdir-ccflags-y += $(call cc-disable-warning, sometimes-uninitialized) > > Annoyingly it appears that clang has more false positives. > > > > +subdir-ccflags-y += $(call cc-disable-warning, unneeded-internal-declaration) > > Example? I don't recall this one, so don't know if we should just not > fix it rather than suppress. I've used ignored-attributes, perhaps that > was for the same cause. drivers/gpu/drm/i915/intel_guc_submission.c:183:13: warning: function 'has_doorbell' is not needed and will not be emitted [-Wunneeded-internal-declaration] static bool has_doorbell(struct intel_guc_client *client) The function is only called within a GEM_BUG_ON macro, which does not evaluate the expression unless CONFIG_DRM_I915_DEBUG_GEM is set. Instead of disabling the warning it would probably be better to mark has_doorbell as __maybe_unused. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Kaehlcke Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Disable some extra clang warnings Date: Mon, 30 Apr 2018 13:51:45 -0700 Message-ID: <20180430205145.GC133494@google.com> References: <20180319191451.83910-1-mka@chromium.org> <20180430193119.GB133494@google.com> <152511850981.10429.1077865835761338509@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pg0-x243.google.com (mail-pg0-x243.google.com [IPv6:2607:f8b0:400e:c05::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6658B892B5 for ; Mon, 30 Apr 2018 20:51:47 +0000 (UTC) Received: by mail-pg0-x243.google.com with SMTP id g20-v6so393510pgv.1 for ; Mon, 30 Apr 2018 13:51:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <152511850981.10429.1077865835761338509@mail.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson Cc: David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi , Guenter Roeck List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBBcHIgMzAsIDIwMTggYXQgMDk6MDE6NDlQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgTWF0dGhpYXMgS2FlaGxja2UgKDIwMTgtMDQtMzAgMjA6MzE6MTkpCj4g PiBPbiBNb24sIE1hciAxOSwgMjAxOCBhdCAxMjoxNDo1MVBNIC0wNzAwLCBNYXR0aGlhcyBLYWVo bGNrZSB3cm90ZToKPiA+ID4gQ29tbWl0IDM5YmY0ZGU4OWZmNyAoImRybS9pOTE1OiBBZGQgLVdh bGwgLVdleHRyYSB0byBvdXIgYnVpbGQsIHNldAo+ID4gPiB3YXJuaW5ncyB0byBmdWxsIikgZW5h YmxlZCBleHRyYSB3YXJuaW5ncyBmb3IgaTkxNSB0byBzcG90IHBvc3NpYmxlCj4gPiA+IGJ1Z3Mg aW4gbmV3IGNvZGUsIGFuZCB0aGVuIGRpc2FibGVkIGEgc3Vic2V0IG9mIHRoZXNlIHdhcm5pbmdz IHRvIGtlZXAKPiA+ID4gdGhlIGN1cnJlbnQgY29kZSBidWlsZGluZyB3aXRob3V0IHdhcm5pbmdz ICh3aXRoIGdjYykuIEVuYWJsaW5nIHRoZQo+ID4gPiBleHRyYSB3YXJuaW5ncyBhbHNvIGVuYWJs ZWQgc29tZSBhZGRpdGlvbmFsIGNsYW5nLW9ubHkgd2FybmluZ3MsIGFzIGEKPiA+ID4gcmVzdWx0 IGJ1aWxkaW5nIGk5MTUgd2l0aCBjbGFuZyBjdXJyZW50bHkgaXMgZXh0cmVtZWx5IG5vaXN5LiBG b3Igbm93Cj4gPiA+IGFsc28gZGlzYWJsZSB0aGUgY2xhbmcgd2FybmluZ3Mgc2lnbi1jb21wYXJl LCBzb21ldGltZXMtdW5pbml0aWFsaXplZCwKPiA+ID4gdW5uZWVkZWQtaW50ZXJuYWwtZGVjbGFy YXRpb24gYW5kIGluaXRpYWxpemVyLW92ZXJyaWRlcy4gSWYgZGVzaXJlZAo+ID4gPiB0aGV5IGNh biBiZSByZS1lbmFibGVkIGFmdGVyIHRoZSBjb2RlIGhhcyBiZWVuIGZpeGVkLgo+ID4gPiAKPiA+ ID4gRml4ZXM6IDM5YmY0ZGU4OWZmNyAoImRybS9pOTE1OiBBZGQgLVdhbGwgLVdleHRyYSB0byBv dXIgYnVpbGQsIHNldAo+ID4gPiB3YXJuaW5ncyB0byBmdWxsIikKPiAKPiBEbyB3ZSBuZWVkIHRv IGJhY2twb3J0IHRoaXMgZm9yIGEgbm9uLWRlZmF1bHQgYnVpbGQgd2l0aCBhIG5vbi1kZWZhdWx0 Cj4gY29tcGlsZXI/CgpJZiBpdCBhZmZlY3RlZCBhIExUUyBidWlsZCBJJ2Qgc2F5IHllcywgYnV0 IHNpbmNlIHRoYXQgaXNuJ3QgdGhlIGNhc2UKSSB0aGluayBpdCdzIG5vdCBuZWNlc3NhcnkuCgo+ ID4gPiBTaWduZWQtb2ZmLWJ5OiBNYXR0aGlhcyBLYWVobGNrZSA8bWthQGNocm9taXVtLm9yZz4K PiA+ID4gLS0tCj4gPiA+IENoYW5nZXMgaW4gdjI6Cj4gPiA+IC0gcmViYXNlZCBvbiBkcm0tdGlw Cj4gPiA+IC0gYWRkZWQgY29tbWVudCBpbmRpY2F0aW5nIHRoYXQgZGlzYWJsZWQgd2FybmluZ3Mg YXJlIGNsYW5nIHdhcm5pbmdzCj4gPiA+IAo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvTWFr ZWZpbGUgfCA1ICsrKysrCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCj4g PiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvTWFrZWZpbGUgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9NYWtlZmlsZQo+ID4gPiBpbmRleCA0ZWVlOTFhM2EyMzYuLjk3 MTdjMDM3YjU4MiAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvTWFrZWZp bGUKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvTWFrZWZpbGUKPiA+ID4gQEAgLTE4 LDYgKzE4LDExIEBAIHN1YmRpci1jY2ZsYWdzLXkgKz0gJChjYWxsIGNjLWRpc2FibGUtd2Fybmlu ZywgdHlwZS1saW1pdHMpCj4gPiA+ICBzdWJkaXItY2NmbGFncy15ICs9ICQoY2FsbCBjYy1kaXNh YmxlLXdhcm5pbmcsIG1pc3NpbmctZmllbGQtaW5pdGlhbGl6ZXJzKQo+ID4gPiAgc3ViZGlyLWNj ZmxhZ3MteSArPSAkKGNhbGwgY2MtZGlzYWJsZS13YXJuaW5nLCBpbXBsaWNpdC1mYWxsdGhyb3Vn aCkKPiA+ID4gIHN1YmRpci1jY2ZsYWdzLXkgKz0gJChjYWxsIGNjLWRpc2FibGUtd2FybmluZywg dW51c2VkLWJ1dC1zZXQtdmFyaWFibGUpCj4gPiA+ICsjIGNsYW5nIHdhcm5pbmdzCj4gPiA+ICtz dWJkaXItY2NmbGFncy15ICs9ICQoY2FsbCBjYy1kaXNhYmxlLXdhcm5pbmcsIHNpZ24tY29tcGFy ZSkKPiAKPiBUb28gbXVjaCBtaXh1cCBpbiB0aGUgY29kZSB0byBiZSBmaXhlZCBvdmVybmlnaHQg aW5kZWVkLgo+IAo+ID4gPiArc3ViZGlyLWNjZmxhZ3MteSArPSAkKGNhbGwgY2MtZGlzYWJsZS13 YXJuaW5nLCBzb21ldGltZXMtdW5pbml0aWFsaXplZCkKPiAKPiBBbm5veWluZ2x5IGl0IGFwcGVh cnMgdGhhdCBjbGFuZyBoYXMgbW9yZSBmYWxzZSBwb3NpdGl2ZXMuCj4gCj4gPiA+ICtzdWJkaXIt Y2NmbGFncy15ICs9ICQoY2FsbCBjYy1kaXNhYmxlLXdhcm5pbmcsIHVubmVlZGVkLWludGVybmFs LWRlY2xhcmF0aW9uKQo+IAo+IEV4YW1wbGU/IEkgZG9uJ3QgcmVjYWxsIHRoaXMgb25lLCBzbyBk b24ndCBrbm93IGlmIHdlIHNob3VsZCBqdXN0IG5vdAo+IGZpeCBpdCByYXRoZXIgdGhhbiBzdXBw cmVzcy4gSSd2ZSB1c2VkIGlnbm9yZWQtYXR0cmlidXRlcywgcGVyaGFwcyB0aGF0Cj4gd2FzIGZv ciB0aGUgc2FtZSBjYXVzZS4KCmRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19zdWJtaXNz aW9uLmM6MTgzOjEzOiB3YXJuaW5nOiBmdW5jdGlvbgogICdoYXNfZG9vcmJlbGwnIGlzIG5vdCBu ZWVkZWQgYW5kIHdpbGwgbm90IGJlIGVtaXR0ZWQKICBbLVd1bm5lZWRlZC1pbnRlcm5hbC1kZWNs YXJhdGlvbl0Kc3RhdGljIGJvb2wgaGFzX2Rvb3JiZWxsKHN0cnVjdCBpbnRlbF9ndWNfY2xpZW50 ICpjbGllbnQpCgpUaGUgZnVuY3Rpb24gaXMgb25seSBjYWxsZWQgd2l0aGluIGEgR0VNX0JVR19P TiBtYWNybywgd2hpY2ggZG9lcyBub3QKZXZhbHVhdGUgdGhlIGV4cHJlc3Npb24gdW5sZXNzIENP TkZJR19EUk1fSTkxNV9ERUJVR19HRU0gaXMgc2V0LgoKSW5zdGVhZCBvZiBkaXNhYmxpbmcgdGhl IHdhcm5pbmcgaXQgd291bGQgcHJvYmFibHkgYmUgYmV0dGVyIHRvIG1hcmsKaGFzX2Rvb3JiZWxs IGFzIF9fbWF5YmVfdW51c2VkLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK