From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Jeff Cody <jcody@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH 0/2] block/mirror: Make cancel always cancel pre-READY
Date: Wed, 2 May 2018 00:05:07 +0200 [thread overview]
Message-ID: <20180501220509.14152-1-mreitz@redhat.com> (raw)
Currently, you cannot cancel a mirror job without the @force flag set.
This is intentional once source and target are in sync, but probably not
so much before that happens. The main reason for me thinking this is
because it is an undocumented change in 2.12.0 in respect to 2.11.
(b76e4458b1eb3c32e9824fe6aa51f67d2b251748 only notes a behavior change
after READY, but not before.)
This series depends on Stefan’s patch “block/mirror: honor ratelimit
again” (which is in Jeff’s queue).
Based-on: <20180424123527.19168-1-stefanha@redhat.com>
Max Reitz (2):
block/mirror: Make cancel always cancel pre-READY
iotests: Add test for cancelling a mirror job
block/mirror.c | 4 +-
tests/qemu-iotests/218 | 138 +++++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/218.out | 30 ++++++++++
tests/qemu-iotests/group | 1 +
4 files changed, 172 insertions(+), 1 deletion(-)
create mode 100755 tests/qemu-iotests/218
create mode 100644 tests/qemu-iotests/218.out
--
2.14.3
next reply other threads:[~2018-05-01 22:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 22:05 Max Reitz [this message]
2018-05-01 22:05 ` [Qemu-devel] [PATCH 1/2] block/mirror: Make cancel always cancel pre-READY Max Reitz
2018-05-01 23:31 ` Eric Blake
2018-05-02 12:35 ` Max Reitz
2018-05-01 22:05 ` [Qemu-devel] [PATCH 2/2] iotests: Add test for cancelling a mirror job Max Reitz
2018-05-02 14:31 ` Jeff Cody
2018-05-01 23:29 ` [Qemu-devel] [PATCH 0/2] block/mirror: Make cancel always cancel pre-READY Eric Blake
2018-05-02 14:32 ` Jeff Cody
2018-05-02 17:36 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501220509.14152-1-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.