* [PATCH] Revert "vhost: make msg padding explicit"
@ 2018-05-02 14:19 Michael S. Tsirkin
2018-05-02 14:27 ` David Miller
2018-05-02 14:27 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2018-05-02 14:19 UTC (permalink / raw)
To: linux-kernel; +Cc: Jason Wang, kvm, virtualization, netdev
This reverts commit 93c0d549c4c5a7382ad70de6b86610b7aae57406.
Unfortunately the padding will break 32 bit userspace.
Ouch. Need to add some compat code, revert for now.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/uapi/linux/vhost.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h
index 5a8ad06..c51f8e5 100644
--- a/include/uapi/linux/vhost.h
+++ b/include/uapi/linux/vhost.h
@@ -68,7 +68,6 @@ struct vhost_iotlb_msg {
struct vhost_msg {
int type;
- int padding0;
union {
struct vhost_iotlb_msg iotlb;
__u8 padding[64];
--
MST
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Revert "vhost: make msg padding explicit"
2018-05-02 14:19 [PATCH] Revert "vhost: make msg padding explicit" Michael S. Tsirkin
2018-05-02 14:27 ` David Miller
@ 2018-05-02 14:27 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2018-05-02 14:27 UTC (permalink / raw)
To: mst; +Cc: linux-kernel, jasowang, kvm, virtualization, netdev
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Wed, 2 May 2018 17:19:05 +0300
> This reverts commit 93c0d549c4c5a7382ad70de6b86610b7aae57406.
>
> Unfortunately the padding will break 32 bit userspace.
> Ouch. Need to add some compat code, revert for now.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Applied, thanks Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Revert "vhost: make msg padding explicit"
2018-05-02 14:19 [PATCH] Revert "vhost: make msg padding explicit" Michael S. Tsirkin
@ 2018-05-02 14:27 ` David Miller
2018-05-02 14:27 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2018-05-02 14:27 UTC (permalink / raw)
To: mst; +Cc: netdev, linux-kernel, kvm, virtualization
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Wed, 2 May 2018 17:19:05 +0300
> This reverts commit 93c0d549c4c5a7382ad70de6b86610b7aae57406.
>
> Unfortunately the padding will break 32 bit userspace.
> Ouch. Need to add some compat code, revert for now.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Applied, thanks Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Revert "vhost: make msg padding explicit"
@ 2018-05-02 14:19 Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2018-05-02 14:19 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev, kvm, virtualization
This reverts commit 93c0d549c4c5a7382ad70de6b86610b7aae57406.
Unfortunately the padding will break 32 bit userspace.
Ouch. Need to add some compat code, revert for now.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/uapi/linux/vhost.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h
index 5a8ad06..c51f8e5 100644
--- a/include/uapi/linux/vhost.h
+++ b/include/uapi/linux/vhost.h
@@ -68,7 +68,6 @@ struct vhost_iotlb_msg {
struct vhost_msg {
int type;
- int padding0;
union {
struct vhost_iotlb_msg iotlb;
__u8 padding[64];
--
MST
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-02 14:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-02 14:19 [PATCH] Revert "vhost: make msg padding explicit" Michael S. Tsirkin
2018-05-02 14:27 ` David Miller
2018-05-02 14:27 ` David Miller
2018-05-02 14:19 Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.