All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: idosch@mellanox.com
Cc: netdev@vger.kernel.org, dsahern@gmail.com,
	eric.dumazet@gmail.com, Thomas.Winter@alliedtelesis.co.nz,
	mlxsw@mellanox.com
Subject: Re: [PATCH net] ipv6: Revert "ipv6: Allow non-gateway ECMP for IPv6"
Date: Wed, 02 May 2018 16:33:26 -0400 (EDT)	[thread overview]
Message-ID: <20180502.163326.186058333461600916.davem@davemloft.net> (raw)
In-Reply-To: <20180502194156.9275-1-idosch@mellanox.com>

From: Ido Schimmel <idosch@mellanox.com>
Date: Wed,  2 May 2018 22:41:56 +0300

> This reverts commit edd7ceb78296 ("ipv6: Allow non-gateway ECMP for
> IPv6").
> 
> Eric reported a division by zero in rt6_multipath_rebalance() which is
> caused by above commit that considers identical local routes to be
> siblings. The division by zero happens because a nexthop weight is not
> set for local routes.
> 
> Revert the commit as it does not fix a bug and has side effects.
> 
> To reproduce:
> 
> # ip -6 address add 2001:db8::1/64 dev dummy0
> # ip -6 address add 2001:db8::1/64 dev dummy1
> 
> Fixes: edd7ceb78296 ("ipv6: Allow non-gateway ECMP for IPv6")
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>

Applied, thank you.

      parent reply	other threads:[~2018-05-02 20:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02 19:41 [PATCH net] ipv6: Revert "ipv6: Allow non-gateway ECMP for IPv6" Ido Schimmel
2018-05-02 19:50 ` Eric Dumazet
2018-05-02 20:33 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180502.163326.186058333461600916.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Thomas.Winter@alliedtelesis.co.nz \
    --cc=dsahern@gmail.com \
    --cc=eric.dumazet@gmail.com \
    --cc=idosch@mellanox.com \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.