From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDm6m-0001Nd-Hf for qemu-devel@nongnu.org; Wed, 02 May 2018 03:23:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDm6i-0003lc-Ha for qemu-devel@nongnu.org; Wed, 02 May 2018 03:23:24 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:34432 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fDm6i-0003lJ-Ae for qemu-devel@nongnu.org; Wed, 02 May 2018 03:23:20 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 62E75402335F for ; Wed, 2 May 2018 07:23:10 +0000 (UTC) Date: Wed, 2 May 2018 15:22:56 +0800 From: Peter Xu Message-ID: <20180502072256.GD32728@xz-mi> References: <20180418090239.13090-1-peterx@redhat.com> <20180418090239.13090-4-peterx@redhat.com> <20180430102126.GE4002@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180430102126.GE4002@stefanha-x1.localdomain> Subject: Re: [Qemu-devel] [PATCH v2 3/3] monitor: add lock to protect mon_fdsets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Eric Blake , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Markus Armbruster , "Dr . David Alan Gilbert" On Mon, Apr 30, 2018 at 11:21:26AM +0100, Stefan Hajnoczi wrote: > On Wed, Apr 18, 2018 at 05:02:39PM +0800, Peter Xu wrote: > > Similar to previous patch, but introduce a new global big lock for > > mon_fdsets. Take it where needed. > > Looks like monitor_fdset_get_fd() is missing. Yes. Fixing that up. Thanks, -- Peter Xu