From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH v13 07/10] drm: Handle aspect ratio info in legacy modeset path Date: Wed, 2 May 2018 09:56:56 +0200 Message-ID: <20180502075656.GY12521@phenom.ffwll.local> References: <1525243822-19308-1-git-send-email-ankit.k.nautiyal@intel.com> <1525243822-19308-8-git-send-email-ankit.k.nautiyal@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id A657C6E4EF for ; Wed, 2 May 2018 07:57:00 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id a8so21116486wmg.5 for ; Wed, 02 May 2018 00:57:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1525243822-19308-8-git-send-email-ankit.k.nautiyal@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Nautiyal, Ankit K" Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBNYXkgMDIsIDIwMTggYXQgMTI6MjA6MTlQTSArMDUzMCwgTmF1dGl5YWwsIEFua2l0 IEsgd3JvdGU6Cj4gRnJvbTogQW5raXQgTmF1dGl5YWwgPGFua2l0LmsubmF1dGl5YWxAaW50ZWwu Y29tPgo+IAo+IElmIHRoZSB1c2VyLXNwYWNlIGRvZXMgbm90IHN1cHBvcnQgYXNwZWN0LXJhdGlv LCBhbmQgcmVxdWVzdHMgZm9yIGEKPiBtb2Rlc2V0IHdpdGggbW9kZSBoYXZpbmcgYXNwZWN0IHJh dGlvIGJpdHMgc2V0LCB0aGVuIHRoZSBnaXZlbgo+IHVzZXItbW9kZSBtdXN0IGJlIHJlamVjdGVk LiBTZWNvbmRseSwgd2hpbGUgcHJlcGFyaW5nIGEgdXNlci1tb2RlIGZyb20KPiBrZXJuZWwgbW9k ZSwgdGhlIGFzcGVjdC1yYXRpbyBpbmZvIG11c3Qgbm90IGJlIGdpdmVuLCBpZiBhc3BlY3QtcmF0 aW8KPiBpcyBub3Qgc3VwcG9ydGVkIGJ5IHRoZSB1c2VyLgo+IAo+IFRoaXMgcGF0Y2g6Cj4gMS4g cmVqZWN0cyB0aGUgbW9kZXMgd2l0aCBhc3BlY3QtcmF0aW8gaW5mbywgZHVyaW5nIG1vZGVzZXQs IGlmIHRoZQo+ICAgIHVzZXIgZG9lcyBub3Qgc3VwcG9ydCBhc3BlY3QgcmF0aW8uCj4gMi4gZG9l cyBub3QgbG9hZCB0aGUgYXNwZWN0LXJhdGlvIGluZm8gaW4gdXNlci1tb2RlIHN0cnVjdHVyZSwg aWYKPiAgICBhc3BlY3QgcmF0aW8gaXMgbm90IHN1cHBvcnRlZC4KPiAzLiBhZGRzIGhlbHBlciBm dW5jdGlvbnMgZm9yIGRldGVybWluaW5nIGlmIGFzcGVjdC1yYXRpbyBpcyBleHBlY3RlZAo+ICAg IGluIHVzZXItbW9kZSBhbmQgZm9yIGFsbG93aW5nL2Rpc2FsbG93aW5nIHRoZSBhc3BlY3QtcmF0 aW8sIGlmIGl0cwo+ICAgIG5vdCBleHBlY3RlZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBBbmtpdCBO YXV0aXlhbCA8YW5raXQuay5uYXV0aXlhbEBpbnRlbC5jb20+Cj4gCj4gVjM6IEFkZHJlc3NlZCBy ZXZpZXcgY29tbWVudHMgZnJvbSBWaWxsZToKPiAgICAgRG8gbm90IGNvcnJ1cHQgdGhlIGN1cnJl bnQgY3J0YyBzdGF0ZSBieSB1cGRhdGluZyBhc3BlY3QtcmF0aW8gb24KPiAgICAgdGhlIGZseS4K PiBWNDogcmViYXNlCj4gVjU6IEFzIHN1Z2dlc3RlZCBieSBWaWxsZSwgcmVqZWN0ZWQgdGhlIG1v ZGVzZXQgY2FsbHMgZm9yIG1vZGVzIHdpdGgKPiAgICAgYXNwZWN0IHJhdGlvLCBpZiB0aGUgdXNl ciBkb2VzIG5vdCBzZXQgYXNwZWN0LXJhdGlvIGNhcC4KPiBWNjogVXNlZCB0aGUgaGVscGVyIGZ1 bmN0aW9ucyBmb3IgZGV0ZXJtaW5pbmcgaWYgYXNwZWN0LXJhdGlvIGlzCj4gICAgIGV4cGVjdGVk IGluIHRoZSB1c2VyLW1vZGUuCj4gVjc6IHJlYmFzZQo+IFY4OiByZWJhc2UKPiBWOTogcmViYXNl Cj4gVjEwOiBNb2RpZmllZCB0aGUgY29tbWl0LW1lc3NhZ2UKPiBWMTE6IHJlYmFzZQo+IFYxMjog TWVyZ2VkIHRoZSBwYXRjaCBmb3IgYWRkaW5nIGFzcGVjdC1yYXRpbyBoZWxwZXIgZnVuY3Rpb25z Cj4gICAgICB3aXRoIHRoaXMgcGF0Y2guCj4gVjEzOiBNaW5vciBtb2RpZmljYXRpb25zIGFzIHN1 Z2dlc3RlZCBieSBWaWxsZS4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMgICAg ICAgICAgfCAgOCArKysrKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Y19pbnRlcm5hbC5o IHwgIDYgKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL2RybV9tb2Rlcy5jICAgICAgICAgfCA0NyAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIDMgZmlsZXMgY2hhbmdlZCwg NjEgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Ny dGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gaW5kZXggYTIzMWRkNS4uOTgzMjNm NCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gQEAgLTQ0OSw2ICs0NDksNyBAQCBpbnQgZHJtX21vZGVf Z2V0Y3J0YyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJCQljcnRjX3Jlc3AtPm1vZGVfdmFs aWQgPSAwOwo+ICAJCX0KPiAgCX0KPiArCWRybV9tb2RlX2ZpbHRlcl9hc3BlY3RfcmF0aW9fZmxh Z3MoZmlsZV9wcml2LCAmY3J0Y19yZXNwLT5tb2RlKTsKPiAgCWRybV9tb2Rlc2V0X3VubG9jaygm Y3J0Yy0+bXV0ZXgpOwo+ICAKPiAgCXJldHVybiAwOwo+IEBAIC02MjgsNiArNjI5LDEzIEBAIGlu dCBkcm1fbW9kZV9zZXRjcnRjKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4g IAkJCXJldCA9IC1FTk9NRU07Cj4gIAkJCWdvdG8gb3V0Owo+ICAJCX0KPiArCQlpZiAoIWRybV9t b2RlX2FzcGVjdF9yYXRpb19hbGxvd2VkKGZpbGVfcHJpdiwKPiArCQkJCQkJICAgJmNydGNfcmVx LT5tb2RlKSkgewo+ICsJCQlEUk1fREVCVUdfS01TKCJVbmV4cGVjdGVkIGFzcGVjdC1yYXRpbyBm bGFnIGJpdHNcbiIpOwo+ICsJCQlyZXQgPSAtRUlOVkFMOwo+ICsJCQlnb3RvIG91dDsKPiArCQl9 Cj4gKwo+ICAKPiAgCQlyZXQgPSBkcm1fbW9kZV9jb252ZXJ0X3Vtb2RlKGRldiwgbW9kZSwgJmNy dGNfcmVxLT5tb2RlKTsKPiAgCQlpZiAocmV0KSB7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9kcm1fY3J0Y19pbnRlcm5hbC5oIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjX2ludGVy bmFsLmgKPiBpbmRleCA1ZDMwN2IyLi4zMWQ2Yzc3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9kcm1fY3J0Y19pbnRlcm5hbC5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRj X2ludGVybmFsLmgKPiBAQCAtMjIyLDMgKzIyMiw5IEBAIGludCBkcm1fbW9kZV9wYWdlX2ZsaXBf aW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgdm9pZCBkcm1fbW9kZV9maXh1cF8xMzY2 eDc2OChzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSk7Cj4gIHZvaWQgZHJtX3Jlc2V0X2Rp c3BsYXlfaW5mbyhzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKTsKPiAgdTMyIGRybV9h ZGRfZGlzcGxheV9pbmZvKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsIGNvbnN0IHN0 cnVjdCBlZGlkICplZGlkKTsKPiArCj4gKy8qIGRybV9tb2Rlcy5jICovCj4gK2Jvb2wgZHJtX21v ZGVfYXNwZWN0X3JhdGlvX2FsbG93ZWQoY29uc3Qgc3RydWN0IGRybV9maWxlICpmaWxlX3ByaXYs Cj4gKwkJCQkgICBzdHJ1Y3QgZHJtX21vZGVfbW9kZWluZm8gKnVtb2RlKTsKPiArdm9pZCBkcm1f bW9kZV9maWx0ZXJfYXNwZWN0X3JhdGlvX2ZsYWdzKGNvbnN0IHN0cnVjdCBkcm1fZmlsZSAqZmls ZV9wcml2LAo+ICsJCQkJCXN0cnVjdCBkcm1fbW9kZV9tb2RlaW5mbyAqdW1vZGUpOwo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX21vZGVzLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X21vZGVzLmMKPiBpbmRleCBjMzk1YTI0Li4yYmYyZjBiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9kcm1fbW9kZXMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fbW9kZXMuYwo+ IEBAIC0xNzU5LDMgKzE3NTksNTAgQEAgYm9vbCBkcm1fbW9kZV9pc180MjAoY29uc3Qgc3RydWN0 IGRybV9kaXNwbGF5X2luZm8gKmRpc3BsYXksCj4gIAkJZHJtX21vZGVfaXNfNDIwX2Fsc28oZGlz cGxheSwgbW9kZSk7Cj4gIH0KPiAgRVhQT1JUX1NZTUJPTChkcm1fbW9kZV9pc180MjApOwo+ICsK PiArLyoqCj4gKyAqIGRybV9tb2RlX2FzcGVjdF9yYXRpb19hbGxvd2VkIC0gY2hlY2tzIGlmIHRo ZSBhc3BlY3QtcmF0aW8gaW5mb3JtYXRpb24KPiArICogaXMgZXhwZWN0ZWQgZnJvbSB0aGUgdXNl ci1tb2RlLgo+ICsgKgo+ICsgKiBJZiB0aGUgdXNlciBoYXMgc2V0IGFzcGVjdC1yYXRpbyBjYXAs IHRoZW4gdGhlIGZsYWcgb2YgdGhlIHVzZXItbW9kZSBpcwo+ICsgKiBhbGxvd2VkIHRvIGNvbnRh aW4gYXNwZWN0LXJhdGlvIHZhbHVlLgo+ICsgKiBJZiB0aGUgdXNlciBkb2VzIG5vdCBzZXQgYXNw ZWN0LXJhdGlvIGNhcCwgdGhlbiB0aGUgb25seSB2YWx1ZSBhbGxvd2VkIGluIHRoZQo+ICsgKiBm bGFncyBiaXRzIGlzIGFzcGVjdC1yYXRpbyBOT05FLgo+ICsgKgo+ICsgKiBAZmlsZV9wcml2OiBm aWxlIHByaXZhdGUgc3RydWN0dXJlIHRvIGdldCB0aGUgdXNlciBjYXBhYmlsaXRpZXMKPiArICog QHVtb2RlOiBkcm1fbW9kZV9tb2RlaW5mbyBzdHJ1Y3QsIHdob3NlIGZsYWcgY2FycnkgdGhlIGFz cGVjdCByYXRpbwo+ICsgKiBpbmZvcm1hdGlvbi4KPiArICoKPiArICogUmV0dXJuczoKPiArICog dHJ1ZSBpZiB0aGUgYXNwZWN0LXJhdGlvIGluZm8gaXMgYWxsb3dlZCBpbiB0aGUgdXNlci1tb2Rl IGZsYWdzLgo+ICsgKiBmYWxzZSwgb3RoZXJ3aXNlLgo+ICsgKi8KCldlIGdlbmVyYWxseSBkb24n dCBkbyBmdWxsIGtlcm5lbGRvYyBmb3IgZHJtLmtvIGludGVybmFsIGZ1bmN0aW9ucyAod2hpY2gK dGhlc2UgYm90aCBhcmUpLCBvbmx5IGZvciBkcml2ZXIgZnVuY3Rpb25zLiBJJ2QgcmVtb3ZlIHRo ZW0gYm90aCBiZWNhdXNlCnRoZXkgZG9uJ3QgYWRkIGEgaG9sZSBsb3QgcmVhbGx5LgoKPiArYm9v bAo+ICtkcm1fbW9kZV9hc3BlY3RfcmF0aW9fYWxsb3dlZChjb25zdCBzdHJ1Y3QgZHJtX2ZpbGUg KmZpbGVfcHJpdiwKPiArCQkJICAgICAgc3RydWN0IGRybV9tb2RlX21vZGVpbmZvICp1bW9kZSkK CkkgZG9uJ3QgcmVhbGx5IHNlZSB0aGUgcG9pbnQgb2YgdGhpcyBoZWxwZXIuIEl0IGhhcyBhIGJp dCBhIGNvbmZ1c2luZwpuYW1lLCBhbmQgb3Blbi1jb2RlIGl0IGxvb2tzIHNpbXBsZXIgdG8gbWUg aW4gc2V0Y3J0Yy4KCj4gK3sKPiArCWlmIChmaWxlX3ByaXYtPmFzcGVjdF9yYXRpb19hbGxvd2Vk IHx8Cj4gKwkgICAgKHVtb2RlLT5mbGFncyAmIERSTV9NT0RFX0ZMQUdfUElDX0FSX01BU0spID09 IERSTV9NT0RFX0ZMQUdfUElDX0FSX05PTkUpCj4gKwkJcmV0dXJuIHRydWU7Cj4gKwlyZXR1cm4g ZmFsc2U7Cj4gK30KPiArCj4gKy8qKgo+ICsgKiBkcm1fbW9kZV9maWx0ZXJfYXNwZWN0X3JhdGlv X2ZsYWdzIC0gZmlsdGVycyB0aGUgYXNwZWN0LXJhdGlvIGJpdHMgaW4gdGhlCj4gKyAqIHVzZXIt bW9kZSBmbGFncy4KPiArICoKPiArICogQ2hlY2tzIGlmIHRoZSBhc3BlY3QtcmF0aW8gaW5mb3Jt YXRpb24gaXMgYWxsb3dlZC4gUmVzZXRzIHRoZSBhc3BlY3QtcmF0aW8KPiArICogYml0cyBpbiB0 aGUgdXNlci1tb2RlIGZsYWdzLCBpZiBhc3BlY3QtcmF0aW8gaW5mbyBpcyBub3QgYWxsb3dlZC4K PiArICoKPiArICogQGZpbGVfcHJpdjogZmlsZSBwcml2YXRlIHN0cnVjdHVyZSB0byBnZXQgdGhl IHVzZXIgY2FwYWJpbGl0aWVzLgo+ICsgKiBAdW1vZGU6IGRybV9tb2RlX21vZGVpbmZvIHN0cnVj dCwgd2hvc2UgZmxhZ3MnIGFzcGVjdC1yYXRpbyBiaXRzIG5lZWRzIHRvCj4gKyAqIGJlIGZpbHRl cmVkLgo+ICsgKgo+ICsgKi8KPiArdm9pZAo+ICtkcm1fbW9kZV9maWx0ZXJfYXNwZWN0X3JhdGlv X2ZsYWdzKGNvbnN0IHN0cnVjdCBkcm1fZmlsZSAqZmlsZV9wcml2LAo+ICsJCQkJICAgc3RydWN0 IGRybV9tb2RlX21vZGVpbmZvICp1bW9kZSkKPiArewo+ICsJaWYgKCFkcm1fbW9kZV9hc3BlY3Rf cmF0aW9fYWxsb3dlZChmaWxlX3ByaXYsIHVtb2RlKSkKCllvdSBvbmx5IG5lZWQgdG8gY2hlY2sg Zm9yIGZpbGVfcHJpdi0+YXNwZWN0X3JhdGlvX2FsbG93ZWQgaGVyZSwgdGhlbgpjbGVhciB1bmNv bmRpdGlvbmFsbHkuCi1EYW5pZWwKCj4gKwkJdW1vZGUtPmZsYWdzICY9IH5EUk1fTU9ERV9GTEFH X1BJQ19BUl9NQVNLOwo+ICt9Cj4gLS0gCj4gMi43LjQKPiAKPiBfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3 YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK