[PATCH i-g-t] igt/gem_wait: Relax assertion for wait completion

[PATCH i-g-t] igt/gem_wait: Relax assertion for wait completion

[Chris Wilson]

When waiting for a finite batch, all that we require is that the batch
completes. If it takes the full second (or longer) for us to wake up and
notice the completed batch is immaterial, so only assert that we don't
report an infinite timeout afterwards.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/gem_wait.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/gem_wait.c b/tests/gem_wait.c
index 1d10055bb..61d8a4059 100644
--- a/tests/gem_wait.c
+++ b/tests/gem_wait.c
@@ -113,7 +113,7 @@ static void basic(int fd, unsigned engine, unsigned flags)
 			igt_spin_batch_set_timeout(spin, NSEC_PER_SEC/2);
 			wait.timeout_ns = NSEC_PER_SEC; /* 1.0s */
 			igt_assert_eq(__gem_wait(fd, &wait), 0);
-			igt_assert(wait.timeout_ns > 0);
+			igt_assert(wait.timeout_ns >= 0);
 		} else {
 			wait.timeout_ns = -1;
 			igt_assert_eq(__gem_wait(fd, &wait), 0);
-- 
2.17.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for igt/gem_wait: Relax assertion for wait completion

[Patchwork]

== Series Details ==

Series: igt/gem_wait: Relax assertion for wait completion
URL   : https://patchwork.freedesktop.org/series/42564/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4121 -> IGTPW_1313 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/42564/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1313 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-skl-6700k2:      PASS -> FAIL (fdo#103191)

    
    ==== Possible fixes ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-ivb-3520m:       DMESG-WARN (fdo#106084) -> PASS

    
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#106084 https://bugs.freedesktop.org/show_bug.cgi?id=106084


== Participating hosts (40 -> 37) ==

  Missing    (3): fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq 


== Build changes ==

    * IGT: IGT_4456 -> IGTPW_1313

  CI_DRM_4121: d4f7520d80ab83ea9053ee080df09a23463b6966 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1313: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1313/
  IGT_4456: 43761534c6482dc67b9c3d8eeecd425ef40b3c4c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4456: 30b992bdc047073e1fe99b1ac622f026618a8081 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1313/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for igt/gem_wait: Relax assertion for wait completion

[Patchwork]

== Series Details ==

Series: igt/gem_wait: Relax assertion for wait completion
URL   : https://patchwork.freedesktop.org/series/42564/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4456_full -> IGTPW_1313_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1313_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1313_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/42564/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1313_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_mocs_settings@mocs-rc6-bsd1:
      shard-kbl:          SKIP -> PASS

    igt@pm_rc6_residency@rc6-accuracy:
      shard-snb:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_1313_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible:
      shard-apl:          PASS -> FAIL (fdo#100368)

    igt@kms_flip@flip-vs-wf_vblank-interruptible:
      shard-glk:          PASS -> FAIL (fdo#105312)

    igt@kms_flip@modeset-vs-vblank-race-interruptible:
      shard-glk:          PASS -> FAIL (fdo#103060)

    igt@kms_flip@plain-flip-fb-recreate-interruptible:
      shard-glk:          PASS -> FAIL (fdo#100368)

    igt@kms_setmode@basic:
      shard-kbl:          PASS -> FAIL (fdo#99912)

    igt@kms_vblank@pipe-c-ts-continuation-suspend:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665) +1

    igt@perf_pmu@rc6-runtime-pm-long:
      shard-glk:          PASS -> FAIL (fdo#105010)
      shard-kbl:          PASS -> FAIL (fdo#105010)

    
    ==== Possible fixes ====

    igt@drv_selftest@mock_breadcrumbs:
      shard-hsw:          DMESG-FAIL (fdo#106085) -> PASS
      shard-snb:          DMESG-FAIL (fdo#106085) -> PASS
      shard-glk:          DMESG-FAIL (fdo#106085) -> PASS
      shard-apl:          DMESG-FAIL (fdo#106085) -> PASS
      shard-kbl:          DMESG-FAIL (fdo#106085) -> PASS

    igt@gem_exec_suspend@basic-s3:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS

    igt@kms_cursor_crc@cursor-128x128-suspend:
      shard-glk:          INCOMPLETE (fdo#103359, k.org#198133) -> PASS

    igt@kms_cursor_legacy@flip-vs-cursor-atomic:
      shard-hsw:          FAIL (fdo#102670) -> PASS

    igt@kms_flip@2x-plain-flip-ts-check:
      shard-hsw:          FAIL (fdo#100368) -> PASS

    igt@kms_flip@plain-flip-ts-check-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS

    igt@kms_flip@wf_vblank-ts-check:
      shard-hsw:          FAIL (fdo#103928) -> PASS

    igt@kms_flip@wf_vblank-ts-check-interruptible:
      shard-apl:          FAIL (fdo#100368) -> PASS

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          FAIL (fdo#103925) -> PASS

    igt@kms_setmode@basic:
      shard-apl:          FAIL (fdo#99912) -> PASS

    igt@kms_sysfs_edid_timing:
      shard-apl:          WARN (fdo#100047) -> PASS

    
  fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
  fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
  fdo#105010 https://bugs.freedesktop.org/show_bug.cgi?id=105010
  fdo#105312 https://bugs.freedesktop.org/show_bug.cgi?id=105312
  fdo#106085 https://bugs.freedesktop.org/show_bug.cgi?id=106085
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (7 -> 5) ==

  Missing    (2): pig-skl-6600 pig-glk-j4005 


== Build changes ==

    * IGT: IGT_4456 -> IGTPW_1313
    * Linux: CI_DRM_4117 -> CI_DRM_4121

  CI_DRM_4117: 844dd95837ab995c37d1139d74ff55139987b437 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4121: d4f7520d80ab83ea9053ee080df09a23463b6966 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1313: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1313/
  IGT_4456: 43761534c6482dc67b9c3d8eeecd425ef40b3c4c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4456: 30b992bdc047073e1fe99b1ac622f026618a8081 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1313/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] igt/gem_wait: Relax assertion for wait completion

[Joonas Lahtinen]

Quoting Chris Wilson (2018-05-02 14:13:26)
> When waiting for a finite batch, all that we require is that the batch
> completes. If it takes the full second (or longer) for us to wake up and
> notice the completed batch is immaterial, so only assert that we don't
> report an infinite timeout afterwards.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

May wanna Cc igt-dev@...

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] igt/gem_wait: Relax assertion for wait completion

[Chris Wilson]

Quoting Joonas Lahtinen (2018-05-03 15:05:38)
> Quoting Chris Wilson (2018-05-02 14:13:26)
> > When waiting for a finite batch, all that we require is that the batch
> > completes. If it takes the full second (or longer) for us to wake up and
> > notice the completed batch is immaterial, so only assert that we don't
> > report an infinite timeout afterwards.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> May wanna Cc igt-dev@...

Seemed to be an i915-centric issue, just matching the test code to
kernel behaviour.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx