All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Bhadram Varka <vbhadram@nvidia.com>
Cc: f.fainelli@gmail.com, davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: phy: broadcom: add support for BCM89610 PHY
Date: Wed, 2 May 2018 15:29:38 +0200	[thread overview]
Message-ID: <20180502132938.GB23318@lunn.ch> (raw)
In-Reply-To: <1525256676-24335-1-git-send-email-vbhadram@nvidia.com>

On Wed, May 02, 2018 at 03:54:36PM +0530, Bhadram Varka wrote:
> It adds support for BCM89610 (Single-Port 10/100/1000BASE-T)
> transceiver which is used in P3310 Tegra186 platform.
> 
> Signed-off-by: Bhadram Varka <vbhadram@nvidia.com>
> ---
>  drivers/net/phy/broadcom.c | 11 +++++++++++
>  include/linux/brcmphy.h    |  1 +
>  2 files changed, 12 insertions(+)
> 
> diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
> index 3bb6b66..1e4b6c2 100644
> --- a/drivers/net/phy/broadcom.c
> +++ b/drivers/net/phy/broadcom.c
> @@ -720,6 +720,16 @@ static struct phy_driver broadcom_drivers[] = {
>  	.get_strings	= bcm_phy_get_strings,
>  	.get_stats	= bcm53xx_phy_get_stats,
>  	.probe		= bcm53xx_phy_probe,
> +}, {
> +	.phy_id         = PHY_ID_BCM89610,
> +	.phy_id_mask    = 0xfffffff0,
> +	.name           = "Broadcom BCM89610",
> +	.features       = PHY_GBIT_FEATURES |
> +			  SUPPORTED_Pause | SUPPORTED_Asym_Pause,

Hi Bhadram

Why do you have SUPPORTED_Pause | SUPPORTED_Asym_Pause. No other PHY
does.

Take a look at Documentation/networking/phy.txt

	Andrew

  reply	other threads:[~2018-05-02 13:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02 10:24 [PATCH net-next] net: phy: broadcom: add support for BCM89610 PHY Bhadram Varka
2018-05-02 13:29 ` Andrew Lunn [this message]
2018-05-02 14:16   ` Bhadram Varka
2018-05-02 17:21 ` David Miller
2018-05-02 18:47   ` Bhadram Varka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180502132938.GB23318@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=vbhadram@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.