Re: [PATCH net-next] net: phy: broadcom: add support for BCM89610 PHY

From: Andrew Lunn <andrew@lunn.ch>
To: Bhadram Varka <vbhadram@nvidia.com>
Cc: f.fainelli@gmail.com, davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: phy: broadcom: add support for BCM89610 PHY
Date: Wed, 2 May 2018 15:29:38 +0200	[thread overview]
Message-ID: <20180502132938.GB23318@lunn.ch> (raw)
In-Reply-To: <1525256676-24335-1-git-send-email-vbhadram@nvidia.com>

On Wed, May 02, 2018 at 03:54:36PM +0530, Bhadram Varka wrote:
> It adds support for BCM89610 (Single-Port 10/100/1000BASE-T)
> transceiver which is used in P3310 Tegra186 platform.
> 
> Signed-off-by: Bhadram Varka <vbhadram@nvidia.com>
> ---
>  drivers/net/phy/broadcom.c | 11 +++++++++++
>  include/linux/brcmphy.h    |  1 +
>  2 files changed, 12 insertions(+)
> 
> diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
> index 3bb6b66..1e4b6c2 100644
> --- a/drivers/net/phy/broadcom.c
> +++ b/drivers/net/phy/broadcom.c
> @@ -720,6 +720,16 @@ static struct phy_driver broadcom_drivers[] = {
>  	.get_strings	= bcm_phy_get_strings,
>  	.get_stats	= bcm53xx_phy_get_stats,
>  	.probe		= bcm53xx_phy_probe,
> +}, {
> +	.phy_id         = PHY_ID_BCM89610,
> +	.phy_id_mask    = 0xfffffff0,
> +	.name           = "Broadcom BCM89610",
> +	.features       = PHY_GBIT_FEATURES |
> +			  SUPPORTED_Pause | SUPPORTED_Asym_Pause,

Hi Bhadram

Why do you have SUPPORTED_Pause | SUPPORTED_Asym_Pause. No other PHY
does.

Take a look at Documentation/networking/phy.txt

	Andrew