From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AB8JxZqkqQ9jBTcd4xwJP+F7nCdHlIw39OcGiUnClMWgpeg89Q0ay8kGZmIrij2rvaQBfVxoGmV5 ARC-Seal: i=1; a=rsa-sha256; t=1525270050; cv=none; d=google.com; s=arc-20160816; b=ZcaQvvGfG91Q/XjXoSxcVDJ8IrOrdvhCNC3LGvoyWtlICxBHZmMPHeQW5N1xS7UGoD ZIfaBispgQ/6geyeeM3xsGYNyMRIPqWimr0Gvu0vVqN15fyQvp0tRKDKBkUK73qq9WMk Edsf6Yhjyugpf0vg94eZHf6pI8GF3cIlUKVoPWAjzLow6xOJd1ainPfEMbYltALcAx5h 74ddBSUzWWuUAOYTJV/XwpVjLagKp5JD1/SJGe5Nr8TtQrduOYMxnJbDrc7RIaO7fImS UAubBQLzERZ5amYNn6c86HWLngvbA6bxZAzA7gICOWQDiAS2Ft7CzXvZkqQyM6LU+rsc YHMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:arc-authentication-results; bh=WM8UEP035wdv0+enhFbPmdiiH8+IWJI9QLM8a0llwsc=; b=xLyeLBaqDipLUe9Si4j/nvOwM249/nFHsC5JfMjYHUr/aLZbEsLT5w3TIxdcOF8dYr 0CJvsajt6zqcQ0V4MEvI8kot3+Y/5vzqFEygdKklrOnxsyCiE6n7cf0tAuAdwTLzTt55 XfQ70yq1AGBtG9W64E67c+lQtNXbCEhhmIG42eibirUFxVFvehWcuMxoPsaVsbIsl3NP 42bAwVnmDSUckISQ/eMfX1Eza04vKmJPRZNc3kji10JuP/BUg0prxzsRIqIPMenwjQEh 0NHf27ST21uqVdNBDfyBOgs4p804ITy8AE3Jt/KVKKe9aOjfrX0GpVu5XzU92cB6FWOA IDZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of heikki.krogerus@linux.intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=heikki.krogerus@linux.intel.com Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of heikki.krogerus@linux.intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=heikki.krogerus@linux.intel.com X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,354,1520924400"; d="scan'208";a="51763366" Date: Wed, 2 May 2018 17:07:12 +0300 From: Heikki Krogerus To: "Gustavo A. R. Silva" Cc: Adam Thomson , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] typec: tcpm: Fix incorrect 'and' operator Message-ID: <20180502140712.GH12870@kuha.fi.intel.com> References: <20180430132305.GA20092@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180430132305.GA20092@embeddedor.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1599177583315006788?= X-GMAIL-MSGID: =?utf-8?q?1599361569065462279?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, Apr 30, 2018 at 08:23:06AM -0500, Gustavo A. R. Silva wrote: > Currently, logical and is being used instead of *bitwise* and. > > Fix this by using a proper bitwise and operator. > > Addresses-Coverity-ID: 1468455 ("Logical vs. bitwise operator") > Fixes: 64f7c494a3c0 ("typec: tcpm: Add support for sink PPS related > messages") > Signed-off-by: Gustavo A. R. Silva Acked-by: Heikki Krogerus > --- > drivers/usb/typec/tcpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c > index 1ee259b..7ee417a 100644 > --- a/drivers/usb/typec/tcpm.c > +++ b/drivers/usb/typec/tcpm.c > @@ -1772,7 +1772,7 @@ static void tcpm_pd_ext_msg_request(struct tcpm_port *port, > enum pd_ext_msg_type type = pd_header_type_le(msg->header); > unsigned int data_size = pd_ext_header_data_size_le(msg->ext_msg.header); > > - if (!(msg->ext_msg.header && PD_EXT_HDR_CHUNKED)) { > + if (!(msg->ext_msg.header & PD_EXT_HDR_CHUNKED)) { > tcpm_log(port, "Unchunked extended messages unsupported"); > return; > } Thanks, -- heikki From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heikki Krogerus Date: Wed, 02 May 2018 14:07:12 +0000 Subject: Re: [PATCH] typec: tcpm: Fix incorrect 'and' operator Message-Id: <20180502140712.GH12870@kuha.fi.intel.com> List-Id: References: <20180430132305.GA20092@embeddedor.com> In-Reply-To: <20180430132305.GA20092@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Gustavo A. R. Silva" Cc: Adam Thomson , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Mon, Apr 30, 2018 at 08:23:06AM -0500, Gustavo A. R. Silva wrote: > Currently, logical and is being used instead of *bitwise* and. > > Fix this by using a proper bitwise and operator. > > Addresses-Coverity-ID: 1468455 ("Logical vs. bitwise operator") > Fixes: 64f7c494a3c0 ("typec: tcpm: Add support for sink PPS related > messages") > Signed-off-by: Gustavo A. R. Silva Acked-by: Heikki Krogerus > --- > drivers/usb/typec/tcpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c > index 1ee259b..7ee417a 100644 > --- a/drivers/usb/typec/tcpm.c > +++ b/drivers/usb/typec/tcpm.c > @@ -1772,7 +1772,7 @@ static void tcpm_pd_ext_msg_request(struct tcpm_port *port, > enum pd_ext_msg_type type = pd_header_type_le(msg->header); > unsigned int data_size = pd_ext_header_data_size_le(msg->ext_msg.header); > > - if (!(msg->ext_msg.header && PD_EXT_HDR_CHUNKED)) { > + if (!(msg->ext_msg.header & PD_EXT_HDR_CHUNKED)) { > tcpm_log(port, "Unchunked extended messages unsupported"); > return; > } Thanks, -- heikki From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: typec: tcpm: Fix incorrect 'and' operator From: Heikki Krogerus Message-Id: <20180502140712.GH12870@kuha.fi.intel.com> Date: Wed, 2 May 2018 17:07:12 +0300 To: "Gustavo A. R. Silva" Cc: Adam Thomson , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org List-ID: T24gTW9uLCBBcHIgMzAsIDIwMTggYXQgMDg6MjM6MDZBTSAtMDUwMCwgR3VzdGF2byBBLiBSLiBT aWx2YSB3cm90ZToKPiBDdXJyZW50bHksIGxvZ2ljYWwgYW5kIGlzIGJlaW5nIHVzZWQgaW5zdGVh ZCBvZiAqYml0d2lzZSogYW5kLgo+IAo+IEZpeCB0aGlzIGJ5IHVzaW5nIGEgcHJvcGVyIGJpdHdp c2UgYW5kIG9wZXJhdG9yLgo+IAo+IEFkZHJlc3Nlcy1Db3Zlcml0eS1JRDogMTQ2ODQ1NSAoIkxv Z2ljYWwgdnMuIGJpdHdpc2Ugb3BlcmF0b3IiKQo+IEZpeGVzOiA2NGY3YzQ5NGEzYzAgKCJ0eXBl YzogdGNwbTogQWRkIHN1cHBvcnQgZm9yIHNpbmsgUFBTIHJlbGF0ZWQKPiBtZXNzYWdlcyIpCj4g U2lnbmVkLW9mZi1ieTogR3VzdGF2byBBLiBSLiBTaWx2YSA8Z3VzdGF2b0BlbWJlZGRlZG9yLmNv bT4KCkFja2VkLWJ5OiBIZWlra2kgS3JvZ2VydXMgPGhlaWtraS5rcm9nZXJ1c0BsaW51eC5pbnRl bC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL3VzYi90eXBlYy90Y3BtLmMgfCAyICstCj4gIDEgZmls ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL3VzYi90eXBlYy90Y3BtLmMgYi9kcml2ZXJzL3VzYi90eXBlYy90Y3BtLmMKPiBp bmRleCAxZWUyNTliLi43ZWU0MTdhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdXNiL3R5cGVjL3Rj cG0uYwo+ICsrKyBiL2RyaXZlcnMvdXNiL3R5cGVjL3RjcG0uYwo+IEBAIC0xNzcyLDcgKzE3NzIs NyBAQCBzdGF0aWMgdm9pZCB0Y3BtX3BkX2V4dF9tc2dfcmVxdWVzdChzdHJ1Y3QgdGNwbV9wb3J0 ICpwb3J0LAo+ICAJZW51bSBwZF9leHRfbXNnX3R5cGUgdHlwZSA9IHBkX2hlYWRlcl90eXBlX2xl KG1zZy0+aGVhZGVyKTsKPiAgCXVuc2lnbmVkIGludCBkYXRhX3NpemUgPSBwZF9leHRfaGVhZGVy X2RhdGFfc2l6ZV9sZShtc2ctPmV4dF9tc2cuaGVhZGVyKTsKPiAgCj4gLQlpZiAoIShtc2ctPmV4 dF9tc2cuaGVhZGVyICYmIFBEX0VYVF9IRFJfQ0hVTktFRCkpIHsKPiArCWlmICghKG1zZy0+ZXh0 X21zZy5oZWFkZXIgJiBQRF9FWFRfSERSX0NIVU5LRUQpKSB7Cj4gIAkJdGNwbV9sb2cocG9ydCwg IlVuY2h1bmtlZCBleHRlbmRlZCBtZXNzYWdlcyB1bnN1cHBvcnRlZCIpOwo+ICAJCXJldHVybjsK PiAgCX0KClRoYW5rcywK