All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 3/7] bootcount: Add function wrappers to handle bootcount increment and error checking
Date: Wed,  2 May 2018 16:10:52 +0200	[thread overview]
Message-ID: <20180502141056.23937-4-lukma@denx.de> (raw)
In-Reply-To: <20180502141056.23937-1-lukma@denx.de>

Those two functions can be used to provide easy bootcount management.

Signed-off-by: Lukasz Majewski <lukma@denx.de>

Reviewed-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Stefan Roese <sr@denx.de>
---

Changes in v5:
- Provide parenthesis for #if defined(FOO) && ...

Changes in v4:
- Remove enum bootcount_context and replace it with checking gd_t->flags
  (The GD_FLG_SPL_INIT is only set in SPL, it is cleared in u-boot proper,
   so can be used as indication if we are in u-boot or SPL).
- Do not call bootcount_store() twice when it is not needed.
- Call env_set_ulong("bootcount", bootcount); only in NON SPL context -
  Boards with TINY_PRINTF (in newest mainline) will build break as this function
  requires simple_itoa() from vsprintf.c (now not always build in SPL).

Changes in v3:
- Unify those functions to also work with common/autoboot.c code
- Add enum bootcount_context to distinguish between u-boot proper and SPL

Changes in v2:
- None

 include/bootcount.h | 47 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/include/bootcount.h b/include/bootcount.h
index e3b3f7028e..a886c98f44 100644
--- a/include/bootcount.h
+++ b/include/bootcount.h
@@ -11,6 +11,8 @@
 #include <asm/io.h>
 #include <asm/byteorder.h>
 
+#if defined(CONFIG_SPL_BOOTCOUNT_LIMIT) || defined(CONFIG_BOOTCOUNT_LIMIT)
+
 #if !defined(CONFIG_SYS_BOOTCOUNT_LE) && !defined(CONFIG_SYS_BOOTCOUNT_BE)
 # if __BYTE_ORDER == __LITTLE_ENDIAN
 #  define CONFIG_SYS_BOOTCOUNT_LE
@@ -40,4 +42,49 @@ static inline u32 raw_bootcount_load(volatile u32 *addr)
 	return in_be32(addr);
 }
 #endif
+
+DECLARE_GLOBAL_DATA_PTR;
+static inline int bootcount_error(void)
+{
+	unsigned long bootcount = bootcount_load();
+	unsigned long bootlimit = env_get_ulong("bootlimit", 10, 0);
+
+	if (bootlimit && bootcount > bootlimit) {
+		printf("Warning: Bootlimit (%lu) exceeded.", bootlimit);
+		if (!(gd->flags & GD_FLG_SPL_INIT))
+			printf(" Using altbootcmd.");
+		printf("\n");
+
+		return 1;
+	}
+
+	return 0;
+}
+
+static inline void bootcount_inc(void)
+{
+	unsigned long bootcount = bootcount_load();
+
+	if (gd->flags & GD_FLG_SPL_INIT) {
+		bootcount_store(++bootcount);
+		return;
+	}
+
+#ifndef CONFIG_SPL_BUILD
+	/* Only increment bootcount when no bootcount support in SPL */
+#ifndef CONFIG_SPL_BOOTCOUNT_LIMIT
+	bootcount_store(++bootcount);
+#endif
+	env_set_ulong("bootcount", bootcount);
+#endif /* !CONFIG_SPL_BUILD */
+}
+
+#if defined(CONFIG_SPL_BUILD) && !defined(CONFIG_SPL_BOOTCOUNT_LIMIT)
+void bootcount_store(ulong a) {};
+ulong bootcount_load(void) { return 0; }
+#endif /* CONFIG_SPL_BUILD && !CONFIG_SPL_BOOTCOUNT_LIMIT */
+#else
+static inline int bootcount_error(void) { return 0; }
+static inline void bootcount_inc(void) {}
+#endif /* CONFIG_SPL_BOOTCOUNT_LIMIT || CONFIG_BOOTCOUNT_LIMIT */
 #endif /* _BOOTCOUNT_H__ */
-- 
2.11.0

  parent reply	other threads:[~2018-05-02 14:10 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02 14:10 [U-Boot] [PATCH v5 0/7] Provide SPL support for bootcount (in the case of using falcon boot mode) Lukasz Majewski
2018-05-02 14:10 ` [U-Boot] [PATCH v5 1/7] bootcount: spl: Enable bootcount support in SPL Lukasz Majewski
2018-05-08  4:51   ` Alex Kiernan
2018-05-11 11:07   ` [U-Boot] [U-Boot, v5, " Tom Rini
2018-05-02 14:10 ` [U-Boot] [PATCH v5 2/7] bootcount: Add include guards into bootcount.h file Lukasz Majewski
2018-05-08  4:52   ` Alex Kiernan
2018-05-11 11:07   ` [U-Boot] [U-Boot, v5, " Tom Rini
2018-05-02 14:10 ` Lukasz Majewski [this message]
2018-05-08  5:15   ` [U-Boot] [PATCH v5 3/7] bootcount: Add function wrappers to handle bootcount increment and error checking Alex Kiernan
2018-05-08  6:58     ` Alex Kiernan
2018-05-08  7:11       ` Stefan Roese
2018-05-08  7:38         ` Lukasz Majewski
2018-05-08  8:45         ` Alex Kiernan
2018-05-08  7:41     ` Lukasz Majewski
2018-05-08  8:53       ` Alex Kiernan
2018-05-08  9:21         ` Lukasz Majewski
2018-05-08  9:28           ` Alex Kiernan
2018-05-08 10:27             ` Lukasz Majewski
2018-05-11 11:07   ` [U-Boot] [U-Boot, v5, " Tom Rini
2018-05-02 14:10 ` [U-Boot] [PATCH v5 4/7] bootcount: Rewrite autoboot to use wrapper functions from bootcount.h Lukasz Majewski
2018-05-08  5:23   ` Alex Kiernan
2018-05-11 11:08   ` [U-Boot] [U-Boot, v5, " Tom Rini
2018-05-02 14:10 ` [U-Boot] [PATCH v5 5/7] bootcount: spl: Extend SPL to support bootcount incrementation Lukasz Majewski
2018-05-11 11:08   ` [U-Boot] [U-Boot, v5, " Tom Rini
2018-05-02 14:10 ` [U-Boot] [PATCH v5 6/7] bootcount: display5: spl: Extend DISPLAY5 board SPL to support bootcount checking Lukasz Majewski
2018-05-11 11:08   ` [U-Boot] [U-Boot, v5, " Tom Rini
2018-05-02 14:10 ` [U-Boot] [PATCH v5 7/7] bootcount: display5: config: Enable boot count feature in the display5 board Lukasz Majewski
2018-05-11 11:08   ` [U-Boot] [U-Boot, v5, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180502141056.23937-4-lukma@denx.de \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.