All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/2] pwm: sunxi: add support for PWM found on Allwinner A64
Date: Wed, 2 May 2018 14:42:08 +0200	[thread overview]
Message-ID: <20180502144208.65dd17fa@crub> (raw)
In-Reply-To: <20180502092436.4t7s56be7y36ghx3@flea>

Hi,

On Wed, 2 May 2018 11:24:36 +0200
Maxime Ripard maxime.ripard at bootlin.com wrote:

> Hi,
> 
> On Sat, Apr 28, 2018 at 02:05:14PM -0700, Vasily Khoruzhick wrote:
> > +static const struct udevice_id sunxi_pwm_ids[] = {
> > +	{ .compatible = "allwinner,sun50i-a64-pwm" },
> > +	{ }
> > +};
> > +
> > +U_BOOT_DRIVER(sunxi_pwm) = {
> > +	.name	= "sunxi_pwm",
> > +	.id	= UCLASS_PWM,
> > +	.of_match = sunxi_pwm_ids,
> > +	.ops	= &sunxi_pwm_ops,
> > +	.ofdata_to_platdata	= sunxi_pwm_ofdata_to_platdata,
> > +	.probe		= sunxi_pwm_probe,
> > +	.priv_auto_alloc_size	= sizeof(struct sunxi_pwm_priv),
> > +};  
> 
> The binding should be the same one than used in Linux.

Linux (in next) uses "allwinner,sun50i-a64-pwm", "allwinner,sun5i-a13-pwm"
binding, so please add "allwinner,sun5i-a13-pwm" here.

--
Anatolij

  reply	other threads:[~2018-05-02 12:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-28 21:05 [U-Boot] [PATCH v3 0/2] sunxi: add PWM driver for A64 Vasily Khoruzhick
2018-04-28 21:05 ` [U-Boot] [PATCH v3 1/2] pwm: sunxi: add support for PWM found on Allwinner A64 Vasily Khoruzhick
2018-05-02  9:24   ` Maxime Ripard
2018-05-02 12:42     ` Anatolij Gustschin [this message]
2018-04-28 21:05 ` [U-Boot] [PATCH v3 2/2] dts: sunxi: add PWM node for sun50i Vasily Khoruzhick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180502144208.65dd17fa@crub \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.