All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] swiotlb: Fix inversed DMA_ATTR_NO_WARN test
@ 2018-05-01 13:24 ` Michel Dänzer
  0 siblings, 0 replies; 20+ messages in thread
From: Michel Dänzer @ 2018-05-01 13:24 UTC (permalink / raw)
  To: Konrad Rzeszutek Wilk, Christoph Hellwig; +Cc: iommu, dri-devel, linux-kernel

From: Michel Dänzer <michel.daenzer@amd.com>

The result was printing the warning only when we were explicitly asked
not to.

Cc: stable@vger.kernel.org
Fixes: 0176adb004065d6815a8e67946752df4cd947c5b "swiotlb: refactor
 coherent buffer allocation"
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
---
 lib/swiotlb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/swiotlb.c b/lib/swiotlb.c
index c43ec2271469..e9ac21540628 100644
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -750,7 +750,7 @@ swiotlb_alloc_buffer(struct device *dev, size_t size, dma_addr_t *dma_handle,
 	swiotlb_tbl_unmap_single(dev, phys_addr, size, DMA_TO_DEVICE,
 			DMA_ATTR_SKIP_CPU_SYNC);
 out_warn:
-	if ((attrs & DMA_ATTR_NO_WARN) && printk_ratelimit()) {
+	if (!(attrs & DMA_ATTR_NO_WARN) && printk_ratelimit()) {
 		dev_warn(dev,
 			"swiotlb: coherent allocation failed, size=%zu\n",
 			size);
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 20+ messages in thread
* [PATCH] swiotlb: fix inversed DMA_ATTR_NO_WARN test
@ 2018-05-10  0:49 Prasanthi Chellakumar
  0 siblings, 0 replies; 20+ messages in thread
From: Prasanthi Chellakumar @ 2018-05-10  0:49 UTC (permalink / raw)
  Cc: Michel Dänzer, stable, Christoph Hellwig

From: Michel Dänzer <michel.daenzer@amd.com>

The result was printing the warning only when we were explicitly asked
not to.

Cc: stable@vger.kernel.org
Fixes: 0176adb004065d6815a8e67946752df4cd947c5b "swiotlb: refactor
 coherent buffer allocation"
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 lib/swiotlb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/swiotlb.c b/lib/swiotlb.c
index fece575..12fbaa4 100644
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -737,7 +737,7 @@ swiotlb_alloc_buffer(struct device *dev, size_t size, dma_addr_t *dma_handle,
 	swiotlb_tbl_unmap_single(dev, phys_addr, size, DMA_TO_DEVICE,
 			DMA_ATTR_SKIP_CPU_SYNC);
 out_warn:
-	if ((attrs & DMA_ATTR_NO_WARN) && printk_ratelimit()) {
+	if (!(attrs & DMA_ATTR_NO_WARN) && printk_ratelimit()) {
 		dev_warn(dev,
 			"swiotlb: coherent allocation failed, size=%zu\n",
 			size);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2018-05-25  8:41 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-01 13:24 [PATCH] swiotlb: Fix inversed DMA_ATTR_NO_WARN test Michel Dänzer
2018-05-01 13:24 ` Michel Dänzer
2018-05-02  9:49 ` Christian König
2018-05-02  9:49   ` Christian König
2018-05-02 12:18   ` Daniel Vetter
2018-05-02 12:18     ` Daniel Vetter
2018-05-02 12:41     ` Christoph Hellwig
2018-05-02 12:41       ` Christoph Hellwig
2018-05-02 14:31       ` Michel Dänzer
2018-05-02 16:21         ` Christoph Hellwig
2018-05-02 16:59           ` Michel Dänzer
2018-05-02 16:59             ` Michel Dänzer
2018-05-22 13:13             ` Christian König
2018-05-25  8:41               ` Christoph Hellwig
2018-05-25  8:41                 ` Christoph Hellwig
2018-05-25  8:41                 ` Michel Dänzer
2018-05-25  8:41                   ` Michel Dänzer
2018-05-02 12:42 ` Christoph Hellwig
2018-05-02 12:42   ` Christoph Hellwig
2018-05-10  0:49 [PATCH] swiotlb: fix " Prasanthi Chellakumar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.