All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Kevin Easton <kevin@guarana.org>
Cc: kvm@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	David Miller <davem@davemloft.net>
Subject: Re: [PATCH] vhost: make msg padding explicit
Date: Wed, 2 May 2018 16:36:37 +0300	[thread overview]
Message-ID: <20180502162932-mutt-send-email-mst__32213.6866198436$1525268095$gmane$org@kernel.org> (raw)
In-Reply-To: <20180502062809.GA14485@la.guarana.org>

On Wed, May 02, 2018 at 02:28:09AM -0400, Kevin Easton wrote:
> On Tue, May 01, 2018 at 02:05:51PM -0400, David Miller wrote:
> > From: "Michael S. Tsirkin" <mst@redhat.com>
> > Date: Tue, 1 May 2018 20:19:19 +0300
> > 
> > > On Tue, May 01, 2018 at 11:28:22AM -0400, David Miller wrote:
> > >> From: "Michael S. Tsirkin" <mst@redhat.com>
> > >> Date: Fri, 27 Apr 2018 19:02:05 +0300
> > >> 
> > >> > There's a 32 bit hole just after type. It's best to
> > >> > give it a name, this way compiler is forced to initialize
> > >> > it with rest of the structure.
> > >> > 
> > >> > Reported-by: Kevin Easton <kevin@guarana.org>
> > >> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > >> 
> > >> Michael, will you be sending this directly to Linus or would you like
> > >> me to apply it to net or net-next?
> > >> 
> > >> Thanks.
> > > 
> > > I'd prefer you to apply it for net and cc stable if possible.
> > 
> > Ok, applied, and added to my -stable submission queue.
> 
> Hold on, this patch changes the layout for i386 (where there is
> no padding at all).  And it's part of UAPI.
> 
>     - Kevin
> 
> > 

Ouch.  True - and in particular the 32 bit ABI on 64 bit kernels doesn't
work at all. Hmm. It's relatively new and maybe there aren't any 32 bit
users yet. Thoughts?

-- 
MST

  reply	other threads:[~2018-05-02 13:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27 16:02 [PATCH] vhost: make msg padding explicit Michael S. Tsirkin
2018-04-30  1:34 ` David Miller
2018-04-30  1:34 ` David Miller
2018-05-01 15:28 ` David Miller
2018-05-01 17:19   ` Michael S. Tsirkin
2018-05-01 17:19   ` Michael S. Tsirkin
2018-05-01 18:05     ` David Miller
2018-05-01 18:05     ` David Miller
2018-05-02  6:28       ` Kevin Easton
2018-05-02 13:36         ` Michael S. Tsirkin [this message]
2018-05-02 13:36         ` Michael S. Tsirkin
2018-05-02 14:04           ` David Miller
2018-05-02 14:04             ` David Miller
2018-05-02 14:19             ` Michael S. Tsirkin
2018-05-02 14:19               ` Michael S. Tsirkin
2018-05-02 14:40               ` Kevin Easton
2018-05-01 15:28 ` David Miller
2018-04-27 16:02 Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20180502162932-mutt-send-email-mst__32213.6866198436$1525268095$gmane$org@kernel.org' \
    --to=mst@redhat.com \
    --cc=davem@davemloft.net \
    --cc=kevin@guarana.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.