From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH] drm/i915: Wait for PSR exit before checking for vblank evasion for an atomic update Date: Wed, 2 May 2018 13:04:06 -0700 Message-ID: <20180502200406.GA3617@intel.com> References: <20180430040018.79272-1-tarun.vyas@intel.com> <20180430171933.GI3617@intel.com> <20180502181913.GA14677@otc-chromeosbuild-5> <20180502185143.GN23723@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id CDE986E699 for ; Wed, 2 May 2018 20:04:05 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180502185143.GN23723@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Deak@otc-chromeosbuild-5, intel-gfx@lists.freedesktop.org, Pandiyan@otc-chromeosbuild-5, Dhinakaran List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXkgMDIsIDIwMTggYXQgMDk6NTE6NDNQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFdlZCwgTWF5IDAyLCAyMDE4IGF0IDExOjE5OjE0QU0gLTA3MDAsIFRhcnVu IFZ5YXMgd3JvdGU6Cj4gPiBPbiBNb24sIEFwciAzMCwgMjAxOCBhdCAxMDoxOTozM0FNIC0wNzAw LCBSb2RyaWdvIFZpdmkgd3JvdGU6Cj4gPiA+IE9uIFN1biwgQXByIDI5LCAyMDE4IGF0IDA5OjAw OjE4UE0gLTA3MDAsIFRhcnVuIFZ5YXMgd3JvdGU6Cj4gPiA+ID4gRnJvbTogVGFydW4gPHRhcnVu LnZ5YXNAaW50ZWwuY29tPgo+ID4gPiA+IAo+ID4gPiA+IFRoZSBQSVBFRFNMIGZyZWV6ZXMgb24g UFNSIGVudHJ5IGFuZCBpZiBQU1IgaGFzbid0IGZ1bGx5IGV4aXRlZCwgdGhlbgo+ID4gPiA+IHRo ZSBwaXBlX3VwZGF0ZV9zdGFydCBjYWxsIHNjaGVkdWxlcyBpdHNlbGYgb3V0IHRvIGNoZWNrIGJh Y2sgbGF0ZXIuCj4gPiA+ID4gCj4gPiA+ID4gT24gQ2hyb21lT1MtNC40IGtlcm5lbCwgd2hpY2gg aXMgZmFpcmx5IHVwLXRvLWRhdGUgdy5yLnQgZHJtL2k5MTUgYnV0Cj4gPiA+ID4gbGFncyB3LnIu dCBjb3JlIGtlcm5lbCBjb2RlLCBob3QgcGx1Z2dpbmcgYW4gZXh0ZXJuYWwgZGlzcGxheSB0cmln Z2Vycwo+ID4gPiA+IHRvbnMgb2YgInBvdGVudGlhbCBhdG9taWMgdXBkYXRlIGVycm9ycyIgaW4g dGhlIGRtZXNnLCBvbiAqcGlwZSBBKi4gQQo+ID4gPiA+IGNsb3NlciBhbmFseXNpcyByZXZlYWxz IHRoYXQgd2UgdHJ5IHRvIHJlYWQgdGhlIHNjYW5saW5lIDMgdGltZXMgYW5kCj4gPiA+ID4gZXZl bnR1YWxseSB0aW1lb3V0LCBiL2MgUFNSIGhhc24ndCBleGl0ZWQgZnVsbHkgbGVhZGluZyB0byBh IFBJUEVEU0wKPiA+ID4gPiBzdHVjayBAIDE1OTkuIFRoaXMgaXNzdWUgaXMgbm90IHNlZW4gb24g dXBzdHJlYW0ga2VybmVscywgYi9jIGZvciAqc29tZSoKPiA+ID4gPiByZWFzb24gd2UgbG9vcCBp bnNpZGUgaW50ZWxfcGlwZV91cGRhdGUgc3RhcnQgZm9yIH4yKyBtc2VjIHdoaWNoIGluIHRoaXMK PiA+ID4gPiBjYXNlIGlzIG1vcmUgdGhhbiBlbm91Z2ggdG8gZXhpdCBQU1IgZnVsbHksIGhlbmNl IGFuICp1bnN0dWNrKiBQSVBFRFNMCj4gPiA+ID4gY291bnRlciwgaGVuY2Ugbm8gZXJyb3IuIE9u IHRoZSBvdGhlciBoYW5kLCB0aGUgQ2hyb21lT1Mga2VybmVsIHNwZW5kcwo+ID4gPiA+IH4xLjEg bXNlYyBsb29waW5nIGluc2lkZSBpbnRlbF9waXBlX3VwZGF0ZV9zdGFydCBhbmQgaGVuY2UgZXJy b3JzIG91dAo+ID4gPiA+IGIvYyB0aGUgc291cmNlIGlzIHN0aWxsIGluIFBTUi4KPiA+ID4gPiAK PiA+ID4gPiBSZWdhcmRsZXNzLCB3ZSBzaG91bGQgd2FpdCBmb3IgUFNSIGV4aXQgKGlmIFBTUiBp cyBzdXBwb3J0ZWQgYW5kIGFjdGl2ZQo+ID4gPiA+IG9uIHRoZSBjdXJyZW50IHBpcGUpIGJlZm9y ZSByZWFkaW5nIHRoZSBQSVBFRFNMLCBiL2MgaWYgd2UgaGF2ZW4ndAo+ID4gPiA+IGZ1bGx5IGV4 aXRlZCBQU1IsIHRoZW4gY2hlY2tpbmcgZm9yIHZibGFuayBldmFzaW9uIGlzbid0IGFjdHVhbGx5 Cj4gPiA+ID4gYXBwbGljYWJsZS4KPiA+ID4gPiAKPiA+ID4gPiBUaGlzIHNjZW5hcmlvIGFwcGxp ZXMgdG8gYSBjb25maWd1cmF0aW9uIHdpdGggYW4gYWRkaXRpb25hbCBwaXBlLAo+ID4gPiA+IGFz IG9mIG5vdy4KPiA+ID4gCj4gPiA+IEkgaG9uZXN0bHkgYmVsaWV2ZSB5b3UgcGlja2luZyB0aGUg d3JvbmcgY3VscHJpdCBoZXJlLiBCeSAiY29pbmNpZGVuY2UiLgo+ID4gPiBQU1Igd2lsbCBhbGxv dyBEQyBzdGF0ZSB3aXRoIHNjcmVlbiBvbiBhbmQgREMgc3RhdGUgd2lsbCBtZXNzIHVwIHdpdGgg YWxsCj4gPiA+IHJlZ2lzdGVycyByZWFkcy4uLi4KPiA+ID4gCj4gPiA+IHByb2JhYmx5IHdoYXQg eW91IGFyZSBtaXNzaW5nIHlvdSB5b3VyIGtlcm5lbCBpcyBzb21lIHBvd2VyIGRvbWFpbgo+ID4g PiBncmFiIHRoYXQgd291bGQga2VlcCBEQ19PRkYgYW5kIGNvbnNlcXVlbnRseSBhIHNhbmUgcmVh ZCBvZiB0aGVzZQo+ID4gPiByZWdpc3RlcnMuCj4gPiA+IAo+ID4gPiBNYXliZSBJbXJlIGhhcyBh IHF1aWNrIGlkZWEgb2Ygd2hhdCB5b3UgY291bGQgYmUgbWlzc2luZyBvbiB5b3VyIGtlcm5lbAo+ ID4gPiB0aGF0IHdlIGFscmVhZHkgaGF2ZSBvbiB1cHN0cmVhbSBvbmUuCj4gPiA+IAo+ID4gPiBU aGFua3MsCj4gPiA+IFJvZHJpZ28uCj4gPiA+Cj4gPiBUaGFua3MgZm9yIHRoZSBxdWljayByZXNw b25zZSBSb2RyaWdvICEKPiA+IFNvbWUga2V5IG9ic2VydmF0aW9ucyBiYXNlZCBvbiBteSBleHBl cmltZW50cyBzbyBmYXI6Cj4gPiAgICAgICAgZm9yICg7OykgeyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCj4gPiAgICAgICAg ICAgICAgICAgLyogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgCj4gPiAgICAgICAgICAgICAgICAgICogcHJlcGFyZV90b193YWl0 KCkgaGFzIGEgbWVtb3J5IGJhcnJpZXIsIHdoaWNoIGd1YXJhbnRlZXMgICAgICAgCj4gPiAgICAg ICAgICAgICAgICAgICogb3RoZXIgQ1BVcyBjYW4gc2VlIHRoZSB0YXNrIHN0YXRlIHVwZGF0ZSBi eSB0aGUgdGltZSB3ZSAgICAgICAgCj4gPiAgICAgICAgICAgICAgICAgICogcmVhZCB0aGUgc2Nh bmxpbmUuICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCj4gPiAg ICAgICAgICAgICAgICAgICovICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgCj4gPiAgICAgICAgICAgICAgICAgcHJlcGFyZV90b193 YWl0KHdxLCAmd2FpdCwgVEFTS19VTklOVEVSUlVQVElCTEUpOyAgICAgICAgICAgICAgICAgCj4g PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgCj4gPiAgICAgICAgICAgICAgICAgc2NhbmxpbmUg PSBpbnRlbF9nZXRfY3J0Y19zY2FubGluZShjcnRjKTsgICAgICAgICAgICAgICAgICAgICAgICAg Cj4gPiAgICAgICAgICAgICAgICAgaWYgKHNjYW5saW5lIDwgbWluIHx8IHNjYW5saW5lID4gbWF4 KSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCj4gPiAgICAgICAgICAgICAgICAgICAgICAg ICBicmVhazsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCj4gPiAgICAgICAgICAgICAgICAgaWYg KHRpbWVvdXQgPD0gMCkgeyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICBEUk1fRVJST1IoIlBvdGVudGlhbCBh dG9taWMgdXBkYXRlIGZhaWx1cmUgb24gcGlwZSAlY1xuIiwgCj4gPiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgcGlwZV9uYW1lKGNydGMtPnBpcGUpKTsgICAgICAgICAgICAgICAg ICAgICAgICAgCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCj4gPiAgICAgICAgICAgICAg ICAgfSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCj4gPiAgICAgICAgICAg ICAgICAgbG9jYWxfaXJxX2VuYWJsZSgpOyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCj4gPiAgICAgICAg ICAgICAgICAgdGltZW91dCA9IHNjaGVkdWxlX3RpbWVvdXQodGltZW91dCk7ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCj4gPiAgICAg ICAgICAgICAgICAgbG9jYWxfaXJxX2Rpc2FibGUoKTsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgCj4gPiAgICAgICAgIH0KPiA+IDEuIEluIHRoZSBhYm92ZSBs b29wIGluc2lkZSBwaXBlX3VwZGF0ZV9zdGFydCwgdGhlICpmaXJzdCB0aW1lKiwgd2UgcmVhZCB0 aGUgUElQRURTTCwgd2l0aCBQU1IxIGFuZCBleHRlcm5hbCBkaXNwbGF5IGNvbm5lY3RlZCwgaXQg YWx3YXlzIHJlYWRzIDE1OTksIGZvciAqYm90aCogdGhlIGtlcm5lbHModXBzdHJlYW0gYW5kIENo cm9tZU9TLTQuNCkgLiBUaGUgUFNSX1NUQVRVUyBhbHNvIHJlYWRzIHRoZSBleGFjdCBzYW1lIGZv ciAqYm90aCoga2VybmVscyBhbmQgc2hvd3MgdGhhdCB3ZSBoYXZlbid0ICpmdWxseSogZXhpdGVk IFBTUi4KPiA+IAo+ID4gMi4gVGhlIGRpZmZlcmVuY2UgYmV0d2VlbiB0aGUgdHdvIGtlcm5lbHMg Y29tZXMgYWZ0ZXIgdGhpcyBmaXJzdCByZWFkIG9mIHRoZSBQSVBFRFNMLiBDaHJvbWVPUy00LjQg c3BlbmRzIH4xIG1zZWMgaW5zaWRlIHRoYXQgbG9vcCBhbmQgdXBzdHJlYW0gc3BlbmRzIH4ybXNl Yy4gSSBzdXNwZWN0IHRoYXQgaXQgaXMgYmVjYXVzZSBvZiB0aGUgc2NoZWR1bGluZyBjaGFuZ2Vz IGJldHdlZW4gdGhlIHR3byBrZXJuZWxzLCBiL2MgSSBjYW4ndCBmaW5kIGFueSBpOTE1IHNwZWNp ZmljIGNvZGUgcnVubmluZyBpbiB0aGF0IGxvb3AsIGV4Y2VwdCBmb3IgdmJsYW5rIHByb2Nlc3Np bmcuCj4gPiAKPiA+IDMuIFNvIHRvIHN1bW1hcml6ZSBpdCwgYm90aCB0aGUga2VybmVscyBhcmUg aW4gdGhlIHNhbWUgc3RhdGUgdy5yLnQgUFNSIGFuZCBQSVBFRFNMIHZhbHVlIHdoZW4gdGhleSBy ZWFkIHRoZSBQSVBFRFNMIGZvciB0aGUgZmlyc3QgdGltZSBpbnNpZGUgdGhlIGxvb3AuICpXaGVu KiB0aGUga2VybmVscyAqdHJhbnNpdGlvbiogdG8gYSAqZnVsbCBQU1IgZXhpdCogaXMgd2hhdCBp cyBkaWZmZXJpbmcuCgpPaCEgU28geW91IHJlYWxseSBhcmUgZ2V0dGluZyByZWxpYWJsZSBjb3Vu dGVycy4uLi4KCj4gPiAKPiA+IE15IHJhdGlvbmFsZSBmb3IgdGhpcyBwYXRjaCBpcyB0aGF0LCB0 aGUgcGlwZV91cGRhdGVfc3RhcnQgZnVuY3Rpb24gaXMgbWVhbnQgdG8gZXZhZGUgMTAwIHVzZWMg YmVmb3JlIGEgdmJsYW5rLCBidXQsICppZiogd2UgaGF2ZW4ndCAqZnVsbHkqIGV4aXRlZCBQU1Ig KHdoaWNoIGlzIHRydWUgZm9yIGJvdGggdGhlIGtlcm5lbHMgZm9yIHRoZSBmaXJzdCBQSVBFRFNM IHJlYWQpLCB0aGVuIHZibGFuayBldmFzaW9uIGlzICpub3QgYXBwbGljYWJsZSogYi9jIHRoZSBQ SVBFRFNMIHdpbGwgYmUgbWVzc2VkIHVwLiBTbyB3ZSBzaG91bGRuJ3QgYm90aGVyIGV2YWRpbmcg dmJsYW5rIHVudGlsIHdlIGhhdmUgZnVsbHkgZXhpdGVkIFBTUi4KPiAKPiBZZWFoLCBJIHRoaW5r IHRoaXMgaXMgdGhlIHJpZ2h0IGRpcmVjdGlvbi4gVGhlIHByb2JsZW0gcmVhbGx5IGlzIHRoZQo+ IGV4dHJhIHZibGFuayBwdWxzZSB0aGF0IHRoZSBoYXJkd2FyZSBnZW5lcmF0ZXMgKG9yIGF0IGxl YXN0IGNhbgo+IGdlbmVyYXRlIGRlcGVuZGluZyBvbiBhIGNoaWNrZW4gYml0KSB3aGVuIGl0IGV4 aXRzIFBTUi4gV2UgaGF2ZSBubwo+IGNvbnRyb2wgb3ZlciB3aGVuIHRoYXQgaGFwcGVucyBhbmQg aGVuY2Ugd2UgaGF2ZSBubyBjb250cm9sIG92ZXIgd2hlbgo+IHRoZSByZWdpc3RlcnMgZ2V0IGxh dGNoZWQuIEFuZCB5ZXQgd2Ugc3RpbGwgaGF2ZSB0byBzb21laG93IHByZXZlbnQKPiB0aGUgcmVn aXN0ZXIgbGF0Y2hpbmcgZnJvbSBvY2N1cnJpbmcgd2hpbGUgd2UncmUgaW4gbWlkZGxlIG9mCj4g cmVwcm9ncmFtbWluZyB0aGVtLgoKSSBzZWUgdGhlIHByb2JsZW0gbm93LiBUaGFua3MgZm9yIHRo ZSBleHBsYW5hdGlvbi4KCj4gCj4gVGhlcmUgYXJlIGEgY291cGxlIG9mIHdheXMgdG8gYXZvaWQg dGhpczoKPiAxKSBTZXQgdGhlIGNoaWNrZW4gYml0IHNvIHRoYXQgd2UgZG9uJ3QgZ2V0IHRoZSB2 YmxhbmsgcHVsc2UuIFRoZQo+ICAgIHBpcGUgc2hvdWxkIHJlc3RhcnQgZnJvbSB0aGUgdmJsYW5r IHN0YXJ0LCBzbyB3ZSB3b3VsZCBoYXZlIG9uZQo+ICAgIGZ1bGwgZnJhbWUgdG8gcmVwcm9nYW0g dGhlIHJlZ2lzdGVycy4gSG93dmVyIElJUkMgREsgdG9sZCBtZQo+ICAgIHRoZXJlIGlzIG5vIHdh eSB0byBmdWxseSBlbGltaW5hdGUgaXQgaW4gYWxsIGNhc2VzIHNvIHRoaXMKPiAgICBvcHRpb24g aXMgcHJvYmFibHkgb3V0LiBUaGVyZSB3YXMgYWxzbyBzb21lIGltcGxpY2F0aW9uIGZvciBGQkMK PiAgICB3aGljaCBJIGFscmVhZHkgZm9yZ290Lgo+IDIpIE1ha2Ugc3VyZSB3ZSd2ZSBleGl0ZWQg UFNSIGJlZm9yZSByZXBncm9nYW1taW5nIHRoZSByZWdpc3RlcnMKPiAgICAoaWUuIHdoYXQgeW91 IGRvKS4KPiAzKSBVc2UgdGhlIERPVUJMRV9CVUZGRVJfQ1RMIHRvIHByZXZlbnQgdGhlIGV4dHJh IHZibGFuayBwdWxzZSBmcm9tCj4gICAgbGF0Y2hpbmcgdGhlIHJlZ2lzdGVycyB3aGlsZSB3ZSdy ZSBzdGlsbCByZXByb2dyYW1taW5nIHRoZW0uCj4gICAgVGhpcyBmZWF0dXJlIG9ubHkgZXhpc3Rz IG9uIFNLTCsgc28gaXMgbm90IGEgc29sdXRpb24gZm9yCj4gICAgSFNXL0JEVy4gQnV0IG1heWJl IEhTVy9CRFcgZGlkbid0IGV2ZW4gaGF2ZSB0aGUgZXh0cmEgdmJsYW5rCj4gICAgcHVsc2U/Cj4g Cj4gT3B0aW9uIDIpIGRvZXMgcHJvdmlkZSBhIGNvbnNpc3RlbnQgYmVoYXZpb3VyIG9uIGFsbCBw bGF0Zm9ybXMsIHNvIEkKPiBkbyBraW5kYSBsaWtlIGl0LiBJdCBhbHNvIGF2b2lkcyBhIGJpZ2dl ciByZXdvcmQgb24gYWNjb3VudCBvZiB0aGUKPiBET1VCTEVfQlVGRkVSX0NUTC4gSSBkbyB0aGlu ayB3ZSdsbCBoYXZlIHRvIHN0YXJ0IHVzaW5nCj4gRE9VQkxFX0JVRkZFUl9DVEwgYW55d2F5IGR1 ZSB0byBvdGhlciBpc3N1ZXMsIGJ1dCBhdCBsZWFzdCB0aGlzIHdheQo+IHdlIGRvbid0IGJsb2Nr IFBTUiBwcm9ncmVzcyBvbiB0aGF0IHdvcmsuCgpNeSB2b3RlIGlzIGZvciB0aGUgb3B0aW9uIDIu IFNlZW1zIG1vcmUgc3RyYWlnaGZvcndhcmQgYW5kIG1vcmUgYnJvYWQuCgpESz8KCk15IG9ubHkg cmVxdWVzdCBvbiB0aGUgcGF0Y2ggaXRzZWxmIHdvdWxkIGJlIHRvIGNyZWF0ZSBhIGZ1bmN0aW9u Cm9uIGludGVsX3Bzci5jIGludGVsX3Bzcl93YWl0X2Zvcl9pZGxlLi4uIG9yIHNvbWV0aGluZyBs aWtlIHRoaXMKYW5kIHB1dCB0aGUgcmVnaXN0ZXIgd2FpdCBsb2dpYyBpbnNpZGUgaXQgaW5zdGVh ZCBvZiBzcHJlYWRpbmcKdGhlIHBzciBjb2RlIGFyb3VuZC4KClRoYW5rcywKUm9kcmlnby4KCj4g Cj4gLS0gCj4gVmlsbGUgU3lyasOkbMOkCj4gSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==