From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tarun Vyas Subject: Re: [PATCH] drm/i915: Wait for PSR exit before checking for vblank evasion for an atomic update Date: Wed, 2 May 2018 15:31:15 -0700 Message-ID: <20180502223115.GA29751@otc-chromeosbuild-5> References: <20180430040018.79272-1-tarun.vyas@intel.com> <20180430171933.GI3617@intel.com> <20180502181913.GA14677@otc-chromeosbuild-5> <20180502185143.GN23723@intel.com> <20180502200406.GA3617@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6215A6E58B for ; Wed, 2 May 2018 22:31:16 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180502200406.GA3617@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Vivi, Rodrigo" Cc: Deak@otc-chromeosbuild-5, Pandiyan@otc-chromeosbuild-5, Dhinakaran , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXkgMDIsIDIwMTggYXQgMDE6MDQ6MDZQTSAtMDcwMCwgVml2aSwgUm9kcmlnbyB3 cm90ZToKPiBPbiBXZWQsIE1heSAwMiwgMjAxOCBhdCAwOTo1MTo0M1BNICswMzAwLCBWaWxsZSBT eXJqw6Rsw6Qgd3JvdGU6Cj4gPiBPbiBXZWQsIE1heSAwMiwgMjAxOCBhdCAxMToxOToxNEFNIC0w NzAwLCBUYXJ1biBWeWFzIHdyb3RlOgo+ID4gPiBPbiBNb24sIEFwciAzMCwgMjAxOCBhdCAxMDox OTozM0FNIC0wNzAwLCBSb2RyaWdvIFZpdmkgd3JvdGU6Cj4gPiA+ID4gT24gU3VuLCBBcHIgMjks IDIwMTggYXQgMDk6MDA6MThQTSAtMDcwMCwgVGFydW4gVnlhcyB3cm90ZToKPiA+ID4gPiA+IEZy b206IFRhcnVuIDx0YXJ1bi52eWFzQGludGVsLmNvbT4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBUaGUg UElQRURTTCBmcmVlemVzIG9uIFBTUiBlbnRyeSBhbmQgaWYgUFNSIGhhc24ndCBmdWxseSBleGl0 ZWQsIHRoZW4KPiA+ID4gPiA+IHRoZSBwaXBlX3VwZGF0ZV9zdGFydCBjYWxsIHNjaGVkdWxlcyBp dHNlbGYgb3V0IHRvIGNoZWNrIGJhY2sgbGF0ZXIuCj4gPiA+ID4gPgo+ID4gPiA+ID4gT24gQ2hy b21lT1MtNC40IGtlcm5lbCwgd2hpY2ggaXMgZmFpcmx5IHVwLXRvLWRhdGUgdy5yLnQgZHJtL2k5 MTUgYnV0Cj4gPiA+ID4gPiBsYWdzIHcuci50IGNvcmUga2VybmVsIGNvZGUsIGhvdCBwbHVnZ2lu ZyBhbiBleHRlcm5hbCBkaXNwbGF5IHRyaWdnZXJzCj4gPiA+ID4gPiB0b25zIG9mICJwb3RlbnRp YWwgYXRvbWljIHVwZGF0ZSBlcnJvcnMiIGluIHRoZSBkbWVzZywgb24gKnBpcGUgQSouIEEKPiA+ ID4gPiA+IGNsb3NlciBhbmFseXNpcyByZXZlYWxzIHRoYXQgd2UgdHJ5IHRvIHJlYWQgdGhlIHNj YW5saW5lIDMgdGltZXMgYW5kCj4gPiA+ID4gPiBldmVudHVhbGx5IHRpbWVvdXQsIGIvYyBQU1Ig aGFzbid0IGV4aXRlZCBmdWxseSBsZWFkaW5nIHRvIGEgUElQRURTTAo+ID4gPiA+ID4gc3R1Y2sg QCAxNTk5LiBUaGlzIGlzc3VlIGlzIG5vdCBzZWVuIG9uIHVwc3RyZWFtIGtlcm5lbHMsIGIvYyBm b3IgKnNvbWUqCj4gPiA+ID4gPiByZWFzb24gd2UgbG9vcCBpbnNpZGUgaW50ZWxfcGlwZV91cGRh dGUgc3RhcnQgZm9yIH4yKyBtc2VjIHdoaWNoIGluIHRoaXMKPiA+ID4gPiA+IGNhc2UgaXMgbW9y ZSB0aGFuIGVub3VnaCB0byBleGl0IFBTUiBmdWxseSwgaGVuY2UgYW4gKnVuc3R1Y2sqIFBJUEVE U0wKPiA+ID4gPiA+IGNvdW50ZXIsIGhlbmNlIG5vIGVycm9yLiBPbiB0aGUgb3RoZXIgaGFuZCwg dGhlIENocm9tZU9TIGtlcm5lbCBzcGVuZHMKPiA+ID4gPiA+IH4xLjEgbXNlYyBsb29waW5nIGlu c2lkZSBpbnRlbF9waXBlX3VwZGF0ZV9zdGFydCBhbmQgaGVuY2UgZXJyb3JzIG91dAo+ID4gPiA+ ID4gYi9jIHRoZSBzb3VyY2UgaXMgc3RpbGwgaW4gUFNSLgo+ID4gPiA+ID4KPiA+ID4gPiA+IFJl Z2FyZGxlc3MsIHdlIHNob3VsZCB3YWl0IGZvciBQU1IgZXhpdCAoaWYgUFNSIGlzIHN1cHBvcnRl ZCBhbmQgYWN0aXZlCj4gPiA+ID4gPiBvbiB0aGUgY3VycmVudCBwaXBlKSBiZWZvcmUgcmVhZGlu ZyB0aGUgUElQRURTTCwgYi9jIGlmIHdlIGhhdmVuJ3QKPiA+ID4gPiA+IGZ1bGx5IGV4aXRlZCBQ U1IsIHRoZW4gY2hlY2tpbmcgZm9yIHZibGFuayBldmFzaW9uIGlzbid0IGFjdHVhbGx5Cj4gPiA+ ID4gPiBhcHBsaWNhYmxlLgo+ID4gPiA+ID4KPiA+ID4gPiA+IFRoaXMgc2NlbmFyaW8gYXBwbGll cyB0byBhIGNvbmZpZ3VyYXRpb24gd2l0aCBhbiBhZGRpdGlvbmFsIHBpcGUsCj4gPiA+ID4gPiBh cyBvZiBub3cuCj4gPiA+ID4KPiA+ID4gPiBJIGhvbmVzdGx5IGJlbGlldmUgeW91IHBpY2tpbmcg dGhlIHdyb25nIGN1bHByaXQgaGVyZS4gQnkgImNvaW5jaWRlbmNlIi4KPiA+ID4gPiBQU1Igd2ls bCBhbGxvdyBEQyBzdGF0ZSB3aXRoIHNjcmVlbiBvbiBhbmQgREMgc3RhdGUgd2lsbCBtZXNzIHVw IHdpdGggYWxsCj4gPiA+ID4gcmVnaXN0ZXJzIHJlYWRzLi4uLgo+ID4gPiA+Cj4gPiA+ID4gcHJv YmFibHkgd2hhdCB5b3UgYXJlIG1pc3NpbmcgeW91IHlvdXIga2VybmVsIGlzIHNvbWUgcG93ZXIg ZG9tYWluCj4gPiA+ID4gZ3JhYiB0aGF0IHdvdWxkIGtlZXAgRENfT0ZGIGFuZCBjb25zZXF1ZW50 bHkgYSBzYW5lIHJlYWQgb2YgdGhlc2UKPiA+ID4gPiByZWdpc3RlcnMuCj4gPiA+ID4KPiA+ID4g PiBNYXliZSBJbXJlIGhhcyBhIHF1aWNrIGlkZWEgb2Ygd2hhdCB5b3UgY291bGQgYmUgbWlzc2lu ZyBvbiB5b3VyIGtlcm5lbAo+ID4gPiA+IHRoYXQgd2UgYWxyZWFkeSBoYXZlIG9uIHVwc3RyZWFt IG9uZS4KPiA+ID4gPgo+ID4gPiA+IFRoYW5rcywKPiA+ID4gPiBSb2RyaWdvLgo+ID4gPiA+Cj4g PiA+IFRoYW5rcyBmb3IgdGhlIHF1aWNrIHJlc3BvbnNlIFJvZHJpZ28gIQo+ID4gPiBTb21lIGtl eSBvYnNlcnZhdGlvbnMgYmFzZWQgb24gbXkgZXhwZXJpbWVudHMgc28gZmFyOgo+ID4gPiAgICAg ICAgZm9yICg7Oykgewo+ID4gPiAgICAgICAgICAgICAgICAgLyoKPiA+ID4gICAgICAgICAgICAg ICAgICAqIHByZXBhcmVfdG9fd2FpdCgpIGhhcyBhIG1lbW9yeSBiYXJyaWVyLCB3aGljaCBndWFy YW50ZWVzCj4gPiA+ICAgICAgICAgICAgICAgICAgKiBvdGhlciBDUFVzIGNhbiBzZWUgdGhlIHRh c2sgc3RhdGUgdXBkYXRlIGJ5IHRoZSB0aW1lIHdlCj4gPiA+ICAgICAgICAgICAgICAgICAgKiBy ZWFkIHRoZSBzY2FubGluZS4KPiA+ID4gICAgICAgICAgICAgICAgICAqLwo+ID4gPiAgICAgICAg ICAgICAgICAgcHJlcGFyZV90b193YWl0KHdxLCAmd2FpdCwgVEFTS19VTklOVEVSUlVQVElCTEUp Owo+ID4gPgo+ID4gPiAgICAgICAgICAgICAgICAgc2NhbmxpbmUgPSBpbnRlbF9nZXRfY3J0Y19z Y2FubGluZShjcnRjKTsKPiA+ID4gICAgICAgICAgICAgICAgIGlmIChzY2FubGluZSA8IG1pbiB8 fCBzY2FubGluZSA+IG1heCkKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4g PiA+Cj4gPiA+ICAgICAgICAgICAgICAgICBpZiAodGltZW91dCA8PSAwKSB7Cj4gPiA+ICAgICAg ICAgICAgICAgICAgICAgICAgIERSTV9FUlJPUigiUG90ZW50aWFsIGF0b21pYyB1cGRhdGUgZmFp bHVyZSBvbiBwaXBlICVjXG4iLAo+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgcGlwZV9uYW1lKGNydGMtPnBpcGUpKTsKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAg YnJlYWs7Cj4gPiA+ICAgICAgICAgICAgICAgICB9Cj4gPiA+Cj4gPiA+ICAgICAgICAgICAgICAg ICBsb2NhbF9pcnFfZW5hYmxlKCk7Cj4gPiA+Cj4gPiA+ICAgICAgICAgICAgICAgICB0aW1lb3V0 ID0gc2NoZWR1bGVfdGltZW91dCh0aW1lb3V0KTsKPiA+ID4KPiA+ID4gICAgICAgICAgICAgICAg IGxvY2FsX2lycV9kaXNhYmxlKCk7Cj4gPiA+ICAgICAgICAgfQo+ID4gPiAxLiBJbiB0aGUgYWJv dmUgbG9vcCBpbnNpZGUgcGlwZV91cGRhdGVfc3RhcnQsIHRoZSAqZmlyc3QgdGltZSosIHdlIHJl YWQgdGhlIFBJUEVEU0wsIHdpdGggUFNSMSBhbmQgZXh0ZXJuYWwgZGlzcGxheSBjb25uZWN0ZWQs IGl0IGFsd2F5cyByZWFkcyAxNTk5LCBmb3IgKmJvdGgqIHRoZSBrZXJuZWxzKHVwc3RyZWFtIGFu ZCBDaHJvbWVPUy00LjQpIC4gVGhlIFBTUl9TVEFUVVMgYWxzbyByZWFkcyB0aGUgZXhhY3Qgc2Ft ZSBmb3IgKmJvdGgqIGtlcm5lbHMgYW5kIHNob3dzIHRoYXQgd2UgaGF2ZW4ndCAqZnVsbHkqIGV4 aXRlZCBQU1IuCj4gPiA+Cj4gPiA+IDIuIFRoZSBkaWZmZXJlbmNlIGJldHdlZW4gdGhlIHR3byBr ZXJuZWxzIGNvbWVzIGFmdGVyIHRoaXMgZmlyc3QgcmVhZCBvZiB0aGUgUElQRURTTC4gQ2hyb21l T1MtNC40IHNwZW5kcyB+MSBtc2VjIGluc2lkZSB0aGF0IGxvb3AgYW5kIHVwc3RyZWFtIHNwZW5k cyB+Mm1zZWMuIEkgc3VzcGVjdCB0aGF0IGl0IGlzIGJlY2F1c2Ugb2YgdGhlIHNjaGVkdWxpbmcg Y2hhbmdlcyBiZXR3ZWVuIHRoZSB0d28ga2VybmVscywgYi9jIEkgY2FuJ3QgZmluZCBhbnkgaTkx NSBzcGVjaWZpYyBjb2RlIHJ1bm5pbmcgaW4gdGhhdCBsb29wLCBleGNlcHQgZm9yIHZibGFuayBw cm9jZXNzaW5nLgo+ID4gPgo+ID4gPiAzLiBTbyB0byBzdW1tYXJpemUgaXQsIGJvdGggdGhlIGtl cm5lbHMgYXJlIGluIHRoZSBzYW1lIHN0YXRlIHcuci50IFBTUiBhbmQgUElQRURTTCB2YWx1ZSB3 aGVuIHRoZXkgcmVhZCB0aGUgUElQRURTTCBmb3IgdGhlIGZpcnN0IHRpbWUgaW5zaWRlIHRoZSBs b29wLiAqV2hlbiogdGhlIGtlcm5lbHMgKnRyYW5zaXRpb24qIHRvIGEgKmZ1bGwgUFNSIGV4aXQq IGlzIHdoYXQgaXMgZGlmZmVyaW5nLgo+IAo+IE9oISBTbyB5b3UgcmVhbGx5IGFyZSBnZXR0aW5n IHJlbGlhYmxlIGNvdW50ZXJzLi4uLgo+IAo+ID4gPgo+ID4gPiBNeSByYXRpb25hbGUgZm9yIHRo aXMgcGF0Y2ggaXMgdGhhdCwgdGhlIHBpcGVfdXBkYXRlX3N0YXJ0IGZ1bmN0aW9uIGlzIG1lYW50 IHRvIGV2YWRlIDEwMCB1c2VjIGJlZm9yZSBhIHZibGFuaywgYnV0LCAqaWYqIHdlIGhhdmVuJ3Qg KmZ1bGx5KiBleGl0ZWQgUFNSICh3aGljaCBpcyB0cnVlIGZvciBib3RoIHRoZSBrZXJuZWxzIGZv ciB0aGUgZmlyc3QgUElQRURTTCByZWFkKSwgdGhlbiB2YmxhbmsgZXZhc2lvbiBpcyAqbm90IGFw cGxpY2FibGUqIGIvYyB0aGUgUElQRURTTCB3aWxsIGJlIG1lc3NlZCB1cC4gU28gd2Ugc2hvdWxk bid0IGJvdGhlciBldmFkaW5nIHZibGFuayB1bnRpbCB3ZSBoYXZlIGZ1bGx5IGV4aXRlZCBQU1Iu Cj4gPgo+ID4gWWVhaCwgSSB0aGluayB0aGlzIGlzIHRoZSByaWdodCBkaXJlY3Rpb24uIFRoZSBw cm9ibGVtIHJlYWxseSBpcyB0aGUKPiA+IGV4dHJhIHZibGFuayBwdWxzZSB0aGF0IHRoZSBoYXJk d2FyZSBnZW5lcmF0ZXMgKG9yIGF0IGxlYXN0IGNhbgo+ID4gZ2VuZXJhdGUgZGVwZW5kaW5nIG9u IGEgY2hpY2tlbiBiaXQpIHdoZW4gaXQgZXhpdHMgUFNSLiBXZSBoYXZlIG5vCj4gPiBjb250cm9s IG92ZXIgd2hlbiB0aGF0IGhhcHBlbnMgYW5kIGhlbmNlIHdlIGhhdmUgbm8gY29udHJvbCBvdmVy IHdoZW4KPiA+IHRoZSByZWdpc3RlcnMgZ2V0IGxhdGNoZWQuIEFuZCB5ZXQgd2Ugc3RpbGwgaGF2 ZSB0byBzb21laG93IHByZXZlbnQKPiA+IHRoZSByZWdpc3RlciBsYXRjaGluZyBmcm9tIG9jY3Vy cmluZyB3aGlsZSB3ZSdyZSBpbiBtaWRkbGUgb2YKPiA+IHJlcHJvZ3JhbW1pbmcgdGhlbS4KPiAK PiBJIHNlZSB0aGUgcHJvYmxlbSBub3cuIFRoYW5rcyBmb3IgdGhlIGV4cGxhbmF0aW9uLgo+IAo+ ID4KPiA+IFRoZXJlIGFyZSBhIGNvdXBsZSBvZiB3YXlzIHRvIGF2b2lkIHRoaXM6Cj4gPiAxKSBT ZXQgdGhlIGNoaWNrZW4gYml0IHNvIHRoYXQgd2UgZG9uJ3QgZ2V0IHRoZSB2YmxhbmsgcHVsc2Uu IFRoZQo+ID4gICAgcGlwZSBzaG91bGQgcmVzdGFydCBmcm9tIHRoZSB2Ymxhbmsgc3RhcnQsIHNv IHdlIHdvdWxkIGhhdmUgb25lCj4gPiAgICBmdWxsIGZyYW1lIHRvIHJlcHJvZ2FtIHRoZSByZWdp c3RlcnMuIEhvd3ZlciBJSVJDIERLIHRvbGQgbWUKPiA+ICAgIHRoZXJlIGlzIG5vIHdheSB0byBm dWxseSBlbGltaW5hdGUgaXQgaW4gYWxsIGNhc2VzIHNvIHRoaXMKPiA+ICAgIG9wdGlvbiBpcyBw cm9iYWJseSBvdXQuIFRoZXJlIHdhcyBhbHNvIHNvbWUgaW1wbGljYXRpb24gZm9yIEZCQwo+ID4g ICAgd2hpY2ggSSBhbHJlYWR5IGZvcmdvdC4KPiA+IDIpIE1ha2Ugc3VyZSB3ZSd2ZSBleGl0ZWQg UFNSIGJlZm9yZSByZXBncm9nYW1taW5nIHRoZSByZWdpc3RlcnMKPiA+ICAgIChpZS4gd2hhdCB5 b3UgZG8pLgo+ID4gMykgVXNlIHRoZSBET1VCTEVfQlVGRkVSX0NUTCB0byBwcmV2ZW50IHRoZSBl eHRyYSB2YmxhbmsgcHVsc2UgZnJvbQo+ID4gICAgbGF0Y2hpbmcgdGhlIHJlZ2lzdGVycyB3aGls ZSB3ZSdyZSBzdGlsbCByZXByb2dyYW1taW5nIHRoZW0uCj4gPiAgICBUaGlzIGZlYXR1cmUgb25s eSBleGlzdHMgb24gU0tMKyBzbyBpcyBub3QgYSBzb2x1dGlvbiBmb3IKPiA+ICAgIEhTVy9CRFcu IEJ1dCBtYXliZSBIU1cvQkRXIGRpZG4ndCBldmVuIGhhdmUgdGhlIGV4dHJhIHZibGFuawo+ID4g ICAgcHVsc2U/Cj4gPgo+ID4gT3B0aW9uIDIpIGRvZXMgcHJvdmlkZSBhIGNvbnNpc3RlbnQgYmVo YXZpb3VyIG9uIGFsbCBwbGF0Zm9ybXMsIHNvIEkKPiA+IGRvIGtpbmRhIGxpa2UgaXQuIEl0IGFs c28gYXZvaWRzIGEgYmlnZ2VyIHJld29yZCBvbiBhY2NvdW50IG9mIHRoZQo+ID4gRE9VQkxFX0JV RkZFUl9DVEwuIEkgZG8gdGhpbmsgd2UnbGwgaGF2ZSB0byBzdGFydCB1c2luZwo+ID4gRE9VQkxF X0JVRkZFUl9DVEwgYW55d2F5IGR1ZSB0byBvdGhlciBpc3N1ZXMsIGJ1dCBhdCBsZWFzdCB0aGlz IHdheQo+ID4gd2UgZG9uJ3QgYmxvY2sgUFNSIHByb2dyZXNzIG9uIHRoYXQgd29yay4KPiAKPiBN eSB2b3RlIGlzIGZvciB0aGUgb3B0aW9uIDIuIFNlZW1zIG1vcmUgc3RyYWlnaGZvcndhcmQgYW5k IG1vcmUgYnJvYWQuCj4gCj4gREs/Cj4gCj4gTXkgb25seSByZXF1ZXN0IG9uIHRoZSBwYXRjaCBp dHNlbGYgd291bGQgYmUgdG8gY3JlYXRlIGEgZnVuY3Rpb24KPiBvbiBpbnRlbF9wc3IuYyBpbnRl bF9wc3Jfd2FpdF9mb3JfaWRsZS4uLiBvciBzb21ldGhpbmcgbGlrZSB0aGlzCj4gYW5kIHB1dCB0 aGUgcmVnaXN0ZXIgd2FpdCBsb2dpYyBpbnNpZGUgaXQgaW5zdGVhZCBvZiBzcHJlYWRpbmcKPiB0 aGUgcHNyIGNvZGUgYXJvdW5kLgo+IAo+IFRoYW5rcywKPiBSb2RyaWdvLgo+IAo+ID4KPiA+IC0t Cj4gPiBWaWxsZSBTeXJqw6Rsw6QKPiA+IEludGVsClRoYW5rcyBmb3IgdGhlIGNvbW1lbnRzLCBW aWxsZSBhbmQgUm9kcmlnby4gSSdsbCByZXdvcmsgdGhpcyB0byBtb3ZlIHRoZSB3YWl0IHRvIGlu dGVsX3Bzci5jLiBUaGVyZSBpcyBhIHBzcl93YWl0X2Zvcl9pZGxlKCkgaW4gdGhlcmUsIGJ1dCB0 aGVyZSBhcmUgc29tZSBQU1IgbG9ja3MgYmVpbmcgcGFzc2VkIGFyb3VuZCBpbnNpZGUgaXQgKGV2 ZW50dWFsbHkgcmVsZWFzZWQgYnkgdGhlIGNhbGxlcikuIEFsc28sdGhlIG1heCB0aW1lb3V0IHNw ZWNpZmllZCB0aGVyZSBpcyA1MCBtc2VjIHdoaWNoIG1pZ2h0IGJlIHdheSB0b28gbXVjaCA/CgpC ZXN0LApUYXJ1bgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK