All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next 0/2] Update csum tc action for batch operation.
@ 2018-05-01 14:17 Craig Dillabaugh
  2018-05-01 14:17 ` [PATCH net-next 1/2] net sched: Implemented get_fill_size routine for act_csum Craig Dillabaugh
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Craig Dillabaugh @ 2018-05-01 14:17 UTC (permalink / raw)
  To: davem; +Cc: netdev, jhs, xiyou.wangcong, Craig Dillabaugh

This patchset includes two patches the first updating act_csum.c 
to include the get_fill_size routine required for batch operation, and
the second including updated TDC tests for the feature.

Craig Dillabaugh (2):
  net sched: Implemented get_fill_size routine for act_csum.
  tc-testing: Updated csum action tests batch create w/wo cookies.

 net/sched/act_csum.c                               |  6 ++
 .../tc-testing/tc-tests/actions/csum.json          | 74 +++++++++++++++++++++-
 2 files changed, 78 insertions(+), 2 deletions(-)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH net-next 1/2] net sched: Implemented get_fill_size routine for act_csum.
  2018-05-01 14:17 [PATCH net-next 0/2] Update csum tc action for batch operation Craig Dillabaugh
@ 2018-05-01 14:17 ` Craig Dillabaugh
  2018-05-01 14:17 ` [PATCH net-next 2/2] tc-testing: Updated csum action tests batch create w/wo cookies Craig Dillabaugh
  2018-05-03 15:16 ` [PATCH net-next 0/2] Update csum tc action for batch operation David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: Craig Dillabaugh @ 2018-05-01 14:17 UTC (permalink / raw)
  To: davem; +Cc: netdev, jhs, xiyou.wangcong, Craig Dillabaugh

Signed-off-by: Craig Dillabaugh <cdillaba@mojatatu.com>
---
 net/sched/act_csum.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/net/sched/act_csum.c b/net/sched/act_csum.c
index 7e28b2c..b85e088 100644
--- a/net/sched/act_csum.c
+++ b/net/sched/act_csum.c
@@ -648,6 +648,11 @@ static int tcf_csum_search(struct net *net, struct tc_action **a, u32 index,
 	return tcf_idr_search(tn, a, index);
 }
 
+static size_t tcf_csum_get_fill_size(const struct tc_action *act)
+{
+	return nla_total_size(sizeof(struct tc_csum));
+}
+
 static struct tc_action_ops act_csum_ops = {
 	.kind		= "csum",
 	.type		= TCA_ACT_CSUM,
@@ -658,6 +663,7 @@ static int tcf_csum_search(struct net *net, struct tc_action **a, u32 index,
 	.cleanup	= tcf_csum_cleanup,
 	.walk		= tcf_csum_walker,
 	.lookup		= tcf_csum_search,
+	.get_fill_size  = tcf_csum_get_fill_size,
 	.size		= sizeof(struct tcf_csum),
 };
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH net-next 2/2] tc-testing: Updated csum action tests batch create w/wo cookies.
  2018-05-01 14:17 [PATCH net-next 0/2] Update csum tc action for batch operation Craig Dillabaugh
  2018-05-01 14:17 ` [PATCH net-next 1/2] net sched: Implemented get_fill_size routine for act_csum Craig Dillabaugh
@ 2018-05-01 14:17 ` Craig Dillabaugh
  2018-05-03 15:16 ` [PATCH net-next 0/2] Update csum tc action for batch operation David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: Craig Dillabaugh @ 2018-05-01 14:17 UTC (permalink / raw)
  To: davem; +Cc: netdev, jhs, xiyou.wangcong, Craig Dillabaugh

Signed-off-by: Craig Dillabaugh <cdillaba@mojatatu.com>
---
 .../tc-testing/tc-tests/actions/csum.json          | 74 +++++++++++++++++++++-
 1 file changed, 72 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/csum.json b/tools/testing/selftests/tc-testing/tc-tests/actions/csum.json
index 93cf8fe..3a2f51f 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/actions/csum.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/actions/csum.json
@@ -398,13 +398,83 @@
                 255
             ]
         ],
-        "cmdUnderTest": "for i in `seq 1 32`; do cmd=\"action csum tcp continue index $i \"; args=\"$args$cmd\"; done && $TC actions add $args",
-        "expExitCode": "255",
+        "cmdUnderTest": "bash -c \"for i in \\`seq 1 32\\`; do cmd=\\\"action csum tcp continue index \\$i \\\"; args=\"\\$args\\$cmd\"; done && $TC actions add \\$args\"",
+        "expExitCode": "0",
         "verifyCmd": "$TC actions ls action csum",
         "matchPattern": "^[ \t]+index [0-9]* ref",
         "matchCount": "32",
         "teardown": [
             "$TC actions flush action csum"
         ]
+    },
+    {
+        "id": "b4e9",
+        "name": "Delete batch of 32 csum actions",
+        "category": [
+            "actions",
+            "csum"
+        ],
+        "setup": [
+            [
+                "$TC actions flush action csum",
+                0,
+                1,
+                255
+            ],
+            "bash -c \"for i in \\`seq 1 32\\`; do cmd=\\\"action csum tcp continue index \\$i \\\"; args=\"\\$args\\$cmd\"; done && $TC actions add \\$args\""
+        ],
+        "cmdUnderTest": "bash -c \"for i in \\`seq 1 32\\`; do cmd=\\\"action csum index \\$i \\\"; args=\"\\$args\\$cmd\"; done && $TC actions del \\$args\"",
+        "expExitCode": "0",
+        "verifyCmd": "$TC actions list action csum",
+        "matchPattern": "^[ \t]+index [0-9]+ ref",
+        "matchCount": "0",
+        "teardown": []
+    },
+    {
+        "id": "0015",
+        "name": "Add batch of 32 csum tcp actions with large cookies",
+        "category": [
+            "actions",
+            "csum"
+        ],
+        "setup": [
+            [
+                "$TC actions flush action csum",
+                0,
+                1,
+                255
+            ]
+        ],
+        "cmdUnderTest": "bash -c \"for i in \\`seq 1 32\\`; do cmd=\\\"action csum tcp continue index \\$i cookie aaabbbcccdddeee \\\"; args=\"\\$args\\$cmd\"; done && $TC actions add \\$args\"",
+        "expExitCode": "0",
+        "verifyCmd": "$TC actions ls action csum",
+        "matchPattern": "^[ \t]+index [0-9]* ref",
+        "matchCount": "32",
+        "teardown": [
+            "$TC actions flush action csum"
+        ]
+    },
+    {
+        "id": "989e",
+        "name": "Delete batch of 32 csum actions with large cookies",
+        "category": [
+            "actions",
+            "csum"
+        ],
+        "setup": [
+            [
+                "$TC actions flush action csum",
+                0,
+                1,
+                255
+            ],
+            "bash -c \"for i in \\`seq 1 32\\`; do cmd=\\\"action csum tcp continue index \\$i cookie aaabbbcccdddeee \\\"; args=\"\\$args\\$cmd\"; done && $TC actions add \\$args\""
+        ],
+        "cmdUnderTest": "bash -c \"for i in \\`seq 1 32\\`; do cmd=\\\"action csum index \\$i \\\"; args=\"\\$args\\$cmd\"; done && $TC actions del \\$args\"",
+        "expExitCode": "0",
+        "verifyCmd": "$TC actions list action csum",
+        "matchPattern": "^[ \t]+index [0-9]+ ref",
+        "matchCount": "0",
+        "teardown": []
     }
 ]
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next 0/2] Update csum tc action for batch operation.
  2018-05-01 14:17 [PATCH net-next 0/2] Update csum tc action for batch operation Craig Dillabaugh
  2018-05-01 14:17 ` [PATCH net-next 1/2] net sched: Implemented get_fill_size routine for act_csum Craig Dillabaugh
  2018-05-01 14:17 ` [PATCH net-next 2/2] tc-testing: Updated csum action tests batch create w/wo cookies Craig Dillabaugh
@ 2018-05-03 15:16 ` David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-05-03 15:16 UTC (permalink / raw)
  To: cdillaba; +Cc: netdev, jhs, xiyou.wangcong

From: Craig Dillabaugh <cdillaba@mojatatu.com>
Date: Tue,  1 May 2018 10:17:42 -0400

> This patchset includes two patches the first updating act_csum.c 
> to include the get_fill_size routine required for batch operation, and
> the second including updated TDC tests for the feature.

Series applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-05-03 15:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-01 14:17 [PATCH net-next 0/2] Update csum tc action for batch operation Craig Dillabaugh
2018-05-01 14:17 ` [PATCH net-next 1/2] net sched: Implemented get_fill_size routine for act_csum Craig Dillabaugh
2018-05-01 14:17 ` [PATCH net-next 2/2] tc-testing: Updated csum action tests batch create w/wo cookies Craig Dillabaugh
2018-05-03 15:16 ` [PATCH net-next 0/2] Update csum tc action for batch operation David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.