From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH bpf-next v4 0/4] Hash support for sock Date: Thu, 03 May 2018 14:31:23 -0400 (EDT) Message-ID: <20180503.143123.1034749788277999334.davem@davemloft.net> References: <1525372108-8690-1-git-send-email-john.fastabend@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: borkmann@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org To: john.fastabend@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:50920 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969AbeECSbZ (ORCPT ); Thu, 3 May 2018 14:31:25 -0400 In-Reply-To: <1525372108-8690-1-git-send-email-john.fastabend@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: John Fastabend Date: Thu, 3 May 2018 11:28:24 -0700 > In the original sockmap implementation we got away with using an > array similar to devmap. However, unlike devmap where an ifindex > has a nice 1:1 function into the map we have found some use cases > with sockets that need to be referenced using longer keys. > > This series adds support for a sockhash map reusing as much of > the sockmap code as possible. I made the decision to add sockhash > specific helpers vs trying to generalize the existing helpers > because (a) they have sockmap in the name and (b) the keys are > different types. I prefer to be explicit here rather than play > type games or do something else tricky. > > To test this we duplicate all the sockmap testing except swap out > the sockmap with a sockhash. > > v2: fix file stats and add v2 tag > v3: move tool updates into test patch, move bpftool updates into > its own patch, and fixup the test patch stats to catch the > renamed file and provide only diffs +/- on that. > v4: Add documentation to UAPI bpf.h Acked-by: David S. Miller