From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,1/2] dma-mapping: move dma configuration to bus infrastructure From: Christoph Hellwig Message-Id: <20180503122147.GB18590@lst.de> Date: Thu, 3 May 2018 14:21:47 +0200 To: Thierry Reding Cc: Nipun Gupta , robin.murphy@arm.com, hch@lst.de, linux@armlinux.org.uk, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, bhelgaas@google.com, zajec5@gmail.com, andy.gross@linaro.org, david.brown@linaro.org, dan.j.williams@intel.com, vinod.koul@intel.com, robh+dt@kernel.org, frowand.list@gmail.com, jarkko.sakkinen@linux.intel.com, rafael.j.wysocki@intel.com, dmitry.torokhov@gmail.com, johan@kernel.org, msuchanek@suse.de, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, bharat.bhushan@nxp.com, leoyang.li@nxp.com List-ID: T24gTW9uLCBBcHIgMzAsIDIwMTggYXQgMTI6NDE6MjRQTSArMDIwMCwgVGhpZXJyeSBSZWRpbmcg d3JvdGU6Cj4gT24gU2F0LCBBcHIgMjgsIDIwMTggYXQgMDg6MjE6NThBTSArMDUzMCwgTmlwdW4g R3VwdGEgd3JvdGU6Cj4gWy4uLl0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9ob3N0MXgv YnVzLmMgYi9kcml2ZXJzL2dwdS9ob3N0MXgvYnVzLmMKPiA+IGluZGV4IDg4YTM1NTguLmE5ZWM5 OWQgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9ob3N0MXgvYnVzLmMKPiA+ICsrKyBiL2Ry aXZlcnMvZ3B1L2hvc3QxeC9idXMuYwo+ID4gQEAgLTMxNCw2ICszMTQsMTMgQEAgc3RhdGljIGlu dCBob3N0MXhfZGV2aWNlX21hdGNoKHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZV9k cml2ZXIgKmRydikKPiA+ICAJcmV0dXJuIHN0cmNtcChkZXZfbmFtZShkZXYpLCBkcnYtPm5hbWUp ID09IDA7Cj4gPiAgfQo+ID4gIAo+ID4gK3N0YXRpYyBpbnQgaG9zdDF4X2RtYV9jb25maWd1cmUo c3RydWN0IGRldmljZSAqZGV2KQo+ID4gK3sKPiA+ICsJaWYgKGRldi0+b2Zfbm9kZSkKPiA+ICsJ CXJldHVybiBvZl9kbWFfY29uZmlndXJlKGRldiwgZGV2LT5vZl9ub2RlKTsKPiAKPiBUaGUgY29u ZGl0aW9uYWwgaGVyZSBpcyBzb21ld2hhdCBwb2ludGxlc3Mgc2luY2UgdGhlIG9mX25vZGUgc2hv dWxkCj4gYWx3YXlzIGJlIHNldC4gSWYgaXQgd2VyZW4ndCBpdCBzaG91bGQgYmUgY29uc2lkZXJl ZCBhIGJ1ZyBhbmQgdGhpcwo+IGZ1bmN0aW9uIHdlbGNvbWUgdG8gY3Jhc2ggdG8gbWFrZSB0aGF0 IHZlcnkgb2J2aW91cy4KCkFncmVlZC4gIFBsZWFzZSByZW1vdmUgdGhlIGNoZWNrIGZvciB0aGUg cmVzZW5kLgotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUg InVuc3Vic2NyaWJlIGRtYWVuZ2luZSIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9y ZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIu a2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from verein.lst.de ([213.95.11.211]:43841 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751833AbeECMTH (ORCPT ); Thu, 3 May 2018 08:19:07 -0400 Date: Thu, 3 May 2018 14:21:47 +0200 From: Christoph Hellwig To: Thierry Reding Cc: Nipun Gupta , robin.murphy@arm.com, hch@lst.de, linux@armlinux.org.uk, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, bhelgaas@google.com, zajec5@gmail.com, andy.gross@linaro.org, david.brown@linaro.org, dan.j.williams@intel.com, vinod.koul@intel.com, robh+dt@kernel.org, frowand.list@gmail.com, jarkko.sakkinen@linux.intel.com, rafael.j.wysocki@intel.com, dmitry.torokhov@gmail.com, johan@kernel.org, msuchanek@suse.de, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, bharat.bhushan@nxp.com, leoyang.li@nxp.com Subject: Re: [PATCH v4 1/2] dma-mapping: move dma configuration to bus infrastructure Message-ID: <20180503122147.GB18590@lst.de> (sfid-20180503_141915_129455_3AC02C24) References: <1520868292-2479-1-git-send-email-nipun.gupta@nxp.com> <1524883919-29484-1-git-send-email-nipun.gupta@nxp.com> <20180430104124.GE2476@ulmo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180430104124.GE2476@ulmo> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Apr 30, 2018 at 12:41:24PM +0200, Thierry Reding wrote: > On Sat, Apr 28, 2018 at 08:21:58AM +0530, Nipun Gupta wrote: > [...] > > diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c > > index 88a3558..a9ec99d 100644 > > --- a/drivers/gpu/host1x/bus.c > > +++ b/drivers/gpu/host1x/bus.c > > @@ -314,6 +314,13 @@ static int host1x_device_match(struct device *dev, struct device_driver *drv) > > return strcmp(dev_name(dev), drv->name) == 0; > > } > > > > +static int host1x_dma_configure(struct device *dev) > > +{ > > + if (dev->of_node) > > + return of_dma_configure(dev, dev->of_node); > > The conditional here is somewhat pointless since the of_node should > always be set. If it weren't it should be considered a bug and this > function welcome to crash to make that very obvious. Agreed. Please remove the check for the resend. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v4 1/2] dma-mapping: move dma configuration to bus infrastructure Date: Thu, 3 May 2018 14:21:47 +0200 Message-ID: <20180503122147.GB18590@lst.de> References: <1520868292-2479-1-git-send-email-nipun.gupta@nxp.com> <1524883919-29484-1-git-send-email-nipun.gupta@nxp.com> <20180430104124.GE2476@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180430104124.GE2476@ulmo> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: zajec5@gmail.com, linux-pci@vger.kernel.org, jarkko.sakkinen@linux.intel.com, david.brown@linaro.org, frowand.list@gmail.com, hch@lst.de, m.szyprowski@samsung.com, vinod.koul@intel.com, bharat.bhushan@nxp.com, rafael.j.wysocki@intel.com, linux@armlinux.org.uk, andy.gross@linaro.org, msuchanek@suse.de, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-msm@vger.kernel.org, johan@kernel.org, robh+dt@kernel.org, dri-devel@lists.freedesktop.org, Nipun Gupta , bhelgaas@google.com, dan.j.williams@intel.com, linux-soc@vger.kernel.org, gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org, robin.murphy@arm.com List-Id: linux-tegra@vger.kernel.org T24gTW9uLCBBcHIgMzAsIDIwMTggYXQgMTI6NDE6MjRQTSArMDIwMCwgVGhpZXJyeSBSZWRpbmcg d3JvdGU6Cj4gT24gU2F0LCBBcHIgMjgsIDIwMTggYXQgMDg6MjE6NThBTSArMDUzMCwgTmlwdW4g R3VwdGEgd3JvdGU6Cj4gWy4uLl0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9ob3N0MXgv YnVzLmMgYi9kcml2ZXJzL2dwdS9ob3N0MXgvYnVzLmMKPiA+IGluZGV4IDg4YTM1NTguLmE5ZWM5 OWQgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9ob3N0MXgvYnVzLmMKPiA+ICsrKyBiL2Ry aXZlcnMvZ3B1L2hvc3QxeC9idXMuYwo+ID4gQEAgLTMxNCw2ICszMTQsMTMgQEAgc3RhdGljIGlu dCBob3N0MXhfZGV2aWNlX21hdGNoKHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZV9k cml2ZXIgKmRydikKPiA+ICAJcmV0dXJuIHN0cmNtcChkZXZfbmFtZShkZXYpLCBkcnYtPm5hbWUp ID09IDA7Cj4gPiAgfQo+ID4gIAo+ID4gK3N0YXRpYyBpbnQgaG9zdDF4X2RtYV9jb25maWd1cmUo c3RydWN0IGRldmljZSAqZGV2KQo+ID4gK3sKPiA+ICsJaWYgKGRldi0+b2Zfbm9kZSkKPiA+ICsJ CXJldHVybiBvZl9kbWFfY29uZmlndXJlKGRldiwgZGV2LT5vZl9ub2RlKTsKPiAKPiBUaGUgY29u ZGl0aW9uYWwgaGVyZSBpcyBzb21ld2hhdCBwb2ludGxlc3Mgc2luY2UgdGhlIG9mX25vZGUgc2hv dWxkCj4gYWx3YXlzIGJlIHNldC4gSWYgaXQgd2VyZW4ndCBpdCBzaG91bGQgYmUgY29uc2lkZXJl ZCBhIGJ1ZyBhbmQgdGhpcwo+IGZ1bmN0aW9uIHdlbGNvbWUgdG8gY3Jhc2ggdG8gbWFrZSB0aGF0 IHZlcnkgb2J2aW91cy4KCkFncmVlZC4gIFBsZWFzZSByZW1vdmUgdGhlIGNoZWNrIGZvciB0aGUg cmVzZW5kLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK