Re: [LINUX, v8, 2/2] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Helmut Grohne <h.grohne@intenta.de>
Cc: Naga Sureshkumar Relli <nagasure@xilinx.com>,
	linux-mtd@lists.infradead.org,
	Boris Brezillon <Boris.Brezillon@bootlin.com>
Subject: Re: [LINUX, v8, 2/2] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface
Date: Thu, 3 May 2018 16:25:30 +0200	[thread overview]
Message-ID: <20180503162530.437f147a@xps13> (raw)
In-Reply-To: <20180503125600.vkv5vowdyjz5p2zt@laureti-dev>

Hi Naga,

On Thu, 3 May 2018 14:56:01 +0200, Helmut Grohne <h.grohne@intenta.de>
wrote:

> On Wed, Mar 14, 2018 at 04:18:25PM +0530, Naga Sureshkumar Relli wrote:
> > +	xnand->row_addr_cycles = nand_chip->onfi_params.addr_cycles & 0xF;
> > +	xnand->col_addr_cycles =
> > +				(nand_chip->onfi_params.addr_cycles >> 4) & 0xF;  
> 
> Meanwhile onfi_params have been removed from the mainline and this patch
> no longer builds against v4.17-rc3. Can you resend a version that builds
> against with more recent kernels?

Actually I'm not sure you need addr_cycles from the ONFI param
page. What about non-ONFI chips? Anyway you won't find this entry
anymore as the param page is now freed after probe.

I don't get why you need this though?
Maybe you should have a look at the NAND_ROW_ADDR_3 flag?

Thanks,
Miquèl

> 
> Helmut
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

-- 
Miquel Raynal, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com