From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751271AbeECRIZ (ORCPT ); Thu, 3 May 2018 13:08:25 -0400 Received: from muru.com ([72.249.23.125]:40050 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbeECRIY (ORCPT ); Thu, 3 May 2018 13:08:24 -0400 Date: Thu, 3 May 2018 10:08:20 -0700 From: Tony Lindgren To: Janusz Krzysztofik Cc: Aaro Koskinen , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: omap1: ams-delta: fix deferred_fiq handler Message-ID: <20180503170820.GW98604@atomide.com> References: <20180502183203.16034-1-jmkrzyszt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180502183203.16034-1-jmkrzyszt@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Janusz Krzysztofik [180502 11:34]: > The deferred_fiq handler used to limit hardware operations to IRQ > unmask only, relying on gpio-omap assigned handler performing the ACKs. > Since commit 80ac93c27441 ("gpio: omap: Fix lost edge interrupts") this > is no longer the case as handle_edge_irq() has been replaced with > handle_simmple_irq() which doesn't touch the hardware. > > Add single ACK operation per each active IRQ pin to the handler. While > being at it, move unmask operation out of irq_counter loop so it is > also called only once for each active IRQ pin. Good to hear the fiq handler is confirmed working, applying into omap-for-v4.17/fixes thanks. Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Thu, 3 May 2018 10:08:20 -0700 Subject: [PATCH] arm: omap1: ams-delta: fix deferred_fiq handler In-Reply-To: <20180502183203.16034-1-jmkrzyszt@gmail.com> References: <20180502183203.16034-1-jmkrzyszt@gmail.com> Message-ID: <20180503170820.GW98604@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Janusz Krzysztofik [180502 11:34]: > The deferred_fiq handler used to limit hardware operations to IRQ > unmask only, relying on gpio-omap assigned handler performing the ACKs. > Since commit 80ac93c27441 ("gpio: omap: Fix lost edge interrupts") this > is no longer the case as handle_edge_irq() has been replaced with > handle_simmple_irq() which doesn't touch the hardware. > > Add single ACK operation per each active IRQ pin to the handler. While > being at it, move unmask operation out of irq_counter loop so it is > also called only once for each active IRQ pin. Good to hear the fiq handler is confirmed working, applying into omap-for-v4.17/fixes thanks. Tony